Skip to content

Refactor Button to use data-has-visuals instead of data-no-visuals #7401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
+6 −13
Closed

Refactor Button to use data-has-visuals instead of data-no-visuals #7401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4a3638
Initial plan
Copilot Dec 30, 2025
50564f7
Refactor Button to use data-has-visuals instead of data-no-visuals
Copilot Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/react/src/Button/ButtonBase.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,13 +582,13 @@
}
}

/* PERFORMANCE: Use data-no-visuals attribute instead of :has(.Visual) to avoid descendant scan */
/* PERFORMANCE: Use data-has-visuals attribute instead of :has(.Visual) to avoid descendant scan */
[data-a11y-link-underlines='true'] &:where([data-variant='link']) {
&:where([data-no-visuals='true']) {
&:not([data-has-visuals]) {
text-decoration: underline;
}

&:not([data-no-visuals='true']) {
&[data-has-visuals] {
background-image: linear-gradient(to right, currentColor, currentColor);
background-size: 100% 1.5px;
background-position: 0 calc(100% - 2px);
Expand All @@ -601,12 +601,12 @@
}

[data-a11y-link-underlines='false'] &:where([data-variant='link']) {
&:where([data-no-visuals='true']) {
&:not([data-has-visuals]) {
text-decoration: none;
background-image: none;
}

&:not([data-no-visuals='true']) {
&[data-has-visuals] {
background-image: none;
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/Button/ButtonBase.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ const ButtonBase = forwardRef(({children, as: Component = 'button', ...props}, f
data-block={block ? 'block' : null}
data-inactive={inactive ? true : undefined}
data-loading={Boolean(loading)}
data-no-visuals={!LeadingVisual && !TrailingVisual && !TrailingAction ? true : undefined}
data-has-visuals={LeadingVisual || TrailingVisual || TrailingAction ? true : undefined}
data-size={size}
data-variant={variant}
data-label-wrap={labelWrap}
Expand Down
7 changes: 0 additions & 7 deletions packages/react/src/Button/__tests__/__snapshots__/Button.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ exports[`Button > respects block prop 1`] = `
class="prc-Button-ButtonBase-Eb8-K"
data-block="block"
data-loading="false"
data-no-visuals="true"
data-size="medium"
data-variant="default"
id="test-button"
Expand All @@ -30,7 +29,6 @@ exports[`Button > respects the alignContent prop 1`] = `
<button
class="prc-Button-ButtonBase-Eb8-K"
data-loading="false"
data-no-visuals="true"
data-size="medium"
data-variant="default"
id="test-button"
Expand All @@ -55,7 +53,6 @@ exports[`Button > respects the large size prop 1`] = `
<button
class="prc-Button-ButtonBase-Eb8-K"
data-loading="false"
data-no-visuals="true"
data-size="large"
data-variant="default"
id="test-button"
Expand All @@ -80,7 +77,6 @@ exports[`Button > respects the small size prop 1`] = `
<button
class="prc-Button-ButtonBase-Eb8-K"
data-loading="false"
data-no-visuals="true"
data-size="small"
data-variant="default"
id="test-button"
Expand All @@ -105,7 +101,6 @@ exports[`Button > styles danger button appropriately 1`] = `
<button
class="prc-Button-ButtonBase-Eb8-K"
data-loading="false"
data-no-visuals="true"
data-size="medium"
data-variant="danger"
id="test-button"
Expand All @@ -130,7 +125,6 @@ exports[`Button > styles invisible button appropriately 1`] = `
<button
class="prc-Button-ButtonBase-Eb8-K"
data-loading="false"
data-no-visuals="true"
data-size="medium"
data-variant="invisible"
id="test-button"
Expand All @@ -155,7 +149,6 @@ exports[`Button > styles primary button appropriately 1`] = `
<button
class="prc-Button-ButtonBase-Eb8-K"
data-loading="false"
data-no-visuals="true"
data-size="medium"
data-variant="primary"
id="test-button"
Expand Down