Skip to content

Optimize useAnchoredPosition hook for improved INP and rendering performance #7362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattcosta7 wants to merge 4 commits into
base: main
Choose a base branch
from
+707 −89
Open

Optimize useAnchoredPosition hook for improved INP and rendering performance #7362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
535afd7
improve anchored position tests
mattcosta7 Dec 22, 2025
52dab6e
optimize oimpl
mattcosta7 Dec 22, 2025
e90baa9
Address PR feedback and add changeset
mattcosta7 Dec 22, 2025
699316e
Merge branch 'main' into optimize-anchored-overlay=2
mattcosta7 Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .changeset/optimize-anchored-position.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
"@primer/react": patch
---

Optimized `useAnchoredPosition` hook for improved rendering performance:

- **Reduced layout thrashing**: Batches DOM reads before writes and uses `requestAnimationFrame` to coalesce multiple update triggers
- **Optimized re-renders**: Stores mutable state in refs and only triggers re-renders when position actually changes
- **ResizeObserver support**: Observes both floating and anchor elements for size changes with fallback to window resize events
- **Better late-mounting handling**: Properly detects when conditionally-rendered elements mount

The `dependencies` parameter is now deprecated and ignored - position updates are handled automatically via ResizeObserver and window resize events. The parameter is still accepted for backwards compatibility.
Loading
Loading