-
Notifications
You must be signed in to change notification settings - Fork 18
Add Room integration #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Add Room integration #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgillich
reviewed
Sep 14, 2025
stevensJourney
previously approved these changes
Sep 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some questions, but overall this looks very cool.
core/src/watchosMain/kotlin/com/powersync/DatabaseDriverFactory.watchos.kt
Show resolved
Hide resolved
stevensJourney
previously approved these changes
Sep 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
# Conflicts: # CHANGELOG.md
stevensJourney
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Room integration package for PowerSync.
This works by making the PowerSync SDK run queries against the connection pool managed for Room databases, which ensures that we have no conflict due to multiple write connections.
This uses the new update hooks implemented in the core extension to query for updates after each transaction from the PowerSync SDK. These updates are automatically forwarded to Room (so a sync from PowerSync automatically updates
Flow
s in Room).Because we can't install a general update listener on Room databases, the other direction is more complicated. The best approach I could come up with here is to create a Room flow listening on all tables explicitly, and then call
powersync_update_hook('get')
to forward these writes to PowerSync.One remaining issue is that the driver APIs exposed by Room are async-only. Using
runBlocking
to turn them works, but is a bit hacky and not particularly efficient. I will open an API for asynchronous transactions as a medium-term workaround.