Conversation
Fix gh please pr review reply command failing with GraphQL schema error when replying to review comments. The getThreadIdFromComment() function attempted to query a non-existent pullRequestReviewThread field. ## Changes - Replace non-existent field query with PR's reviewThreads connection - Query threads to find the one containing the target comment ID - Support direct Thread Node ID input as optimization to skip lookup - Update getThreadIdFromComment() signature to accept PR Node ID - Maintain backward compatibility with Database ID and Node ID comment inputs ## Related Issues Closes #251
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello @amondnet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical GraphQL schema validation error that prevented the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces detailed planning documents to address a GraphQL schema error in the review reply functionality. The plan laid out in .please/plans/2026-02-02-fix-review-reply-graphql-error.md is comprehensive, correctly identifying the issue and proposing a solid architectural solution. The approach to query the reviewThreads connection and support direct thread ID inputs is excellent. My review includes one suggestion on the plan to better handle an edge case related to API limits.
- Replace non-existent `pullRequestReviewThread` field with `reviewThreads` query - Add prNodeId parameter to `getThreadIdFromComment()` for PR context - Search through PR's reviewThreads to find thread containing target comment - Support Thread ID (PRRT_...) direct input for efficiency (no API call) - Support Comment ID (PRRC_...) and Database ID (number) via reviewThreads lookup - Add `isThreadNodeId()` and `isCommentNodeId()` utility functions - Update reply command to display appropriate progress messages by ID type Fixes #251
Add 100-comment-per-thread limitation to error message as suggested by @gemini-code-assist[bot]
|
1 participant
Summary
Fix
gh please pr review replycommand failing with GraphQL schema error when replying to review comments.Problem
The
getThreadIdFromComment()function insrc/lib/github-graphql.tsattempts to query a non-existentpullRequestReviewThreadfield on the PR query, causing GraphQL schema validation errors.Error:
Solution
reviewThreadsconnectionChanges
getThreadIdFromComment()to queryreviewThreadsconnectionTest Plan
gh please pr review reply <comment-id> -b "text"with Database IDgh please pr review reply <node-id> -b "text"with Node IDgh please pr review reply <thread-node-id> -b "text"with Thread IDRelated Issues
Closes #251