fix: don't pin peer dep to exact version #1108
Conversation
🦋 Changeset detectedLatest commit: 8490391 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
Warning Rate limit exceeded@juliusmarminge has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 34 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe pull request introduces modifications to two GitHub workflow scripts: Changes
Sequence DiagramsequenceDiagram
participant Script as Release Script
participant Dependencies as Package Dependencies
participant Versions as Version Mapping
Script->>Dependencies: Check Dependencies
alt Is Workspace Dependency
Dependencies->>Versions: Fetch Corresponding Version
Versions-->>Dependencies: Replace Dependency Version
end
Script->>Dependencies: Check Peer Dependencies
alt Is Workspace Dependency
Dependencies->>Versions: Fetch Corresponding Version
Versions-->>Dependencies: Replace Peer Dependency Version
end
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
📦 Bundle size comparison
|
|
A new canary is available for testing. You can install this latest build in your project with: pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add [email protected]
pnpm add @uploadthing/[email protected] |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/release-canary.js (1)
48-52: Consider consolidating the logic for updating dependencies and peerDependencies.The logic for checking and updating
peerDependenciesis nearly identical to the one fordependencies. As a good-to-have refactoring, you could reduce duplication by extracting the common functionality into a helper function that handles both..github/replace-workspace-protocol.ts (1)
37-39: Consider extracting the common logic fordependenciesandpeerDependencies.Currently, the code checks for
workspace:...in dependencies and then replaces it with the appropriate version. This same pattern appears again for peer dependencies. Moving this logic into a small helper function could eliminate duplication and make the code more maintainable.Would you like me to propose a refactor snippet that factors out this repeated logic?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/release-canary.js(1 hunks).github/replace-workspace-protocol.ts(1 hunks)
🔇 Additional comments (2)
.github/release-canary.js (1)
44-44: Logic for replacing workspace dependencies looks good.
This condition ensures that the script updates only those dependencies that are declared via the workspace protocol and have a matching version in the versions object. It effectively prevents accidentally overwriting semver-based dependencies.
.github/replace-workspace-protocol.ts (1)
43-46: Validate fallback behavior when a workspace reference is not found.
If dep in packageVersions is satisfied but the entry in peerDependencies doesn't start with "workspace:", the code does nothing. This might be acceptable, but consider whether you need special handling in situations where the local package might not be strictly pinned with a workspace: prefix. This can help avoid accidental version mismatches.
Please confirm that you intentionally preserve any non-"workspace:" peer dependencies without modification.
Summary by CodeRabbit