-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): 📦 version packages #1115
Conversation
78861c4
to
71e23cf
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
WalkthroughThis pull request involves the removal of a changelog entry and version updates across multiple packages in the UploadThing ecosystem. The changes primarily focus on incrementing versions for packages like Changes
Possibly related PRs
Suggested labels
Suggested reviewers
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
301c8ad
to
e4c6d50
Compare
7cb39fe
to
bc1cef3
Compare
98bd447
to
23f8eaf
Compare
9392825
to
7c45df6
Compare
e214200
to
28272b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
packages/react/CHANGELOG.md (1)
258-259
: Fix markdown formatting for URL.The bare URL should be wrapped in angle brackets for better markdown formatting.
- https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61 + <https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61>🧰 Tools
🪛 Markdownlint (0.37.0)
258-258: null
Bare URL used(MD034, no-bare-urls)
packages/expo/CHANGELOG.md (1)
130-131
: Add missing comma for better readabilityConsider adding a comma after "sometimes" to improve readability.
- fix vite monorepos sometimes complaining about `$RefreshSig$ is not a function` + fix vite monorepos sometimes, complaining about `$RefreshSig$ is not a function`🧰 Tools
🪛 LanguageTool
[uncategorized] ~130-~130: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...(AI_HYDRA_LEO_MISSING_COMMA)
packages/svelte/CHANGELOG.md (2)
3-10
: Consider enhancing the changelog entry with more details.While the entry follows good practices by including PR/commit links and proper crediting, the description "feat: allow custom fetch override" could be more detailed to help users understand the feature's purpose and usage.
Consider expanding the description to include:
- Why this feature was added
- How users can utilize the custom fetch override
- Any breaking changes or migration notes
303-304
: Use proper Markdown link syntax for URLs.Convert the bare URL to proper Markdown link syntax for better maintainability and accessibility.
- https://docs.uploadthing.com/getting-started/svelte + [Svelte Documentation](https://docs.uploadthing.com/getting-started/svelte)🧰 Tools
🪛 Markdownlint (0.37.0)
304-304: null
Bare URL used(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (38)
.changeset/nice-penguins-grow.md
(0 hunks)examples/backend-adapters/client-react/package.json
(1 hunks)examples/backend-adapters/client-vanilla/package.json
(1 hunks)examples/backend-adapters/client-vue/package.json
(1 hunks)examples/backend-adapters/package.json
(1 hunks)examples/backend-adapters/server/package.json
(1 hunks)examples/minimal-appdir/package.json
(1 hunks)examples/minimal-astro-react/package.json
(1 hunks)examples/minimal-expo/package.json
(2 hunks)examples/minimal-nuxt/package.json
(1 hunks)examples/minimal-pagedir/package.json
(1 hunks)examples/minimal-solidstart/package.json
(1 hunks)examples/minimal-sveltekit/package.json
(1 hunks)examples/minimal-tanstack-start/package.json
(1 hunks)examples/profile-picture/package.json
(2 hunks)examples/with-clerk-appdir/package.json
(1 hunks)examples/with-clerk-pagesdir/package.json
(1 hunks)examples/with-clerk-remix/package.json
(1 hunks)examples/with-drizzle-appdir/package.json
(1 hunks)examples/with-drizzle-pagesdir/package.json
(1 hunks)examples/with-novel/package.json
(2 hunks)examples/with-react-image-crop/package.json
(1 hunks)examples/with-serveractions/package.json
(1 hunks)examples/with-tailwindcss/package.json
(1 hunks)packages/expo/CHANGELOG.md
(4 hunks)packages/expo/package.json
(1 hunks)packages/nuxt/CHANGELOG.md
(7 hunks)packages/nuxt/package.json
(1 hunks)packages/react/CHANGELOG.md
(5 hunks)packages/react/package.json
(1 hunks)packages/solid/CHANGELOG.md
(5 hunks)packages/solid/package.json
(1 hunks)packages/svelte/CHANGELOG.md
(4 hunks)packages/svelte/package.json
(1 hunks)packages/uploadthing/CHANGELOG.md
(10 hunks)packages/uploadthing/package.json
(1 hunks)packages/vue/CHANGELOG.md
(4 hunks)packages/vue/package.json
(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/nice-penguins-grow.md
🚧 Files skipped from review as they are similar to previous changes (30)
- packages/vue/package.json
- examples/with-serveractions/package.json
- packages/nuxt/package.json
- examples/backend-adapters/server/package.json
- packages/uploadthing/package.json
- packages/svelte/package.json
- examples/minimal-pagedir/package.json
- examples/with-clerk-remix/package.json
- examples/with-clerk-pagesdir/package.json
- packages/solid/CHANGELOG.md
- packages/solid/package.json
- examples/minimal-astro-react/package.json
- examples/minimal-solidstart/package.json
- examples/minimal-expo/package.json
- examples/with-novel/package.json
- examples/backend-adapters/client-vanilla/package.json
- examples/backend-adapters/package.json
- examples/backend-adapters/client-react/package.json
- examples/with-clerk-appdir/package.json
- examples/minimal-sveltekit/package.json
- examples/with-drizzle-pagesdir/package.json
- examples/minimal-tanstack-start/package.json
- examples/with-react-image-crop/package.json
- examples/minimal-appdir/package.json
- examples/backend-adapters/client-vue/package.json
- examples/with-drizzle-appdir/package.json
- packages/expo/package.json
- examples/with-tailwindcss/package.json
- packages/react/package.json
- examples/minimal-nuxt/package.json
🧰 Additional context used
🪛 LanguageTool
packages/expo/CHANGELOG.md
[uncategorized] ~130-~130: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/nuxt/CHANGELOG.md
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/react/CHANGELOG.md
[uncategorized] ~137-~137: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/svelte/CHANGELOG.md
[style] ~301-~301: Using many exclamation marks might seem excessive (in this case: 14 exclamation marks for a text that’s 10055 characters long)
Context: ...@AlanAcDz! - feat: sveltekit support 📚 Read th...
(EN_EXCESSIVE_EXCLAMATION)
packages/vue/CHANGELOG.md
[uncategorized] ~168-~168: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434
](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[style] ~272-~272: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9238 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🪛 Markdownlint (0.37.0)
packages/react/CHANGELOG.md
258-258: null
Bare URL used
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
304-304: null
Bare URL used
(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md
313-313: null
Bare URL used
(MD034, no-bare-urls)
487-487: null
Bare URL used
(MD034, no-bare-urls)
565-565: null
Bare URL used
(MD034, no-bare-urls)
712-712: null
Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (12)
packages/react/CHANGELOG.md (2)
3-10
: LGTM! Latest version changes are well documented.The changelog entry for version 7.2.0 properly documents:
- The minor change allowing custom fetch override
- Links to PR feat: add custom fetch override #1099 and commit hash
- Credits contributor @juliusmarminge
Line range hint
1-534
: LGTM! The changelog follows best practices.The changelog:
- Follows the Keep a Changelog format
- Uses semantic versioning
- Properly documents breaking changes
- Tracks dependencies
- Credits contributors
🧰 Tools
🪛 Markdownlint (0.37.0)
258-258: null
Bare URL used(MD034, no-bare-urls)
packages/nuxt/CHANGELOG.md (2)
3-9
: LGTM: Version bump and changelog entry are appropriate.The patch version bump to 7.1.6 correctly reflects the dependency update to @uploadthing/[email protected], following semantic versioning principles.
Line range hint
1-241
: LGTM: Changelog format is consistent.The changelog maintains a consistent format across all versions, properly documenting:
- Version numbers
- Change types
- PR references
- Commit hashes
- Contributor credits
packages/expo/CHANGELOG.md (1)
3-16
: LGTM! Well-structured changelog entry.The changelog entry for version 7.2.0 is properly formatted and accurately documents:
- The new custom fetch override feature
- Credit to contributor @juliusmarminge
- Updated dependency on @uploadthing/react
packages/svelte/CHANGELOG.md (1)
Line range hint
1-309
: Well-structured changelog format!The changelog follows the Keep a Changelog format consistently, with proper categorization of changes and clear version history.
🧰 Tools
🪛 Markdownlint (0.37.0)
304-304: null
Bare URL used(MD034, no-bare-urls)
🪛 LanguageTool
[style] ~301-~301: Using many exclamation marks might seem excessive (in this case: 14 exclamation marks for a text that’s 10055 characters long)
Context: ...@AlanAcDz! - feat: sveltekit support 📚 Read th...(EN_EXCESSIVE_EXCLAMATION)
packages/uploadthing/CHANGELOG.md (1)
3-10
: LGTM! The latest version entry is well-documented.The changelog entry for version 7.5.0 is properly formatted and includes:
- Clear description of the minor change (custom fetch override)
- PR reference (feat: add custom fetch override #1099)
- Commit hash reference
- Contributor attribution
examples/profile-picture/package.json (2)
22-22
: LGTM! Version updates align with release objectives.The updates to
@uploadthing/react
(^7.2.0) anduploadthing
(^7.5.0) match the intended release versions mentioned in the PR objectives.Also applies to: 35-35
Line range hint
22-36
: Verify dependency compatibility.Let's ensure the updated packages are compatible with other dependencies in the project.
✅ Verification successful
Dependencies are compatible with the project setup
Based on the codebase analysis, the dependencies are compatible:
@uploadthing/[email protected]
and[email protected]
are being used together in multiple example projects and the core packages- The project uses Next.js 15.1.3, which is compatible with these versions of uploadthing
- The codebase shows consistent usage patterns across different implementations (Next.js App Router, Pages Router, etc.)
- The uploadthing configuration in the project follows the latest API patterns seen in the example implementations
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for potential dependency conflicts and peer dependency requirements # Check if there are any conflicting peer dependencies npm info "@uploadthing/[email protected]" peerDependencies npm info "[email protected]" peerDependencies # Look for any dependency warnings in package-lock.json if [ -f "package-lock.json" ]; then jq '.packages | .[] | select(.dependencies != null) | select(.dependencies["@uploadthing/react"] != null or .dependencies["uploadthing"] != null)' package-lock.json fiLength of output: 890
Script:
#!/bin/bash # Let's try with the latest available versions to understand the peer dependencies npm info "@uploadthing/react" versions npm info "uploadthing" versions # Also check for any usage of these packages in the codebase rg -l "from ['\"]@uploadthing/react['\"]" --type ts --type tsx rg -l "from ['\"]uploadthing['\"]" --type ts --type tsx # Check Next.js version compatibility by looking at the project configuration fd "next.config" --type f --exec cat {}Length of output: 16932
Script:
#!/bin/bash # Let's check for actual usage of these packages in the codebase rg -l "from ['\"]@uploadthing/react['\"]" rg -l "from ['\"]uploadthing['\"]" # Also check for any configuration files related to uploadthing fd "uploadthing.config" --type f --exec cat {} fd "uploadthing" --type f -e ts -e js --exec cat {}Length of output: 54369
packages/vue/CHANGELOG.md (3)
3-10
: LGTM! Changelog entry follows conventions.The changelog entry for version 7.2.0 correctly documents the minor feature addition (custom fetch override) and properly credits the contributor. The version bump follows semantic versioning guidelines for feature additions.
Line range hint
1-280
: LGTM! Changelog aligns with PR objectives.The changelog updates are consistent with the PR objectives:
- Version bump to 7.2.0 matches other packages
- Custom fetch override feature is documented
- Part of the coordinated release across the UploadThing ecosystem
🧰 Tools
🪛 LanguageTool
[uncategorized] ~168-~168: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434
](https://github.com/pingdotgg/...(AI_EN_LECTOR_MISSING_PUNCTUATION)
[style] ~272-~272: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9238 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...(EN_EXCESSIVE_EXCLAMATION)
16-19
: Verify peer dependency compatibility with new fetch override feature.The relaxed peer dependency requirements from version 7.1.5 should be verified to ensure they support the new custom fetch override feature in version 7.2.0.
✅ Verification successful
Let me gather more information about the fetch override feature to ensure compatibility.
Let me try a different approach to check the fetch-related changes.
Peer dependency changes are compatible with the codebase
Based on the analysis of package.json files and fetch-related code across the repository:
- All client packages (@uploadthing/vue, @uploadthing/react, @uploadthing/solid, @uploadthing/svelte, @uploadthing/expo) consistently require
uploadthing: ^7.2.0
as a peer dependency- The relaxed peer dependency requirements mainly affect framework-specific versions (Vue, React, Solid, Svelte)
- The fetch-related code is properly isolated within each package's implementation
The peer dependency changes in v7.1.5 do not interfere with the fetch override functionality, as the core uploadthing package remains properly versioned across all framework implementations.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check peer dependencies in package.json for compatibility # Find and display peer dependencies fd -t f "package.json" -x jq -r '.peerDependencies | select(. != null)'Length of output: 619
Script:
#!/bin/bash # Check for fetch override related changes in recent commits and files rg -l "fetch.*override" --type ts --type vue # Look for any fetch-related configurations or types ast-grep --pattern 'interface $_ { $$$ fetch$_?: $_ $$$ }'Length of output: 141
Script:
#!/bin/bash # Search for fetch-related code in TypeScript files rg -l "fetch" --type ts # Check package versions in package.json files fd -t f "package.json" -x jq -r '{name: .name, version: .version, dependencies: .dependencies, peerDependencies: .peerDependencies} | select(.peerDependencies != null)'Length of output: 4276
be7cad0
to
8f6da27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (5)
packages/react/CHANGELOG.md (1)
258-258
: Consider wrapping bare URL in angle brackets.The bare URL on line 258 should be wrapped in angle brackets for better markdown formatting.
- https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61 + <https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61>🧰 Tools
🪛 Markdownlint (0.37.0)
258-258: null
Bare URL used(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md (1)
313-313
: Consider wrapping bare URLs in angle brackets for better markdown formatting.The following URLs should be wrapped in angle brackets according to markdown best practices:
- https://github.com/Effect-TS/effect/issues/3057 + <https://github.com/Effect-TS/effect/issues/3057> - https://effect.website/docs/guides/observability/logging#built-in-loggers + <https://effect.website/docs/guides/observability/logging#built-in-loggers> - https://docs.uploadthing.com/working-with-files#accessing-files + <https://docs.uploadthing.com/working-with-files#accessing-files> - https://docs.uploadthing.com/getting-started/svelte + <https://docs.uploadthing.com/getting-started/svelte>Also applies to: 487-487, 565-565, 712-712
🧰 Tools
🪛 Markdownlint (0.37.0)
313-313: null
Bare URL used(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md (2)
3-10
: Consider enhancing the feature description.While the changelog entry follows the standard format, it would be helpful to add more context about the benefits and use cases of the custom fetch override feature.
Consider expanding the description like this:
- feat: allow custom fetch override + feat: allow custom fetch override - enables users to provide their own fetch implementation for better control over network requests and compatibility with different environments
303-304
: Fix markdown formatting for the documentation URL.The bare URL should be formatted as a proper markdown link.
Apply this change:
- 📚 Read the docs to get started: - https://docs.uploadthing.com/getting-started/svelte + 📚 Read the [docs](https://docs.uploadthing.com/getting-started/svelte) to get started🧰 Tools
🪛 Markdownlint (0.37.0)
304-304: null
Bare URL used(MD034, no-bare-urls)
packages/vue/CHANGELOG.md (1)
7-10
: Consider enhancing the feature documentation.While the changelog entry is correct, it could be more helpful to users by including a brief example or more details about the custom fetch override feature, similar to how the "Go to Definition" feature was documented in version 7.1.0 (lines 76-92).
Example enhancement:
- feat: allow custom fetch override + feat: allow custom fetch override - enables users to provide their own fetch implementation for + greater control over the upload process. Example: + ```ts + useUploadThing({ + endpoint: "imageUploader", + fetch: customFetchImplementation, + }) + ```
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (38)
.changeset/nice-penguins-grow.md
(0 hunks)examples/backend-adapters/client-react/package.json
(1 hunks)examples/backend-adapters/client-vanilla/package.json
(1 hunks)examples/backend-adapters/client-vue/package.json
(1 hunks)examples/backend-adapters/package.json
(1 hunks)examples/backend-adapters/server/package.json
(1 hunks)examples/minimal-appdir/package.json
(1 hunks)examples/minimal-astro-react/package.json
(1 hunks)examples/minimal-expo/package.json
(2 hunks)examples/minimal-nuxt/package.json
(1 hunks)examples/minimal-pagedir/package.json
(1 hunks)examples/minimal-solidstart/package.json
(1 hunks)examples/minimal-sveltekit/package.json
(1 hunks)examples/minimal-tanstack-start/package.json
(1 hunks)examples/profile-picture/package.json
(2 hunks)examples/with-clerk-appdir/package.json
(1 hunks)examples/with-clerk-pagesdir/package.json
(1 hunks)examples/with-clerk-remix/package.json
(1 hunks)examples/with-drizzle-appdir/package.json
(1 hunks)examples/with-drizzle-pagesdir/package.json
(1 hunks)examples/with-novel/package.json
(2 hunks)examples/with-react-image-crop/package.json
(1 hunks)examples/with-serveractions/package.json
(1 hunks)examples/with-tailwindcss/package.json
(1 hunks)packages/expo/CHANGELOG.md
(4 hunks)packages/expo/package.json
(1 hunks)packages/nuxt/CHANGELOG.md
(7 hunks)packages/nuxt/package.json
(1 hunks)packages/react/CHANGELOG.md
(5 hunks)packages/react/package.json
(1 hunks)packages/solid/CHANGELOG.md
(5 hunks)packages/solid/package.json
(1 hunks)packages/svelte/CHANGELOG.md
(4 hunks)packages/svelte/package.json
(1 hunks)packages/uploadthing/CHANGELOG.md
(10 hunks)packages/uploadthing/package.json
(1 hunks)packages/vue/CHANGELOG.md
(4 hunks)packages/vue/package.json
(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/nice-penguins-grow.md
🚧 Files skipped from review as they are similar to previous changes (31)
- packages/vue/package.json
- packages/nuxt/package.json
- examples/with-clerk-remix/package.json
- examples/with-novel/package.json
- examples/with-tailwindcss/package.json
- examples/minimal-appdir/package.json
- examples/with-drizzle-pagesdir/package.json
- examples/minimal-pagedir/package.json
- packages/expo/package.json
- packages/expo/CHANGELOG.md
- examples/minimal-sveltekit/package.json
- packages/svelte/package.json
- examples/minimal-astro-react/package.json
- examples/with-react-image-crop/package.json
- examples/backend-adapters/package.json
- examples/backend-adapters/client-vue/package.json
- examples/minimal-nuxt/package.json
- examples/minimal-tanstack-start/package.json
- examples/profile-picture/package.json
- examples/backend-adapters/client-vanilla/package.json
- examples/backend-adapters/server/package.json
- examples/with-serveractions/package.json
- examples/with-drizzle-appdir/package.json
- examples/minimal-expo/package.json
- packages/solid/package.json
- examples/minimal-solidstart/package.json
- packages/uploadthing/package.json
- examples/with-clerk-appdir/package.json
- examples/with-clerk-pagesdir/package.json
- examples/backend-adapters/client-react/package.json
- packages/react/package.json
🧰 Additional context used
🪛 LanguageTool
packages/nuxt/CHANGELOG.md
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/react/CHANGELOG.md
[uncategorized] ~137-~137: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/solid/CHANGELOG.md
[uncategorized] ~163-~163: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434
](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~247-~247: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[a1481a2
](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
packages/svelte/CHANGELOG.md
[style] ~301-~301: Using many exclamation marks might seem excessive (in this case: 14 exclamation marks for a text that’s 10055 characters long)
Context: ...@AlanAcDz! - feat: sveltekit support 📚 Read th...
(EN_EXCESSIVE_EXCLAMATION)
packages/vue/CHANGELOG.md
[style] ~272-~272: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9238 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🪛 Markdownlint (0.37.0)
packages/react/CHANGELOG.md
258-258: null
Bare URL used
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
304-304: null
Bare URL used
(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md
313-313: null
Bare URL used
(MD034, no-bare-urls)
487-487: null
Bare URL used
(MD034, no-bare-urls)
565-565: null
Bare URL used
(MD034, no-bare-urls)
712-712: null
Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (10)
packages/solid/CHANGELOG.md (2)
3-10
: LGTM! Changelog entry is well-formatted and consistent with PR objectives.The changelog entry for version 7.2.0 correctly documents:
- The minor version bump for the new feature
- The PR reference (feat: add custom fetch override #1099)
- The commit hash
- Proper attribution to @juliusmarminge
- Clear description of the feature (custom fetch override)
This aligns perfectly with the PR objectives which mention this feature being added across multiple packages.
Line range hint
1-155
: Well-structured changelog following best practices.The changelog demonstrates excellent maintenance with:
- Clear version headers and change categorization
- Consistent formatting across versions
- Proper linking of PRs and commits
- Detailed tracking of dependency updates
- Clear attribution to contributors
packages/react/CHANGELOG.md (2)
3-10
: LGTM! Latest version entry matches PR objectives.The changelog entry for version 7.2.0 correctly documents:
- The minor version bump (7.2.0)
- The feature addition allowing custom fetch override
- Proper attribution to contributor @juliusmarminge
- Link to the relevant PR (feat: add custom fetch override #1099)
Line range hint
1-534
: Excellent changelog structure and documentation.The changelog follows best practices:
- Clear version headers with semantic versioning
- Organized sections for Major/Minor/Patch changes
- Consistent linking to PRs and commits
- Proper attribution to contributors
- Detailed descriptions of changes
🧰 Tools
🪛 Markdownlint (0.37.0)
258-258: null
Bare URL used(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md (1)
3-10
: LGTM! Well-structured changelog entry.The changelog entry for version 7.5.0 follows the standard format with:
- Clear version number
- Proper categorization (Minor Changes)
- Links to PR (feat: add custom fetch override #1099) and commit hash
- Credit to contributor (@juliusmarminge)
- Clear description of changes
packages/svelte/CHANGELOG.md (1)
Line range hint
1-309
: LGTM! Changelog updates align with release strategy.The changelog updates are consistent with the PR objectives, showing this is part of a coordinated release across multiple packages. The version bump to 7.2.0 and the addition of the custom fetch override feature align with the changes in other packages.
🧰 Tools
🪛 Markdownlint (0.37.0)
304-304: null
Bare URL used(MD034, no-bare-urls)
🪛 LanguageTool
[style] ~301-~301: Using many exclamation marks might seem excessive (in this case: 14 exclamation marks for a text that’s 10055 characters long)
Context: ...@AlanAcDz! - feat: sveltekit support 📚 Read th...(EN_EXCESSIVE_EXCLAMATION)
packages/vue/CHANGELOG.md (2)
3-10
: LGTM! Well-structured changelog entry.The new version entry is properly formatted, includes correct PR reference (#1099), credits the contributor, and clearly describes the feature addition. This is consistent with the coordinated release mentioned in the PR objectives.
Line range hint
11-280
: LGTM! Previous entries maintain consistent structure.The historical changelog entries follow proper semantic versioning, maintain consistent formatting, and provide clear documentation of changes with appropriate references to PRs and contributors.
🧰 Tools
🪛 LanguageTool
[style] ~272-~272: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9238 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...(EN_EXCESSIVE_EXCLAMATION)
packages/nuxt/CHANGELOG.md (2)
3-9
: LGTM: Changelog entry follows the standard format.The new version entry is properly structured with:
- Clear version number (7.1.6)
- Correct categorization as patch change
- Well-formatted dependency update with commit reference
7-9
: Verify dependency update aligns with PR objectives.The update to @uploadthing/[email protected] aligns with the PR objectives, which indicate this version introduces custom fetch override capability across all packages.
Run this script to verify version consistency across related packages:
✅ Verification successful
Let me gather more information about the dependency update.
Let me gather one final piece of information to check the specific changes in version 7.2.0.
Based on the search results, I can now make a determination about the dependency update verification.
Dependency update to @uploadthing/[email protected] is correctly aligned with package requirements
The verification shows that:
- The package.json correctly specifies
@uploadthing/vue
as a workspace dependency- The CHANGELOG.md properly documents the update to version 7.2.0
- The package is actively used in the codebase:
- Imported and used in module.ts for styles and configuration
- Used in runtime components (dropzone.ts, button.ts)
- Used in composables (useUploadThing.ts)
The update appears to be properly integrated and the version bump is correctly reflected in the dependency declarations and changelog. No issues were found that would impact the package's functionality or integration.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify version consistency in package.json files # Look for @uploadthing/vue dependency version in package.json # Find and check package.json files fd "package.json" packages/nuxt | xargs cat | jq -r '.dependencies["@uploadthing/vue"] // .devDependencies["@uploadthing/vue"]' # Verify the dependency is listed in changesets fd "CHANGELOG.md" packages/nuxt | xargs rg "@uploadthing/[email protected]"Length of output: 237
Script:
#!/bin/bash # Check the actual changes in the PR for this dependency update rg -A 5 "@uploadthing/vue" packages/nuxt # Check if there are any related configuration or usage changes fd . packages/nuxt -e ts -e vue | xargs rg "uploadthing" # Look for any related changeset files fd . .changeset -e md | xargs catLength of output: 10448
Script:
#!/bin/bash # Check for any commit messages or PR descriptions related to this version rg -B 2 -A 2 "7.2.0" . # Look for any configuration changes related to fetch rg -i "fetch" packages/nuxt/srcLength of output: 102775
e9bdd26
to
d4f764b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/expo/CHANGELOG.md (1)
128-131
: Add missing comma in fix descriptionMinor formatting improvement needed.
- Thanks [@juraj98](https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$RefreshSig$ is not a function` + Thanks [@juraj98](https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$RefreshSig$ is not a function`,🧰 Tools
🪛 LanguageTool
[uncategorized] ~130-~130: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...(AI_HYDRA_LEO_MISSING_COMMA)
packages/nuxt/CHANGELOG.md (1)
233-236
: Consider maintaining a consistent, professional tone in changelog entriesWhile the addition of Vue and Nuxt support is indeed significant, consider removing the exclamation mark to maintain a consistent, professional tone throughout the changelog.
- Thanks [@markflorkowski](https://github.com/markflorkowski)! - feat: vue and - nuxt support! + Thanks [@markflorkowski](https://github.com/markflorkowski) - feat: vue and + nuxt support🧰 Tools
🪛 LanguageTool
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...(EN_EXCESSIVE_EXCLAMATION)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (38)
.changeset/nice-penguins-grow.md
(0 hunks)examples/backend-adapters/client-react/package.json
(1 hunks)examples/backend-adapters/client-vanilla/package.json
(1 hunks)examples/backend-adapters/client-vue/package.json
(1 hunks)examples/backend-adapters/package.json
(1 hunks)examples/backend-adapters/server/package.json
(1 hunks)examples/minimal-appdir/package.json
(1 hunks)examples/minimal-astro-react/package.json
(1 hunks)examples/minimal-expo/package.json
(2 hunks)examples/minimal-nuxt/package.json
(1 hunks)examples/minimal-pagedir/package.json
(1 hunks)examples/minimal-solidstart/package.json
(1 hunks)examples/minimal-sveltekit/package.json
(1 hunks)examples/minimal-tanstack-start/package.json
(1 hunks)examples/profile-picture/package.json
(2 hunks)examples/with-clerk-appdir/package.json
(1 hunks)examples/with-clerk-pagesdir/package.json
(1 hunks)examples/with-clerk-remix/package.json
(1 hunks)examples/with-drizzle-appdir/package.json
(1 hunks)examples/with-drizzle-pagesdir/package.json
(1 hunks)examples/with-novel/package.json
(2 hunks)examples/with-react-image-crop/package.json
(1 hunks)examples/with-serveractions/package.json
(1 hunks)examples/with-tailwindcss/package.json
(1 hunks)packages/expo/CHANGELOG.md
(4 hunks)packages/expo/package.json
(1 hunks)packages/nuxt/CHANGELOG.md
(7 hunks)packages/nuxt/package.json
(1 hunks)packages/react/CHANGELOG.md
(5 hunks)packages/react/package.json
(1 hunks)packages/solid/CHANGELOG.md
(5 hunks)packages/solid/package.json
(1 hunks)packages/svelte/CHANGELOG.md
(4 hunks)packages/svelte/package.json
(1 hunks)packages/uploadthing/CHANGELOG.md
(10 hunks)packages/uploadthing/package.json
(1 hunks)packages/vue/CHANGELOG.md
(4 hunks)packages/vue/package.json
(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/nice-penguins-grow.md
🚧 Files skipped from review as they are similar to previous changes (31)
- examples/backend-adapters/client-vanilla/package.json
- packages/vue/package.json
- packages/nuxt/package.json
- examples/backend-adapters/server/package.json
- packages/solid/package.json
- examples/minimal-astro-react/package.json
- examples/with-serveractions/package.json
- examples/minimal-solidstart/package.json
- examples/with-react-image-crop/package.json
- packages/uploadthing/package.json
- examples/with-novel/package.json
- examples/minimal-sveltekit/package.json
- examples/minimal-expo/package.json
- examples/backend-adapters/client-react/package.json
- examples/with-clerk-remix/package.json
- examples/backend-adapters/client-vue/package.json
- examples/backend-adapters/package.json
- examples/with-tailwindcss/package.json
- examples/with-drizzle-pagesdir/package.json
- packages/svelte/package.json
- examples/with-clerk-pagesdir/package.json
- examples/with-drizzle-appdir/package.json
- examples/with-clerk-appdir/package.json
- examples/minimal-nuxt/package.json
- packages/solid/CHANGELOG.md
- examples/profile-picture/package.json
- packages/expo/package.json
- examples/minimal-appdir/package.json
- examples/minimal-pagedir/package.json
- packages/react/package.json
- examples/minimal-tanstack-start/package.json
🧰 Additional context used
🪛 LanguageTool
packages/expo/CHANGELOG.md
[uncategorized] ~130-~130: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/nuxt/CHANGELOG.md
[uncategorized] ~111-~111: You might be missing the article “the” here.
Context: ...! - fix: options was not forwarded to uploadthing handler correctly - Updated dependenci...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~159-~159: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[079b434
](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/react/CHANGELOG.md
[uncategorized] ~178-~178: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434
](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~289-~289: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[a1481a2
](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~497-~497: You might be missing the article “the” here.
Context: ... UploadButton progress text going under progress bar - Updated dependencies [[`f0a4ae...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
packages/svelte/CHANGELOG.md
[style] ~301-~301: Using many exclamation marks might seem excessive (in this case: 14 exclamation marks for a text that’s 10055 characters long)
Context: ...@AlanAcDz! - feat: sveltekit support 📚 Read th...
(EN_EXCESSIVE_EXCLAMATION)
packages/vue/CHANGELOG.md
[style] ~272-~272: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9238 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🪛 Markdownlint (0.37.0)
packages/react/CHANGELOG.md
258-258: null
Bare URL used
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
304-304: null
Bare URL used
(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md
313-313: null
Bare URL used
(MD034, no-bare-urls)
487-487: null
Bare URL used
(MD034, no-bare-urls)
565-565: null
Bare URL used
(MD034, no-bare-urls)
712-712: null
Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (9)
packages/expo/CHANGELOG.md (2)
3-16
: LGTM! Well-structured changelog entry for version 7.2.0The changelog entry properly documents:
- The minor feature addition (custom fetch override)
- PR reference (feat: add custom fetch override #1099) and commit hash
- Credit to contributor (@juliusmarminge)
- Related dependency updates
Line range hint
83-120
: Excellent documentation of the "Go to Definition" featureThe changelog entry for version 7.1.0 provides comprehensive documentation with clear examples of the new feature implementation across different use cases.
packages/nuxt/CHANGELOG.md (2)
3-9
: LGTM! Version update follows semver correctlyThe changelog entry for version 7.1.6 properly documents the dependency update to @uploadthing/[email protected] and follows the conventional format.
74-82
: Excellent documentation of the "Go to Definition" feature!The changelog entry provides clear and comprehensive documentation of the feature, including its purpose and usage examples. This significantly enhances developer experience.
packages/vue/CHANGELOG.md (1)
3-10
: LGTM! Changelog entry is consistent.The changelog entry correctly documents the minor version bump and the new custom fetch override feature.
packages/svelte/CHANGELOG.md (1)
3-10
: LGTM! Changelog entry is consistent.The changelog entry correctly documents the minor version bump and the new custom fetch override feature.
packages/react/CHANGELOG.md (1)
3-10
: LGTM! Changelog entry is consistent.The changelog entry correctly documents the minor version bump and the new custom fetch override feature.
packages/uploadthing/CHANGELOG.md (2)
3-10
: LGTM! Changelog entry is consistent.The changelog entry correctly documents the minor version bump and the new custom fetch override feature. The version number (7.5.0) differs from the framework packages (7.2.0) which is expected for the core package.
1-1
: Overall changelog consistency looks great!The changes are well-coordinated across all packages:
- All framework packages (@uploadthing/vue, @uploadthing/svelte, @uploadthing/react) bumped to 7.2.0
- Core package (uploadthing) bumped to 7.5.0
- All packages consistently document the custom fetch override feature
- All changes are properly linked to PR feat: add custom fetch override #1099 and commit 36b0df6
d018093
to
5f2ae7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (7)
packages/uploadthing/CHANGELOG.md (1)
324-324
: Consider wrapping bare URLs in angle brackets.For better markdown linting compliance, consider wrapping bare URLs in angle brackets. For example:
- https://docs.uploadthing.com/working-with-files#accessing-files + <https://docs.uploadthing.com/working-with-files#accessing-files>Also applies to: 498-498, 576-576, 723-723
🧰 Tools
🪛 Markdownlint (0.37.0)
324-324: null
Bare URL used(MD034, no-bare-urls)
packages/nuxt/CHANGELOG.md (1)
233-236
: Consider removing redundant exclamation mark.- Thanks [@markflorkowski](https://github.com/markflorkowski)! - feat: vue and nuxt support! + Thanks [@markflorkowski](https://github.com/markflorkowski)! - feat: vue and nuxt support🧰 Tools
🪛 LanguageTool
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...(EN_EXCESSIVE_EXCLAMATION)
packages/shared/CHANGELOG.md (3)
3-10
: Consider enhancing the documentation for JsonArray feature.While the patch change is well-documented with PR and commit references, it would be helpful to include more details about:
- The purpose and use cases of the JsonArray feature
- Examples of supported deeply nested object structures
- Any limitations or considerations when using deeply nested objects
342-343
: Improve URL formatting in documentation links.The bare URL should be wrapped in angle brackets for better markdown formatting:
- https://docs.uploadthing.com/getting-started/svelte + <https://docs.uploadthing.com/getting-started/svelte>🧰 Tools
🪛 Markdownlint (0.37.0)
343-343: null
Bare URL used(MD034, no-bare-urls)
167-169
: Fix typo in documentation.There's a typo in "Multi Part Uplaods":
- Multi Part Uplaods hasve been abstracted away + Multi Part Uploads have been abstracted awaypackages/react/CHANGELOG.md (1)
263-265
: Consider wrapping bare URLs in proper markdown links.For better markdown formatting, consider wrapping the URL in proper markdown syntax:
- https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61 + [example](https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61)🧰 Tools
🪛 Markdownlint (0.37.0)
264-264: null
Bare URL used(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md (1)
309-310
: Consider wrapping bare URLs in proper markdown links.For better markdown formatting, consider wrapping the URL in proper markdown syntax:
- https://docs.uploadthing.com/getting-started/svelte + [Read the docs](https://docs.uploadthing.com/getting-started/svelte)🧰 Tools
🪛 Markdownlint (0.37.0)
310-310: null
Bare URL used(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (40)
.changeset/nice-penguins-grow.md
(0 hunks)examples/backend-adapters/client-react/package.json
(1 hunks)examples/backend-adapters/client-vanilla/package.json
(1 hunks)examples/backend-adapters/client-vue/package.json
(1 hunks)examples/backend-adapters/package.json
(1 hunks)examples/backend-adapters/server/package.json
(1 hunks)examples/minimal-appdir/package.json
(1 hunks)examples/minimal-astro-react/package.json
(1 hunks)examples/minimal-expo/package.json
(2 hunks)examples/minimal-nuxt/package.json
(1 hunks)examples/minimal-pagedir/package.json
(1 hunks)examples/minimal-solidstart/package.json
(1 hunks)examples/minimal-sveltekit/package.json
(1 hunks)examples/minimal-tanstack-start/package.json
(1 hunks)examples/profile-picture/package.json
(2 hunks)examples/with-clerk-appdir/package.json
(1 hunks)examples/with-clerk-pagesdir/package.json
(1 hunks)examples/with-clerk-remix/package.json
(1 hunks)examples/with-drizzle-appdir/package.json
(1 hunks)examples/with-drizzle-pagesdir/package.json
(1 hunks)examples/with-novel/package.json
(2 hunks)examples/with-react-image-crop/package.json
(1 hunks)examples/with-serveractions/package.json
(1 hunks)examples/with-tailwindcss/package.json
(1 hunks)packages/expo/CHANGELOG.md
(4 hunks)packages/expo/package.json
(1 hunks)packages/nuxt/CHANGELOG.md
(7 hunks)packages/nuxt/package.json
(1 hunks)packages/react/CHANGELOG.md
(5 hunks)packages/react/package.json
(1 hunks)packages/shared/CHANGELOG.md
(3 hunks)packages/shared/package.json
(1 hunks)packages/solid/CHANGELOG.md
(5 hunks)packages/solid/package.json
(1 hunks)packages/svelte/CHANGELOG.md
(4 hunks)packages/svelte/package.json
(1 hunks)packages/uploadthing/CHANGELOG.md
(10 hunks)packages/uploadthing/package.json
(1 hunks)packages/vue/CHANGELOG.md
(4 hunks)packages/vue/package.json
(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/nice-penguins-grow.md
✅ Files skipped from review due to trivial changes (1)
- packages/shared/package.json
🚧 Files skipped from review as they are similar to previous changes (32)
- examples/backend-adapters/server/package.json
- packages/nuxt/package.json
- examples/with-clerk-remix/package.json
- examples/with-drizzle-pagesdir/package.json
- examples/with-clerk-appdir/package.json
- packages/solid/package.json
- examples/minimal-nuxt/package.json
- examples/backend-adapters/client-react/package.json
- examples/with-drizzle-appdir/package.json
- examples/backend-adapters/client-vue/package.json
- examples/with-serveractions/package.json
- examples/with-clerk-pagesdir/package.json
- examples/minimal-tanstack-start/package.json
- examples/profile-picture/package.json
- examples/backend-adapters/client-vanilla/package.json
- packages/expo/package.json
- examples/minimal-astro-react/package.json
- examples/minimal-pagedir/package.json
- examples/minimal-appdir/package.json
- packages/vue/package.json
- examples/with-tailwindcss/package.json
- examples/with-react-image-crop/package.json
- examples/backend-adapters/package.json
- packages/expo/CHANGELOG.md
- packages/svelte/package.json
- packages/react/package.json
- packages/uploadthing/package.json
- examples/minimal-expo/package.json
- examples/with-novel/package.json
- packages/solid/CHANGELOG.md
- examples/minimal-sveltekit/package.json
- examples/minimal-solidstart/package.json
🧰 Additional context used
🪛 LanguageTool
packages/nuxt/CHANGELOG.md
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/shared/CHANGELOG.md
[uncategorized] ~179-~179: Possible missing comma found.
Context: ...ly the SDK version was just sent in the header which made it cumbersome to make larg...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~180-~180: The preposition ‘to’ seems more likely in this position.
Context: ...e it cumbersome to make large changes on the API without risking breaking older ...
(AI_HYDRA_LEO_REPLACE_ON_TO)
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...
(MAKE_CHANGES)
[uncategorized] ~265-~265: Possible missing comma found.
Context: ...: remove @effect/schema
from client bundle resulting in up to 15kB less JS shipped...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/vue/CHANGELOG.md
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🪛 Markdownlint (0.37.0)
packages/react/CHANGELOG.md
264-264: null
Bare URL used
(MD034, no-bare-urls)
packages/shared/CHANGELOG.md
214-214: null
Bare URL used
(MD034, no-bare-urls)
343-343: null
Bare URL used
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
310-310: null
Bare URL used
(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md
324-324: null
Bare URL used
(MD034, no-bare-urls)
498-498: null
Bare URL used
(MD034, no-bare-urls)
576-576: null
Bare URL used
(MD034, no-bare-urls)
723-723: null
Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (4)
packages/uploadthing/CHANGELOG.md (1)
3-21
: LGTM! The changelog entry for version 7.5.0 is well structured and informative.The changes are properly categorized into minor and patch changes, with clear references to PR numbers and commit hashes.
packages/nuxt/CHANGELOG.md (2)
3-9
: LGTM! Version entry follows changelog conventions.The new version entry correctly documents the dependency update to
@uploadthing/[email protected]
following the Changesets format.
Line range hint
1-241
: LGTM! Well-maintained changelog with consistent formatting.The changelog maintains excellent traceability with PR links, contributor credits, and detailed descriptions for each change.
packages/vue/CHANGELOG.md (1)
3-16
: LGTM! Consistent version bump and changes.The version bump to 7.2.0 and the changes are consistent across all packages. The minor change for custom fetch override and the dependency update to @uploadthing/[email protected] are properly documented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (7)
packages/react/CHANGELOG.md (2)
264-264
: Consider using a proper Markdown link format.Instead of using a bare URL, consider using proper Markdown link syntax for better readability and maintainability.
-https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61 +[novel-plugin.ts#L50-L61](https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61)🧰 Tools
🪛 Markdownlint (0.37.0)
264-264: null
Bare URL used(MD034, no-bare-urls)
143-143
: Add a comma for better readability.Add a comma after "sometimes" to improve readability of the sentence.
-fix vite monorepos sometimes complaining about `$RefreshSig$ is not a function` +fix vite monorepos sometimes, complaining about `$RefreshSig$ is not a function`🧰 Tools
🪛 LanguageTool
[uncategorized] ~143-~143: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...(AI_HYDRA_LEO_MISSING_COMMA)
packages/svelte/CHANGELOG.md (1)
309-310
: Use proper Markdown link syntax for the documentation URL.Convert the bare URL to proper Markdown link syntax for better accessibility and consistency.
- 📚 Read the docs to get started: - https://docs.uploadthing.com/getting-started/svelte + 📚 [Read the docs to get started](https://docs.uploadthing.com/getting-started/svelte)🧰 Tools
🪛 Markdownlint (0.37.0)
310-310: null
Bare URL used(MD034, no-bare-urls)
packages/shared/CHANGELOG.md (4)
3-10
: LGTM! The changelog entry is well-formatted.The latest version entry (7.1.6) follows the standard changelog format with proper PR reference, commit hash, and clear description of the changes.
Consider adding more details about:
- The previous behavior with deeply nested objects
- Examples of the fixed functionality
- Any breaking changes or migration steps if applicable
342-343
: Format bare URLs as markdown links.Convert bare URLs to proper markdown links for better documentation consistency.
-📚 Read the docs to get started: -https://docs.uploadthing.com/getting-started/svelte +📚 Read the docs to get started: [Svelte Documentation](https://docs.uploadthing.com/getting-started/svelte)🧰 Tools
🪛 Markdownlint (0.37.0)
343-343: null
Bare URL used(MD034, no-bare-urls)
453-458
: Improve error handling documentation reference.Format the error handling documentation reference as a proper markdown link.
-feat: float error messages to client for UploadThingErrors. Read the -[error handling docs 📚](https://docs.uploadthing.com/errors) to find out -more. +feat: float error messages to client for UploadThingErrors. For more information, +see the [Error Handling Documentation 📚](https://docs.uploadthing.com/errors).
167-172
: Enhance major version change documentation.The major version change (7.0.0) would benefit from more detailed documentation.
Consider adding:
- A migration guide from version 6.x to 7.0.0
- Code examples showing the changes in implementation
- Performance benchmarks demonstrating the improvements
- Any potential breaking changes that users should be aware of
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (40)
.changeset/nice-penguins-grow.md
(0 hunks)examples/backend-adapters/client-react/package.json
(1 hunks)examples/backend-adapters/client-vanilla/package.json
(1 hunks)examples/backend-adapters/client-vue/package.json
(1 hunks)examples/backend-adapters/package.json
(1 hunks)examples/backend-adapters/server/package.json
(1 hunks)examples/minimal-appdir/package.json
(1 hunks)examples/minimal-astro-react/package.json
(1 hunks)examples/minimal-expo/package.json
(2 hunks)examples/minimal-nuxt/package.json
(1 hunks)examples/minimal-pagedir/package.json
(1 hunks)examples/minimal-solidstart/package.json
(1 hunks)examples/minimal-sveltekit/package.json
(1 hunks)examples/minimal-tanstack-start/package.json
(1 hunks)examples/profile-picture/package.json
(2 hunks)examples/with-clerk-appdir/package.json
(1 hunks)examples/with-clerk-pagesdir/package.json
(1 hunks)examples/with-clerk-remix/package.json
(1 hunks)examples/with-drizzle-appdir/package.json
(1 hunks)examples/with-drizzle-pagesdir/package.json
(1 hunks)examples/with-novel/package.json
(2 hunks)examples/with-react-image-crop/package.json
(1 hunks)examples/with-serveractions/package.json
(1 hunks)examples/with-tailwindcss/package.json
(1 hunks)packages/expo/CHANGELOG.md
(4 hunks)packages/expo/package.json
(1 hunks)packages/nuxt/CHANGELOG.md
(7 hunks)packages/nuxt/package.json
(1 hunks)packages/react/CHANGELOG.md
(5 hunks)packages/react/package.json
(1 hunks)packages/shared/CHANGELOG.md
(3 hunks)packages/shared/package.json
(1 hunks)packages/solid/CHANGELOG.md
(5 hunks)packages/solid/package.json
(1 hunks)packages/svelte/CHANGELOG.md
(4 hunks)packages/svelte/package.json
(1 hunks)packages/uploadthing/CHANGELOG.md
(10 hunks)packages/uploadthing/package.json
(1 hunks)packages/vue/CHANGELOG.md
(4 hunks)packages/vue/package.json
(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/nice-penguins-grow.md
✅ Files skipped from review due to trivial changes (1)
- packages/shared/package.json
🚧 Files skipped from review as they are similar to previous changes (32)
- examples/with-serveractions/package.json
- packages/nuxt/package.json
- examples/backend-adapters/client-vanilla/package.json
- packages/solid/package.json
- examples/backend-adapters/server/package.json
- packages/expo/CHANGELOG.md
- examples/with-drizzle-appdir/package.json
- packages/vue/package.json
- examples/minimal-pagedir/package.json
- examples/with-react-image-crop/package.json
- examples/minimal-expo/package.json
- packages/svelte/package.json
- examples/minimal-astro-react/package.json
- examples/backend-adapters/package.json
- examples/with-clerk-appdir/package.json
- examples/with-tailwindcss/package.json
- examples/with-novel/package.json
- packages/solid/CHANGELOG.md
- packages/expo/package.json
- examples/backend-adapters/client-vue/package.json
- examples/minimal-appdir/package.json
- examples/backend-adapters/client-react/package.json
- examples/with-clerk-remix/package.json
- examples/minimal-solidstart/package.json
- examples/minimal-nuxt/package.json
- packages/uploadthing/package.json
- examples/minimal-sveltekit/package.json
- examples/minimal-tanstack-start/package.json
- examples/profile-picture/package.json
- packages/react/package.json
- examples/with-clerk-pagesdir/package.json
- examples/with-drizzle-pagesdir/package.json
🧰 Additional context used
🪛 LanguageTool
packages/nuxt/CHANGELOG.md
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/react/CHANGELOG.md
[uncategorized] ~143-~143: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/shared/CHANGELOG.md
[uncategorized] ~132-~132: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~179-~179: Possible missing comma found.
Context: ...ly the SDK version was just sent in the header which made it cumbersome to make larg...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~180-~180: The preposition ‘to’ seems more likely in this position.
Context: ...e it cumbersome to make large changes on the API without risking breaking older ...
(AI_HYDRA_LEO_REPLACE_ON_TO)
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...
(MAKE_CHANGES)
[uncategorized] ~265-~265: Possible missing comma found.
Context: ...: remove @effect/schema
from client bundle resulting in up to 15kB less JS shipped...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/vue/CHANGELOG.md
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🪛 Markdownlint (0.37.0)
packages/react/CHANGELOG.md
264-264: null
Bare URL used
(MD034, no-bare-urls)
packages/shared/CHANGELOG.md
214-214: null
Bare URL used
(MD034, no-bare-urls)
343-343: null
Bare URL used
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
310-310: null
Bare URL used
(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md
324-324: null
Bare URL used
(MD034, no-bare-urls)
498-498: null
Bare URL used
(MD034, no-bare-urls)
576-576: null
Bare URL used
(MD034, no-bare-urls)
723-723: null
Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (10)
packages/react/CHANGELOG.md (1)
3-16
: LGTM! The changelog entry for version 7.2.0 is well-structured.The changelog follows the Keep a Changelog format with clear sections for Minor and Patch changes. The PR link (#1099) and commit hash are properly referenced, and credit is given to the contributor (@juliusmarminge).
packages/vue/CHANGELOG.md (2)
3-16
: LGTM! Well-structured changelog entry.The new version entry follows the proper changelog format, includes clear attribution, and correctly documents both the minor feature addition and dependency update.
Line range hint
1-286
: LGTM! Consistent changelog format maintained.The changelog demonstrates excellent maintenance practices with:
- Consistent formatting across versions
- Clear attribution of changes
- Proper semver versioning
- Detailed documentation of dependencies
🧰 Tools
🪛 LanguageTool
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...(EN_EXCESSIVE_EXCLAMATION)
packages/nuxt/CHANGELOG.md (2)
3-9
: LGTM: Version update follows semantic versioningThe patch version update correctly reflects the dependency update to @uploadthing/[email protected].
74-82
: Excellent documentation of the "Go to Definition" featureThe changelog entry provides clear documentation with practical examples, which greatly helps developers understand and implement the feature.
packages/svelte/CHANGELOG.md (2)
3-16
: LGTM! Well-structured changelog entry.The new version entry follows the Keep a Changelog format and properly documents all necessary information including version, changes, PR reference, and attribution.
Line range hint
1-315
: LGTM! Consistent and well-maintained changelog.The changelog maintains excellent consistency in formatting and structure throughout its history, making it easy to track changes across versions.
🧰 Tools
🪛 Markdownlint (0.37.0)
310-310: null
Bare URL used(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md (3)
3-11
: LGTM! Minor changes are well documented.The changelog entry for version 7.5.0 clearly documents the minor changes:
- Custom fetch override feature (PR feat: add custom fetch override #1099)
- Fix for deeply nested objects with JsonArray (PR fix: allow nested objects in
JsonArray
type #1127)The changes align with the PR objectives and follow the conventional changelog format.
12-18
: LGTM! Patch changes are properly documented.The patch changes section clearly documents the fix for handling deeply nested objects when using JsonArray, with proper PR and commit references.
19-21
: LGTM! Dependencies are properly updated.The dependency updates section correctly documents the update of @uploadthing/shared to version 7.1.6 with proper commit references.
cba93a1
to
c882061
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (5)
packages/react/CHANGELOG.md (1)
264-264
: Convert bare URL to markdown link format.The bare URL should be converted to a proper markdown link for better readability and to comply with markdown best practices.
-https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61 +[Example](https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61)🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
264-264: Bare URL used
null(MD034, no-bare-urls)
packages/shared/CHANGELOG.md (3)
73-81
: Consider updating the documentation for custom identifiers feature.The changelog could benefit from cross-referencing the custom identifiers feature introduced in version 7.1.0 with the implementation in version 6.3.0, as they appear to be related features. This would help users understand the feature evolution.
Also applies to: 412-415
167-172
: Fix typo in changelog entry.There's a typo in the changelog entry for version 7.0.0:
-Multi Part Uplaods hasve been abstracted away +Multi Part Uploads have been abstracted away
179-183
: Improve clarity in version 7.0.0 changelog entry.The explanation of the API version handling could be clearer. Consider restructuring for better readability:
-Previously the SDK version was just sent in the header which made it cumbersome to make large changes on the API without risking breaking older versions. This change improves our flexibility to make changes to the API without needing to do a major bump on the SDK. +Previously, the SDK version was only sent in the header, making it difficult to implement significant API changes without potentially breaking older versions. This change improves our ability to evolve the API independently of the SDK versioning.🧰 Tools
🪛 LanguageTool
[uncategorized] ~179-~179: A comma might be missing here.
Context: ...re: update paths to new api domain Previously the SDK version was just sent in the he...(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~179-~179: A comma might be missing here.
Context: ...ly the SDK version was just sent in the header which made it cumbersome to make larg...(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~180-~180: The preposition “to” seems more likely in this position.
Context: ...e it cumbersome to make large changes on the API without risking breaking older ...(AI_EN_LECTOR_REPLACEMENT_PREPOSITION)
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...(MAKE_CHANGES)
packages/uploadthing/CHANGELOG.md (1)
21-24
: Consider adding implementation examples for the custom fetch override feature.The changelog entry for the custom fetch override feature could benefit from including usage examples to help users understand how to implement this new functionality.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (45)
.changeset/curvy-rings-own.md
(0 hunks).changeset/fair-rockets-beg.md
(0 hunks).changeset/good-tables-jump.md
(0 hunks).changeset/nice-penguins-grow.md
(0 hunks).changeset/purple-shrimps-chew.md
(0 hunks)examples/backend-adapters/client-react/package.json
(1 hunks)examples/backend-adapters/client-vanilla/package.json
(1 hunks)examples/backend-adapters/client-vue/package.json
(1 hunks)examples/backend-adapters/package.json
(1 hunks)examples/backend-adapters/server/package.json
(1 hunks)examples/minimal-appdir/package.json
(1 hunks)examples/minimal-astro-react/package.json
(1 hunks)examples/minimal-expo/package.json
(2 hunks)examples/minimal-nuxt/package.json
(1 hunks)examples/minimal-pagedir/package.json
(1 hunks)examples/minimal-solidstart/package.json
(1 hunks)examples/minimal-sveltekit/package.json
(1 hunks)examples/minimal-tanstack-start/package.json
(1 hunks)examples/profile-picture/package.json
(2 hunks)examples/with-clerk-appdir/package.json
(1 hunks)examples/with-clerk-pagesdir/package.json
(1 hunks)examples/with-clerk-react-router/package.json
(1 hunks)examples/with-clerk-remix/package.json
(1 hunks)examples/with-drizzle-appdir/package.json
(1 hunks)examples/with-drizzle-pagesdir/package.json
(1 hunks)examples/with-novel/package.json
(2 hunks)examples/with-react-image-crop/package.json
(1 hunks)examples/with-serveractions/package.json
(1 hunks)examples/with-tailwindcss/package.json
(1 hunks)packages/expo/CHANGELOG.md
(4 hunks)packages/expo/package.json
(1 hunks)packages/nuxt/CHANGELOG.md
(7 hunks)packages/nuxt/package.json
(1 hunks)packages/react/CHANGELOG.md
(5 hunks)packages/react/package.json
(1 hunks)packages/shared/CHANGELOG.md
(3 hunks)packages/shared/package.json
(1 hunks)packages/solid/CHANGELOG.md
(5 hunks)packages/solid/package.json
(1 hunks)packages/svelte/CHANGELOG.md
(4 hunks)packages/svelte/package.json
(1 hunks)packages/uploadthing/CHANGELOG.md
(10 hunks)packages/uploadthing/package.json
(1 hunks)packages/vue/CHANGELOG.md
(4 hunks)packages/vue/package.json
(1 hunks)
💤 Files with no reviewable changes (5)
- .changeset/good-tables-jump.md
- .changeset/curvy-rings-own.md
- .changeset/fair-rockets-beg.md
- .changeset/nice-penguins-grow.md
- .changeset/purple-shrimps-chew.md
🚧 Files skipped from review as they are similar to previous changes (34)
- packages/shared/package.json
- packages/vue/package.json
- examples/backend-adapters/server/package.json
- packages/nuxt/package.json
- examples/backend-adapters/client-vanilla/package.json
- examples/with-serveractions/package.json
- packages/solid/package.json
- examples/minimal-appdir/package.json
- examples/minimal-astro-react/package.json
- examples/minimal-sveltekit/package.json
- examples/minimal-nuxt/package.json
- examples/with-clerk-remix/package.json
- examples/profile-picture/package.json
- examples/minimal-pagedir/package.json
- examples/minimal-solidstart/package.json
- examples/with-novel/package.json
- examples/with-drizzle-appdir/package.json
- packages/uploadthing/package.json
- examples/with-tailwindcss/package.json
- packages/expo/package.json
- examples/with-drizzle-pagesdir/package.json
- examples/minimal-tanstack-start/package.json
- examples/backend-adapters/client-react/package.json
- examples/with-clerk-pagesdir/package.json
- examples/minimal-expo/package.json
- examples/with-react-image-crop/package.json
- packages/svelte/package.json
- examples/backend-adapters/client-vue/package.json
- packages/expo/CHANGELOG.md
- examples/backend-adapters/package.json
- examples/with-clerk-react-router/package.json
- examples/with-clerk-appdir/package.json
- packages/solid/CHANGELOG.md
- packages/react/package.json
🧰 Additional context used
🪛 LanguageTool
packages/nuxt/CHANGELOG.md
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/shared/CHANGELOG.md
[uncategorized] ~132-~132: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~179-~179: A comma might be missing here.
Context: ...re: update paths to new api domain Previously the SDK version was just sent in the he...
(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~179-~179: A comma might be missing here.
Context: ...ly the SDK version was just sent in the header which made it cumbersome to make larg...
(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~180-~180: The preposition “to” seems more likely in this position.
Context: ...e it cumbersome to make large changes on the API without risking breaking older ...
(AI_EN_LECTOR_REPLACEMENT_PREPOSITION)
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...
(MAKE_CHANGES)
packages/vue/CHANGELOG.md
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🪛 markdownlint-cli2 (0.17.2)
packages/react/CHANGELOG.md
264-264: Bare URL used
null
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
310-310: Bare URL used
null
(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md
351-351: Bare URL used
null
(MD034, no-bare-urls)
525-525: Bare URL used
null
(MD034, no-bare-urls)
603-603: Bare URL used
null
(MD034, no-bare-urls)
750-750: Bare URL used
null
(MD034, no-bare-urls)
🔇 Additional comments (10)
packages/svelte/CHANGELOG.md (1)
3-16
: LGTM! Version entry follows changelog conventions.The new version entry is well-structured with:
- Proper semantic versioning
- Clear feature description
- Correct attribution
- Linked PR and commit references
packages/react/CHANGELOG.md (2)
3-16
: LGTM! Clear and well-structured changelog entry.The latest version entry (7.2.0) is well documented with:
- Clear version number
- Proper categorization of changes (Minor/Patch)
- Link to the related PR (feat: add custom fetch override #1099)
- Credit to the contributor (@juliusmarminge)
- Clear description of the feature
Line range hint
1-571
: LGTM! Well-maintained changelog.The changelog follows good practices:
- Consistent version numbering
- Clear categorization of changes (Major/Minor/Patch)
- Links to PRs and commits
- Credit to contributors
- Detailed descriptions of changes
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
264-264: Bare URL used
null(MD034, no-bare-urls)
packages/shared/CHANGELOG.md (1)
3-10
: LGTM! Clear documentation of the latest changes.The changelog entry for version 7.1.6 properly documents the fix for handling deeply nested objects when using JsonArray, with appropriate reference to PR #1127.
packages/vue/CHANGELOG.md (3)
3-16
: LGTM! Well-structured changelog entry.The new version entry follows proper changelog conventions with clear categorization, proper references, and complete dependency information.
Line range hint
17-286
: LGTM! Historical entries maintain consistency.The historical changelog entries follow a consistent format and provide comprehensive version history with proper references and credits.
🧰 Tools
🪛 LanguageTool
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...(EN_EXCESSIVE_EXCLAMATION)
Line range hint
1-286
: LGTM! Changelog follows best practices.The changelog maintains high documentation standards with proper categorization, consistent formatting, and complete metadata throughout its history.
🧰 Tools
🪛 LanguageTool
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...(EN_EXCESSIVE_EXCLAMATION)
packages/nuxt/CHANGELOG.md (2)
3-9
: LGTM! Version entry follows semver correctly.The patch version bump and dependency update to @uploadthing/[email protected] are consistent with the PR objectives.
Line range hint
15-241
: Excellent changelog maintenance!The changelog demonstrates consistent high quality:
- Clear semantic versioning
- Detailed descriptions with proper PR/commit links
- Consistent formatting
- Proper contributor attribution
packages/uploadthing/CHANGELOG.md (1)
40-44
: Migration required for URL field deprecation.The deprecation of
url
andappUrl
fields requires attention in several areas:
- Update code that directly accesses these fields to use
ufsUrl
instead- Review and update documentation examples
- Consider adding migration notes to your changelog
The change is well-supported with deprecation warnings and backward compatibility, allowing for a gradual transition to the new field.
Run the following script to find usages of the deprecated fields:
✅ Verification successful
URL field deprecation is properly handled with backward compatibility
The deprecation of
url
andappUrl
fields is well-managed with:
- Runtime deprecation warnings when accessing old fields
- Backward compatibility maintained while providing the new
ufsUrl
field- Test coverage updated to verify both old and new field behavior
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Find usages of deprecated url and appUrl fields # Test: Search for field usage in code. Expect: Instances where these fields are used. echo "Searching for deprecated field usages..." rg -A 2 'url: |appUrl: ' || echo "No direct field usage found" echo "Searching for field access..." rg -A 2 '\.url|\.appUrl' || echo "No field access found"Length of output: 60146
4f11470
to
4fa4d59
Compare
218934c
to
ce90b04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (1)
packages/uploadthing/CHANGELOG.md (1)
40-44
: 🛠️ Refactor suggestionMigration guidance needed for URL field deprecation.
The deprecation of
url
andappUrl
fields in favor ofufsUrl
is a significant change that may impact existing implementations. Consider adding migration steps and a deprecation timeline to help users transition smoothly.Note: A similar comment was made in a previous review. The deprecation requires attention in several areas:
- Update code that directly accesses these fields to use
ufsUrl
instead- Review and update documentation examples
- Consider adding migration notes to your changelog
🧹 Nitpick comments (3)
packages/react/CHANGELOG.md (2)
264-264
: Format bare URL as markdown link.The bare URL should be formatted as a markdown link for better readability and consistency.
-https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61 +[Example Implementation](https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61)🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
264-264: Bare URL used
null(MD034, no-bare-urls)
7-10
: Add implementation examples for the custom fetch override feature.The changelog entry would be more helpful if it included examples of how to use the new custom fetch override feature.
Consider adding implementation examples like:
// Example usage of custom fetch override const { useUploadThing } = generateReactHelpers<OurFileRouter>(); function MyComponent() { const { startUpload } = useUploadThing("endpoint", { customFetch: async (url, options) => { // Custom fetch implementation return fetch(url, { ...options, headers: { ...options.headers, 'Custom-Header': 'value' } }); } }); }packages/uploadthing/CHANGELOG.md (1)
21-24
: Consider enhancing documentation for custom fetch override feature.The custom fetch override feature is mentioned but lacks implementation details. Consider adding a code example to demonstrate its usage, similar to how the tailwind plugin is documented.
Thanks [@juliusmarminge](https://github.com/juliusmarminge)! - feat: allow custom fetch override + + Example usage: + ```ts + // Configure custom fetch override + { + customFetch: async (url, options) => { + // Your custom fetch implementation + return fetch(url, { + ...options, + // Custom options + }); + } + } + ```
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (45)
.changeset/curvy-rings-own.md
(0 hunks).changeset/fair-rockets-beg.md
(0 hunks).changeset/good-tables-jump.md
(0 hunks).changeset/nice-penguins-grow.md
(0 hunks).changeset/purple-shrimps-chew.md
(0 hunks)examples/backend-adapters/client-react/package.json
(1 hunks)examples/backend-adapters/client-vanilla/package.json
(1 hunks)examples/backend-adapters/client-vue/package.json
(1 hunks)examples/backend-adapters/package.json
(1 hunks)examples/backend-adapters/server/package.json
(1 hunks)examples/minimal-appdir/package.json
(1 hunks)examples/minimal-astro-react/package.json
(1 hunks)examples/minimal-expo/package.json
(2 hunks)examples/minimal-nuxt/package.json
(1 hunks)examples/minimal-pagedir/package.json
(1 hunks)examples/minimal-solidstart/package.json
(1 hunks)examples/minimal-sveltekit/package.json
(1 hunks)examples/minimal-tanstack-start/package.json
(1 hunks)examples/profile-picture/package.json
(2 hunks)examples/with-clerk-appdir/package.json
(1 hunks)examples/with-clerk-pagesdir/package.json
(1 hunks)examples/with-clerk-react-router/package.json
(1 hunks)examples/with-clerk-remix/package.json
(1 hunks)examples/with-drizzle-appdir/package.json
(1 hunks)examples/with-drizzle-pagesdir/package.json
(1 hunks)examples/with-novel/package.json
(2 hunks)examples/with-react-image-crop/package.json
(1 hunks)examples/with-serveractions/package.json
(1 hunks)examples/with-tailwindcss/package.json
(1 hunks)packages/expo/CHANGELOG.md
(4 hunks)packages/expo/package.json
(1 hunks)packages/nuxt/CHANGELOG.md
(7 hunks)packages/nuxt/package.json
(1 hunks)packages/react/CHANGELOG.md
(5 hunks)packages/react/package.json
(1 hunks)packages/shared/CHANGELOG.md
(3 hunks)packages/shared/package.json
(1 hunks)packages/solid/CHANGELOG.md
(5 hunks)packages/solid/package.json
(1 hunks)packages/svelte/CHANGELOG.md
(4 hunks)packages/svelte/package.json
(1 hunks)packages/uploadthing/CHANGELOG.md
(10 hunks)packages/uploadthing/package.json
(1 hunks)packages/vue/CHANGELOG.md
(4 hunks)packages/vue/package.json
(1 hunks)
💤 Files with no reviewable changes (5)
- .changeset/curvy-rings-own.md
- .changeset/fair-rockets-beg.md
- .changeset/purple-shrimps-chew.md
- .changeset/good-tables-jump.md
- .changeset/nice-penguins-grow.md
🚧 Files skipped from review as they are similar to previous changes (34)
- packages/shared/package.json
- packages/nuxt/package.json
- examples/with-serveractions/package.json
- examples/backend-adapters/server/package.json
- examples/with-clerk-appdir/package.json
- examples/minimal-expo/package.json
- packages/solid/package.json
- examples/minimal-appdir/package.json
- packages/uploadthing/package.json
- packages/expo/CHANGELOG.md
- packages/svelte/package.json
- packages/vue/package.json
- examples/with-drizzle-appdir/package.json
- examples/with-react-image-crop/package.json
- examples/backend-adapters/client-vanilla/package.json
- examples/minimal-sveltekit/package.json
- examples/with-novel/package.json
- examples/with-clerk-pagesdir/package.json
- examples/with-drizzle-pagesdir/package.json
- examples/backend-adapters/package.json
- examples/with-tailwindcss/package.json
- examples/minimal-nuxt/package.json
- examples/minimal-astro-react/package.json
- examples/minimal-solidstart/package.json
- examples/backend-adapters/client-vue/package.json
- examples/minimal-tanstack-start/package.json
- examples/minimal-pagedir/package.json
- examples/backend-adapters/client-react/package.json
- examples/profile-picture/package.json
- examples/with-clerk-react-router/package.json
- packages/react/package.json
- packages/solid/CHANGELOG.md
- examples/with-clerk-remix/package.json
- packages/expo/package.json
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
packages/uploadthing/CHANGELOG.md
351-351: Bare URL used
null
(MD034, no-bare-urls)
525-525: Bare URL used
null
(MD034, no-bare-urls)
603-603: Bare URL used
null
(MD034, no-bare-urls)
750-750: Bare URL used
null
(MD034, no-bare-urls)
packages/react/CHANGELOG.md
264-264: Bare URL used
null
(MD034, no-bare-urls)
🪛 LanguageTool
packages/nuxt/CHANGELOG.md
[uncategorized] ~111-~111: You might be missing the article “the” here.
Context: ...! - fix: options was not forwarded to uploadthing handler correctly - Updated dependenci...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~159-~159: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[079b434
](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/react/CHANGELOG.md
[uncategorized] ~184-~184: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434
](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~295-~295: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[a1481a2
](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~503-~503: You might be missing the article “the” here.
Context: ... UploadButton progress text going under progress bar - Updated dependencies [[`f0a4ae...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
packages/shared/CHANGELOG.md
[uncategorized] ~132-~132: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~179-~179: Possible missing comma found.
Context: ...ly the SDK version was just sent in the header which made it cumbersome to make larg...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~180-~180: The preposition ‘to’ seems more likely in this position.
Context: ...e it cumbersome to make large changes on the API without risking breaking older ...
(AI_HYDRA_LEO_REPLACE_ON_TO)
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...
(MAKE_CHANGES)
packages/svelte/CHANGELOG.md
[uncategorized] ~178-~178: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434
](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~253-~253: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[a1481a2
](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
packages/vue/CHANGELOG.md
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🔇 Additional comments (6)
packages/nuxt/CHANGELOG.md (1)
3-9
: LGTM! Version and dependency updates are properly documented.The changelog correctly documents:
- Version bump to 7.1.6
- Updated dependency @uploadthing/vue to version 7.2.0
packages/vue/CHANGELOG.md (1)
3-16
: LGTM! Version, feature, and dependency updates are properly documented.The changelog correctly documents:
- Version bump to 7.2.0
- New feature: custom fetch override
- Updated dependency @uploadthing/shared to version 7.1.6
packages/svelte/CHANGELOG.md (2)
3-16
: LGTM! Version entry follows changelog best practices.The new version entry is well-structured with:
- Clear feature description
- Proper contributor attribution
- Accurate dependency updates
Line range hint
22-315
: LGTM! Previous version entries maintain consistent documentation.The changelog history is well-maintained with:
- Consistent formatting
- Clear documentation of changes
- Proper references to PRs and commits
🧰 Tools
🪛 LanguageTool
[uncategorized] ~178-~178: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434
](https://github.com/pingdotgg/...(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~253-~253: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[a1481a2
](https://github.com/pingdotgg/...(AI_EN_LECTOR_MISSING_PUNCTUATION)
packages/shared/CHANGELOG.md (2)
3-10
: LGTM! Latest version entry is well documented.The changelog entry for version 7.1.6 properly documents:
- The PR reference (fix: allow nested objects in
JsonArray
type #1127)- The commit hash
- The contributor acknowledgment
- A clear description of the patch change
Line range hint
1-458
: LGTM! Changelog is well-maintained and follows best practices.The changelog demonstrates:
- Consistent version numbering
- Clear categorization of changes (Minor/Patch)
- Proper documentation of breaking changes
- Complete reference tracking (PRs, commits, contributors)
🧰 Tools
🪛 LanguageTool
[uncategorized] ~132-~132: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~179-~179: Possible missing comma found.
Context: ...ly the SDK version was just sent in the header which made it cumbersome to make larg...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~180-~180: The preposition ‘to’ seems more likely in this position.
Context: ...e it cumbersome to make large changes on the API without risking breaking older ...(AI_HYDRA_LEO_REPLACE_ON_TO)
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...(MAKE_CHANGES)
3a53222
to
87dde21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/svelte/CHANGELOG.md (1)
309-310
: Fix the bare URL in documentation.The documentation URL should be wrapped in angle brackets or formatted as a proper markdown link.
-https://docs.uploadthing.com/getting-started/svelte +<https://docs.uploadthing.com/getting-started/svelte>🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
310-310: Bare URL used
null(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (45)
.changeset/curvy-rings-own.md
(0 hunks).changeset/fair-rockets-beg.md
(0 hunks).changeset/good-tables-jump.md
(0 hunks).changeset/nice-penguins-grow.md
(0 hunks).changeset/purple-shrimps-chew.md
(0 hunks)examples/backend-adapters/client-react/package.json
(1 hunks)examples/backend-adapters/client-vanilla/package.json
(1 hunks)examples/backend-adapters/client-vue/package.json
(1 hunks)examples/backend-adapters/package.json
(1 hunks)examples/backend-adapters/server/package.json
(1 hunks)examples/minimal-appdir/package.json
(1 hunks)examples/minimal-astro-react/package.json
(1 hunks)examples/minimal-expo/package.json
(2 hunks)examples/minimal-nuxt/package.json
(1 hunks)examples/minimal-pagedir/package.json
(1 hunks)examples/minimal-solidstart/package.json
(1 hunks)examples/minimal-sveltekit/package.json
(1 hunks)examples/minimal-tanstack-start/package.json
(1 hunks)examples/profile-picture/package.json
(2 hunks)examples/with-clerk-appdir/package.json
(1 hunks)examples/with-clerk-pagesdir/package.json
(1 hunks)examples/with-clerk-react-router/package.json
(1 hunks)examples/with-clerk-remix/package.json
(1 hunks)examples/with-drizzle-appdir/package.json
(1 hunks)examples/with-drizzle-pagesdir/package.json
(1 hunks)examples/with-novel/package.json
(2 hunks)examples/with-react-image-crop/package.json
(1 hunks)examples/with-serveractions/package.json
(1 hunks)examples/with-tailwindcss/package.json
(1 hunks)packages/expo/CHANGELOG.md
(4 hunks)packages/expo/package.json
(1 hunks)packages/nuxt/CHANGELOG.md
(7 hunks)packages/nuxt/package.json
(1 hunks)packages/react/CHANGELOG.md
(5 hunks)packages/react/package.json
(1 hunks)packages/shared/CHANGELOG.md
(3 hunks)packages/shared/package.json
(1 hunks)packages/solid/CHANGELOG.md
(5 hunks)packages/solid/package.json
(1 hunks)packages/svelte/CHANGELOG.md
(4 hunks)packages/svelte/package.json
(1 hunks)packages/uploadthing/CHANGELOG.md
(10 hunks)packages/uploadthing/package.json
(1 hunks)packages/vue/CHANGELOG.md
(4 hunks)packages/vue/package.json
(1 hunks)
💤 Files with no reviewable changes (5)
- .changeset/curvy-rings-own.md
- .changeset/good-tables-jump.md
- .changeset/nice-penguins-grow.md
- .changeset/fair-rockets-beg.md
- .changeset/purple-shrimps-chew.md
🚧 Files skipped from review as they are similar to previous changes (34)
- examples/backend-adapters/server/package.json
- packages/nuxt/package.json
- examples/with-serveractions/package.json
- examples/minimal-sveltekit/package.json
- examples/with-clerk-react-router/package.json
- examples/minimal-nuxt/package.json
- packages/solid/package.json
- examples/with-drizzle-appdir/package.json
- packages/expo/package.json
- packages/vue/package.json
- examples/backend-adapters/client-vanilla/package.json
- examples/with-clerk-remix/package.json
- examples/with-novel/package.json
- packages/shared/package.json
- examples/with-react-image-crop/package.json
- examples/with-clerk-appdir/package.json
- examples/backend-adapters/client-react/package.json
- packages/uploadthing/package.json
- examples/minimal-pagedir/package.json
- examples/minimal-expo/package.json
- examples/minimal-appdir/package.json
- packages/expo/CHANGELOG.md
- examples/backend-adapters/client-vue/package.json
- packages/svelte/package.json
- examples/backend-adapters/package.json
- examples/with-clerk-pagesdir/package.json
- examples/minimal-solidstart/package.json
- examples/with-tailwindcss/package.json
- examples/minimal-astro-react/package.json
- examples/profile-picture/package.json
- examples/with-drizzle-pagesdir/package.json
- packages/react/package.json
- examples/minimal-tanstack-start/package.json
- packages/solid/CHANGELOG.md
🧰 Additional context used
🪛 LanguageTool
packages/nuxt/CHANGELOG.md
[uncategorized] ~111-~111: You might be missing the article “the” here.
Context: ...! - fix: options was not forwarded to uploadthing handler correctly - Updated dependenci...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~159-~159: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[079b434
](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/react/CHANGELOG.md
[uncategorized] ~184-~184: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434
](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~295-~295: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[a1481a2
](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
packages/shared/CHANGELOG.md
[uncategorized] ~179-~179: Possible missing comma found.
Context: ...ly the SDK version was just sent in the header which made it cumbersome to make larg...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~180-~180: The preposition ‘to’ seems more likely in this position.
Context: ...e it cumbersome to make large changes on the API without risking breaking older ...
(AI_HYDRA_LEO_REPLACE_ON_TO)
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...
(MAKE_CHANGES)
[uncategorized] ~265-~265: Possible missing comma found.
Context: ...: remove @effect/schema
from client bundle resulting in up to 15kB less JS shipped...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/svelte/CHANGELOG.md
[uncategorized] ~178-~178: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434
](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~253-~253: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[a1481a2
](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
packages/vue/CHANGELOG.md
[uncategorized] ~174-~174: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434
](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~249-~249: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[a1481a2
](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🪛 markdownlint-cli2 (0.17.2)
packages/react/CHANGELOG.md
264-264: Bare URL used
null
(MD034, no-bare-urls)
packages/shared/CHANGELOG.md
214-214: Bare URL used
null
(MD034, no-bare-urls)
343-343: Bare URL used
null
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
310-310: Bare URL used
null
(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md
351-351: Bare URL used
null
(MD034, no-bare-urls)
525-525: Bare URL used
null
(MD034, no-bare-urls)
603-603: Bare URL used
null
(MD034, no-bare-urls)
750-750: Bare URL used
null
(MD034, no-bare-urls)
🔇 Additional comments (11)
packages/nuxt/CHANGELOG.md (2)
3-9
: LGTM! The new version entry is correctly formatted and aligns with PR objectives.The changelog entry for version 7.1.6 properly documents:
- The patch version increment
- The dependency update to @uploadthing/[email protected]
- The correct commit reference
Line range hint
1-241
: LGTM! The changelog follows best practices.The changelog maintains:
- Clear version sections with semantic versioning
- Proper categorization of changes (Minor/Patch)
- Consistent formatting with PR links and contributor credits
- Detailed descriptions of significant changes
packages/svelte/CHANGELOG.md (1)
3-16
: LGTM! Version 7.2.0 changes are well documented.The changelog entry for version 7.2.0 properly documents:
- The minor change introducing custom fetch override feature
- The dependency update to @uploadthing/[email protected]
- Proper attribution to contributor @juliusmarminge
- Correct PR and commit references
This aligns with the PR objectives which mention the custom fetch override feature being added across multiple packages.
packages/vue/CHANGELOG.md (1)
3-16
: LGTM!The changelog entry for version 7.2.0 is well-structured and properly documents both the minor change (custom fetch override) and the patch change (dependency update).
packages/shared/CHANGELOG.md (1)
3-10
: LGTM!The changelog entry for version 7.1.6 is well-structured and properly documents the patch change for allowing deeply nested objects when using JsonArray.
packages/react/CHANGELOG.md (1)
3-16
: LGTM!The changelog entry for version 7.2.0 is well-structured and properly documents both the minor change (custom fetch override) and the patch change (dependency update).
packages/uploadthing/CHANGELOG.md (5)
7-19
: New Tailwind v4 CSS plugin integrationThe addition of a Tailwind v4 CSS plugin provides a cleaner way to import styles directly into CSS files. The implementation looks good with clear usage examples.
Example usage:
@import "tailwindcss"; @import "uploadthing/tw/v4"; @source "../node_modules/@uploadthing/react/dist"; /** <-- depends on your project structure */
28-34
: Improved error handling in utapiThe patch enhances error handling by ensuring errors are no longer silently ignored when they shouldn't be. This is a good improvement for debugging and reliability.
The change helps developers identify and fix issues more easily by making error conditions more visible.
35-39
: Support for deeply nested objects in JsonArrayThe addition of support for deeply nested objects when using JsonArray improves flexibility in handling complex data structures.
This enhancement allows for more sophisticated data modeling while maintaining compatibility.
46-48
: Dependency updateThe dependency
@uploadthing/shared
has been updated to version 7.1.6.This update ensures compatibility with the latest shared utilities.
40-44
: Migration required for URL field deprecationA new
ufsUrl
field has been introduced with formathttps://APP_ID.ufs.sh/f/FILE_KEY
whileurl
andappUrl
fields are being deprecated. This change requires attention in several areas:
- Update code that directly accesses these fields to use
ufsUrl
instead- Review and update documentation examples
- Consider adding migration notes to your changelog
The change is well-supported with deprecation warnings and backward compatibility, allowing for a gradual transition to the new field.
✅ Verification successful
URL field deprecation is properly implemented with clear migration path
The deprecation of
url
andappUrl
fields is well-implemented with:
- Clear deprecation warnings pointing to the new
ufsUrl
field- Backward compatibility maintained until version 9
- Proper documentation in the changelog
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Find usages of deprecated url and appUrl fields # Test: Search for field usage in code. Expect: Instances where these fields are used. echo "Searching for deprecated field usages..." rg -A 2 'url: |appUrl: ' || echo "No direct field usage found" echo "Searching for field access..." rg -A 2 '\.url|\.appUrl' || echo "No field access found"Length of output: 60146
de4834b
to
d94a9b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (5)
packages/uploadthing/CHANGELOG.md (3)
26-32
: Patch Change: Improved Error Handling in utapi
The fix for improved error handling inutapi
is described succinctly. For added clarity in future releases, consider specifying which error cases are now handled or what conditions prevented errors from being silently ignored.
40-44
: Patch Change: Introduction ofufsUrl
and Deprecation ofurl
&appUrl
This entry clearly documents the addition of the newufsUrl
field along with its expected URL format and the deprecation of theurl
andappUrl
fields. It would be beneficial to ensure that migration guides or deprecation notices are updated in the documentation to help users transition smoothly.
1-2126
: Markdown Styling: Bare URLs in Changelog
The static analysis hints indicate that there are occurrences of bare URLs (e.g., around lines 351, 525, 603, and 750) which may trigger MD034 (no-bare-urls) warnings. Although these may not be directly related to the new changes, it is recommended to review the affected lines and, where possible, wrap URLs in angle brackets or convert them to proper Markdown link syntax to enhance readability and adherence to style guidelines.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
351-351: Bare URL used
null(MD034, no-bare-urls)
525-525: Bare URL used
null(MD034, no-bare-urls)
603-603: Bare URL used
null(MD034, no-bare-urls)
750-750: Bare URL used
null(MD034, no-bare-urls)
packages/shared/CHANGELOG.md (2)
214-214
: Markdown Formatting – Bare URL.
A bare URL is present here. For improved markdown styling and to satisfy linting rules (MD034), consider wrapping this URL in proper link syntax.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
214-214: Bare URL used
null(MD034, no-bare-urls)
342-343
: Documentation Link Format (SvelteKit).
A bare URL is used here. For better markdown compliance, please consider converting it into a proper markdown link.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
343-343: Bare URL used
null(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (45)
.changeset/curvy-rings-own.md
(0 hunks).changeset/fair-rockets-beg.md
(0 hunks).changeset/good-tables-jump.md
(0 hunks).changeset/nice-penguins-grow.md
(0 hunks).changeset/purple-shrimps-chew.md
(0 hunks)examples/backend-adapters/client-react/package.json
(1 hunks)examples/backend-adapters/client-vanilla/package.json
(1 hunks)examples/backend-adapters/client-vue/package.json
(1 hunks)examples/backend-adapters/package.json
(1 hunks)examples/backend-adapters/server/package.json
(1 hunks)examples/minimal-appdir/package.json
(1 hunks)examples/minimal-astro-react/package.json
(1 hunks)examples/minimal-expo/package.json
(2 hunks)examples/minimal-nuxt/package.json
(1 hunks)examples/minimal-pagedir/package.json
(1 hunks)examples/minimal-solidstart/package.json
(1 hunks)examples/minimal-sveltekit/package.json
(1 hunks)examples/minimal-tanstack-start/package.json
(1 hunks)examples/profile-picture/package.json
(2 hunks)examples/with-clerk-appdir/package.json
(1 hunks)examples/with-clerk-pagesdir/package.json
(1 hunks)examples/with-clerk-react-router/package.json
(1 hunks)examples/with-clerk-remix/package.json
(1 hunks)examples/with-drizzle-appdir/package.json
(1 hunks)examples/with-drizzle-pagesdir/package.json
(1 hunks)examples/with-novel/package.json
(2 hunks)examples/with-react-image-crop/package.json
(1 hunks)examples/with-serveractions/package.json
(1 hunks)examples/with-tailwindcss/package.json
(1 hunks)packages/expo/CHANGELOG.md
(4 hunks)packages/expo/package.json
(1 hunks)packages/nuxt/CHANGELOG.md
(7 hunks)packages/nuxt/package.json
(1 hunks)packages/react/CHANGELOG.md
(5 hunks)packages/react/package.json
(1 hunks)packages/shared/CHANGELOG.md
(3 hunks)packages/shared/package.json
(1 hunks)packages/solid/CHANGELOG.md
(5 hunks)packages/solid/package.json
(1 hunks)packages/svelte/CHANGELOG.md
(4 hunks)packages/svelte/package.json
(1 hunks)packages/uploadthing/CHANGELOG.md
(10 hunks)packages/uploadthing/package.json
(1 hunks)packages/vue/CHANGELOG.md
(4 hunks)packages/vue/package.json
(1 hunks)
💤 Files with no reviewable changes (5)
- .changeset/nice-penguins-grow.md
- .changeset/curvy-rings-own.md
- .changeset/fair-rockets-beg.md
- .changeset/good-tables-jump.md
- .changeset/purple-shrimps-chew.md
🚧 Files skipped from review as they are similar to previous changes (34)
- packages/vue/package.json
- packages/solid/package.json
- packages/shared/package.json
- packages/uploadthing/package.json
- examples/with-serveractions/package.json
- packages/nuxt/package.json
- packages/expo/package.json
- examples/with-tailwindcss/package.json
- packages/svelte/package.json
- examples/minimal-astro-react/package.json
- packages/expo/CHANGELOG.md
- examples/with-drizzle-pagesdir/package.json
- examples/with-novel/package.json
- examples/profile-picture/package.json
- examples/with-clerk-pagesdir/package.json
- examples/minimal-expo/package.json
- examples/backend-adapters/server/package.json
- examples/backend-adapters/package.json
- examples/with-drizzle-appdir/package.json
- examples/minimal-appdir/package.json
- examples/minimal-solidstart/package.json
- examples/minimal-sveltekit/package.json
- examples/backend-adapters/client-react/package.json
- examples/backend-adapters/client-vue/package.json
- examples/minimal-tanstack-start/package.json
- packages/react/package.json
- packages/solid/CHANGELOG.md
- examples/with-clerk-appdir/package.json
- examples/backend-adapters/client-vanilla/package.json
- examples/with-clerk-remix/package.json
- examples/minimal-pagedir/package.json
- examples/minimal-nuxt/package.json
- examples/with-react-image-crop/package.json
- examples/with-clerk-react-router/package.json
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
packages/uploadthing/CHANGELOG.md
351-351: Bare URL used
null
(MD034, no-bare-urls)
525-525: Bare URL used
null
(MD034, no-bare-urls)
603-603: Bare URL used
null
(MD034, no-bare-urls)
750-750: Bare URL used
null
(MD034, no-bare-urls)
packages/react/CHANGELOG.md
264-264: Bare URL used
null
(MD034, no-bare-urls)
packages/shared/CHANGELOG.md
214-214: Bare URL used
null
(MD034, no-bare-urls)
343-343: Bare URL used
null
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
310-310: Bare URL used
null
(MD034, no-bare-urls)
🪛 LanguageTool
packages/nuxt/CHANGELOG.md
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/shared/CHANGELOG.md
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...
(MAKE_CHANGES)
packages/vue/CHANGELOG.md
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🔇 Additional comments (94)
packages/uploadthing/CHANGELOG.md (5)
3-3
: Version Header for 7.5.0 Added
The new release header (## 7.5.0
) is clearly introduced to mark the latest version. This helps readers quickly identify the changes included in this release.
5-11
: Minor Change: Tailwind v4 CSS Plugin Entry
The changelog entry for the new Tailwind v4 CSS plugin is well documented. It includes proper attribution, a commit reference, and a clear usage example that explains how to import the new CSS plugin. Please ensure that the usage paths remain accurate with respect to your project structure.
21-25
: Minor Change: Custom Fetch Override Feature
The entry for the custom fetch override is concise and clear. It references the appropriate pull request and commit hash along with proper acknowledgement. This entry neatly conveys the new capability without ambiguity.
35-39
: Patch Change: Support for Deeply Nested Objects in JsonArray
The changelog note for allowing deeply nested objects when usingJsonArray
is well stated. This update is important for handling complex nested data structures and is clearly conveyed in this entry.
46-49
: Dependency Update: @uploadthing/shared Version Bump
The dependency update to@uploadthing/[email protected]
is clearly noted and aligns with the other package updates. This entry is straightforward and meets the documentation standards for dependency changes.packages/nuxt/CHANGELOG.md (5)
3-10
: New Version Entry for 7.1.6 and Dependency Update
A new changelog entry for version 7.1.6 is added, which clearly indicates a patch change updating the dependency to@uploadthing/[email protected]
. This update looks correct and aligns with the release objectives.
15-18
: Patch Change for 7.1.5 – Peer Dependency Relaxation
This segment documents a patch change (pull request [#1108]) that relaxes peer dependency requirements between UploadThing packages. The description is concise and credits the contributor appropriately.
20-22
: Dependency Version Update in 7.1.5
This change updates the dependency for@uploadthing/vue
to version 7.1.5 in the 7.1.5 section. Ensure that the version progression is consistent with the other package changelogs.
28-30
: Dependency Update for Version 7.1.4
The changelog entry here correctly reflects the updated dependency for@uploadthing/vue
to version 7.1.4. The format is consistent with previous entries.
43-47
: Fix for Module Options Not Honored in 7.1.2
This patch change explicitly documents a fix (pull request [#1056]) addressing module options not honored due to static analysis. The note is clear and highlights the improvement in functionality.packages/vue/CHANGELOG.md (6)
3-11
: Version 7.2.0 – Custom Fetch Override Introduced
A new entry for version 7.2.0 is added with a minor change that introduces a custom fetch override. The commit reference and contributor citation are correctly provided.
12-17
: Patch Change – Dependency Update for Shared Module
The patch change updates the dependency@uploadthing/shared
to version 7.1.6. This is clear and matches the expected release changes.
22-26
: Version 7.1.5 – Peer Dependency Relaxation
This segment for version 7.1.5 documents the relaxed peer dependency requirements. The message is clear, and the commit reference is provided.
27-30
: Dependency Downgrade for Version 7.1.5
Here the dependency@uploadthing/shared
is updated to version 7.1.5, which is consistent with the changes shown in the other package files.
31-39
: Version 7.1.4 – Tidy-Up and Dependency Update
This patch change tidies up the peer dependency ranges and updates the dependency to@uploadthing/[email protected]
. The change is precise and well documented.
44-51
: Version 7.1.3 and 7.1.2 – Dependency Updates
The subsequent entries update the dependency versions for older versions (7.1.3 and 7.1.2). The changes are straightforward and ensure historical consistency.packages/svelte/CHANGELOG.md (6)
3-11
: Version 7.2.0 – Custom Fetch Override Feature
A new changelog entry for version 7.2.0 is present with a minor change that adds the custom fetch override feature. The commit reference and credit to the contributor are properly included.
12-17
: Patch Change – Shared Dependency Bump
The dependency@uploadthing/shared
is updated to version 7.1.6 under the patch changes section. This update is clear and aligns with the overall ecosystem update.
22-26
: Version 7.1.5 – Peer Dependency Relaxation
This segment captures the patch change for version 7.1.5 that relaxes peer dependency requirements, with the proper commit and contributor citation.
27-30
: Shared Dependency Update for Version 7.1.5
Consistently, the dependency is further updated to@uploadthing/[email protected]
in this segment.
31-38
: Version 7.1.4 – Dependency Update
This patch section updates the dependency to@uploadthing/[email protected]
for version 7.1.4, maintaining consistency with other changelog files.
39-46
: Versions 7.1.3 and 7.1.2 – Dependency Alignments
The dependency updates for versions 7.1.3 (@uploadthing/[email protected]
) and 7.1.2 (@uploadthing/[email protected]
) are clear, leaving no ambiguity.packages/react/CHANGELOG.md (5)
3-11
: Version 7.2.0 – Introduction of Custom Fetch Override
The entry for version 7.2.0 documents a minor change to allow a custom fetch override. The commit reference and contributor credit are accurate.
12-17
: Patch Change – Shared Dependency Upgrade
The dependency@uploadthing/shared
is updated to 7.1.6 in this patch change section, aligning with updates in other packages.
18-26
: Version 7.1.5 – Peer Dependency Adjustment
This section captures the peer dependency relaxation and subsequent dependency update (@uploadthing/[email protected]
) for version 7.1.5. The information is concise and clear.
31-39
: Version 7.1.4 – Tidying Peer Dependency Ranges
The patch changes for version 7.1.4 include a tidy-up of peer dependency ranges and update the shared dependency to 7.1.4. Both actions are clearly documented.
44-51
: Versions 7.1.3 and 7.1.2 – Consistent Dependency Updates
The dependency updates in the sections for versions 7.1.3 (@uploadthing/[email protected]
) and 7.1.2 (@uploadthing/[email protected]
) are precise and maintain a coherent release history across the ecosystem.packages/shared/CHANGELOG.md (67)
3-10
: Version 7.1.6 Entry Clarity.
The new “7.1.6” section clearly documents the patch change (allowing deeply nested objects for JsonArray) and properly credits the contributor.
16-24
: Version 7.1.5 Documentation.
The “7.1.5” patch changes section explains the chore change and updated dependency clearly. Please double-check that the dependency version update is aligned with the other package changelogs.
29-37
: Version 7.1.4 Patch Updates.
The entry about tidying up peer dependency ranges is concise and clear. Ensure that any dependency adjustments elsewhere remain consistent with this note.
42-45
: Version 7.1.3 – Internal Dependency Bump.
The changelog entry for bumping internal effect dependencies is straightforward and well documented.
51-60
: Version 7.1.2 – Multiple Fixes.
This section documents both the internal effect version bump and the fix for constructing RFC6266-compliant content-disposition headers. The details are clear and complete.
65-67
: Version 7.1.1 Dependency Update.
The updated dependency (mime-types version update) is recorded properly.
73-81
: Version 7.1.0 Minor Change: Route Endpoint Support.
The new feature supporting a custom route endpoint is detailed and includes proper contributor credit.
107-109
: Version 7.1.0 – Internal Effect Dependency Bump.
The additional patch change noting a bump in internal effect dependencies is clear and concise.
124-134
: Version 7.0.3 – Package Removal & Vite Fix.
The patch changes in this section (removing the internal dropzone package and addressing Vite monorepo issues) are clearly documented with proper commit references.
135-139
: Version 7.0.3 – Mime Type Preference Fix.
The note about preferring browser-recognized mime types over file extension lookup is straightforward and well noted.
145-148
: Version 7.0.2 – Correcting Variable Names.
The correction to variable names for accuracy is clearly indicated.
154-156
: Version 7.0.1 – Dependency Update.
The updated dependency (mime-types update) is documented effectively in this patch section.
162-172
: Version 7.0.0 – Major Change (Multipart Uploads Part I).
The section introduces a major feature: multipart uploads using an ingest server. The details clearly explain the benefits such as reduced upload steps and improved performance.
174-183
: Version 7.0.0 – Major Change (API Domain Update).
The follow‐up entry on updating paths to the new API domain and enhancing API flexibility is thorough and well articulated.🧰 Tools
🪛 LanguageTool
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...(MAKE_CHANGES)
189-192
: Version 6.7.9 – API Path Update for Rewrites.
The change to update API paths to skip rewrites is documented clearly, ensuring proper tracking of internal adjustments.
194-198
: Version 6.7.9 – Fix for Number Serialization.
This entry addresses the issue of non‑serializable numbers in router configurations. The description is concise and precise.
200-203
: Version 6.7.8 – Effect/Encoding Refactor.
The refactor to useeffect/Encoding
over Node.js Buffer is clearly noted and appears well considered.
209-213
: Version 6.7.8 – Bumping Effect Versions.
Updating effect versions to fix Cloudflare Workers support is clearly documented.
220-223
: Version 6.7.7 – Pinning Effect Versions.
The update to pin effect versions is clearly recorded with an appropriate commit reference and contributor credit.
229-233
: Version 6.7.6 – Client Bundle Optimization.
The refactor usingeffect/Micro
to reduce the browser bundle size is well detailed and highlights the achieved improvements.
245-247
: Version 6.7.5 – Import Utility Note.
The note detailing that importing utilities should not bloat the bundle (ifEffect
isn’t otherwise used) is informative.
248-252
: Version 6.7.5 – Mimic Dump for Catch-All Types.
Documenting the change to dump all matching mimetypes when using generic catch-all types is clear.
254-257
: Version 6.7.5 – Header Parsing Refactor.
The refactor to support the breaking change in Node.js 20.13 for header parsing is clearly described.
263-266
: Version 6.7.4 – Removing @effect/schema.
The removal of@effect/schema
from the client bundle (resulting in a smaller JS payload) is well documented.
268-271
: Version 6.7.4 – Enhancing Tree-shaking.
SettingsideEffects: false
for better tree-shaking is explained clearly—this should help optimize the client bundle further.
277-280
: Version 6.7.3 – isPollingResponse Fix.
The fix ensuring thatisPollingResponse
correctly checks against response JSON is clearly described.
286-289
: Version 6.7.2 – Handling FiberFailures.
The changelog entry indicating that FiberFailure errors are caught and squashed into the original error is precise and well documented.
291-294
: Version 6.7.2 – Refactoring Upload Utilities.
The note about refactoring parts ofuploadFile
and related utilities to the shared package is clear and supports better modularity.
300-303
: Version 6.7.1 – Adding fast-check Peer Dependency.
The entry adding the missingfast-check
peer dependency improves package stability and is clearly recorded.
305-308
: Version 6.7.1 – Improved Error Logging.
Improved error logging for bad requests is well detailed and should lead to more robust troubleshooting.
310-313
: Version 6.7.1 – Effect Import Update.
Updating “effect” and switching to alias imports is clearly documented and will aid in future maintenance.
319-321
: Version 6.7.0 – Minor Change: logLevel Option.
The addition of thelogLevel
option to facilitate more verbose logging is a useful enhancement.
323-326
: Version 6.7.0 – Vue and Nuxt Support.
Adding support for Vue and Nuxt markedly improves the package’s ecosystem support.
330-332
: Version 6.7.0 – Forcing Dependency Bumps.
The forced dependency bumps provide clarity and consistency across versions.
338-340
: Version 6.6.0 – SvelteKit Support.
Supporting SvelteKit is a timely feature addition; the associated commit and description are clear.
349-352
: Version 6.5.0 – minFileCount Option.
Documenting the addition of theminFileCount
option in RouteConfig is clear and informative.
358-361
: Version 6.4.0 – Verify Callback Data Signature.
The new feature to verify callback data signatures is clearly articulated and adds an important layer of security.
367-369
: Version 6.3.4 – Workspace Protocol Fix.
Fixing the release issue related to theworkspace:
protocol in published distributions is well noted.
375-378
: Version 6.3.3 – API Consistency Improvement.
The changes to make the API more consistent with the available file data are straightforward.
380-383
: Version 6.3.3 – Moving Internal Functions.
Refactoring some internally exported functions to the shared package enhances modularity.
389-392
: Version 6.3.2 – Moving Types to Shared.
Moving some types to the shared package is a solid move to improve code reuse.
394-397
: Version 6.3.2 – Enforcing Compatible Versions.
Enforcing a compatibleuploadthing
version for@uploadthing/react
is clearly described and should prevent mismatches.
403-406
: Version 6.3.1 – CJS Client Splitting Fix.
The fix to force client splitting in .cjs output files is adequately described and important for bundling.
412-415
: Version 6.3.0 – Custom Identifier Feature.
Adding the ability to provide custom identifiers when uploading files is a well-detailed new feature that enhances flexibility.
438-441
: Version 6.3.0 – Presigned Post Uploads.
Introducing presigned post uploads for small files is clearly conveyed and should help reduce overhead.
445-447
: Version 6.3.0 – Bundling Refactor.
The refactor of bundling (#579) is documented succinctly and appears beneficial.
453-458
: Version 6.2.1 – Floating Error Messages.
Floating error messages to the client for UploadThingErrors along with the helpful docs link is excellent for debugging.
464-466
: Version 6.2.0 – Cloudflare Workers Support.
The feature support for Cloudflare Workers is clearly highlighted; the commit details are appropriate.
472-475
: Version 6.1.0 – logLevel Option Addition.
Introducing thelogLevel
option for more verbose logging is beneficial for debugging purposes.
477-481
: Version 6.1.0 – getSignedURL and ACL Options.
The new API methods (utapi.getSignedURL
and ACL configuration) are clearly documented in their added section.
487-490
: Version 6.0.3 – Blob Fallback Implementation.
The fallback to blob filetype if allowed is well described and aids in handling file types gracefully.
496-499
: Version 6.0.2 – Exponential Backoff Fix.
The fix addressing the exponential backoff infinite loop is critical and well documented.
505-508
: Version 6.0.1 – Server Polling Timeout Fix.
The fix for serverdata polling timeout (returning 504) is described clearly and resolves a crucial issue.
514-517
: Version 6.0.0 – Major Change: Multipart Uploads.
The major change introducing multipart uploads (with up to 2x speed improvement) is the highlight of this update and is well documented.
524-526
: Version 5.2.7 – Dependency Update.
The dependency update for@uploadthing/mime-types
to 0.2.2 is clear and fits into the overall release narrative.
532-535
: Version 5.2.6 – Zod Removal Changeset.
The changeset for removing Zod is clearly noted with appropriate thanks to the contributor.
541-544
: Version 5.2.5 – Improved JSON Error Handling.
The improved error handling for invalid JSON parsing is well explained and important for robustness.
550-553
: Version 5.2.4 – Remix Support Improvement.
Adding optional handling for import.meta.env calls improves support for Remix; the change is clearly documented.
559-562
: Version 5.2.3 – Response Wrapping Robustness.
Wrapping response.json in a try-catch block is an effective way to handle unpredictable responses.
568-572
: Version 5.2.2 – Safe Environment Variable Access.
The fix ensuring a safe access of process.env (with a fallback to import.meta.env) is clearly stated and addresses potential issues.
578-581
: Version 5.2.1 – CJS Import Support.
Adding settings to support CommonJS imports is clearly documented and improves interoperability.
587-590
: Version 5.2.0 – Serialization Functions Added.
The addition of serialization functions for UploadthingError enhances error reporting and is well documented.
596-599
: Version 5.1.0 – Error Formatter Improvements.
The improvements to error formatting and the addition of theerrorFormatter
option are clearly outlined and valuable.
603-606
: Version 5.1.0 – Type Declaration Fix.
The change to adjust internal types (to solve declaration emitting issues) strengthens the package’s type safety.
608-610
: Version 5.1.0 – URL Function Order Swap.
Swapping the order of cases ingetUploadthingUrl()
is clearly explained and likely improves reliability.
616-619
: Version 5.0.1 – Simulated Callback Fix.
Adding the missingsize
property to the file object in simulated callbacks addresses a key issue and is correctly documented.
625-632
: Version 5.0.0 – Shared Package Implementation.
Implementing a shared package for types and utilities (and updating dependencies accordingly) is a major consolidation that looks solid and consistent with the rest of the release notes.🧰 Tools
🪛 LanguageTool
[style] ~627-~627: Using many exclamation marks might seem excessive (in this case: 71 exclamation marks for a text that’s 21834 characters long)
Context: ...inge](https://github.com/juliusmarminge)! - implement a shared package that can...(EN_EXCESSIVE_EXCLAMATION)
d48b837
to
30bdf79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (17)
packages/react/CHANGELOG.md (1)
5-10
: Clear Minor Changes Entry
The "### Minor Changes" section for version 7.2.0 accurately documents the feature added in [#1099]—the custom fetch override. The entry includes a direct link to the PR and the commit hash, and it properly acknowledges the contributor. For extra clarity, you might consider adding a brief note on any potential API or integration impacts, if applicable.packages/nuxt/CHANGELOG.md (3)
60-64
: Dynamic Addition and Plugin Configuration Fix
The patch for PR [#1033] addressing the dynamic addition of stylesheets or a Tailwind plugin is well documented.
Nitpick:
There appears to be a typographical issue with the closing mark for the package name—use a consistent backtick (`
) instead of the accent-like character (´
) in@nuxtjs/tailwindcss´
to maintain uniform formatting.
145-150
: Redundant Commit References in Version 7.0.0
The dependency update block for version 7.0.0 lists the same commit hash (d69dd6e
) repeatedly. Consider deduplicating these references for clarity and conciseness.
233-237
: New Feature: Vue and Nuxt Support in Version 6.5.0
The minor change introduces support for Vue and Nuxt.
Nitpick:
Consider moderating the punctuation—the exclamation mark in "nuxt support!" might be toned down to match a consistent, professional changelog style.🧰 Tools
🪛 LanguageTool
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...(EN_EXCESSIVE_EXCLAMATION)
packages/shared/CHANGELOG.md (4)
162-168
: Version 7.0.0 Major Change & Typo Notice
The major change that introduces the ingest server is significant. However, please correct the following typographical errors in the descriptive text:
- "Multi Part Uplaods hasve been" should be "Multipart uploads have been".
A suggested diff:
- Multi Part Uplaods hasve been abstracted away and files are now uploaded as a + Multipart uploads have been abstracted away and files are now uploaded as a
174-178
: Version 7.0.0 – API Domain Update
The entry for updating paths to the new API domain is clear. For improved readability, consider inserting a comma after the contributor acknowledgment. For example:- Thanks [@juliusmarminge](https://github.com/juliusmarminge)! - chore: update paths to new api domain + Thanks [@juliusmarminge](https://github.com/juliusmarminge)!, - chore: update paths to new api domain
214-214
: Markdown Link Consistency
Static analysis has flagged a couple of bare URLs (e.g., the one linking to the upstream issue and another at line 343). To comply with markdownlint guidelines, please consider formatting these URLs as proper Markdown links or wrapping them in angle brackets (e.g.,<https://example.com>
).Also applies to: 343-343
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
214-214: Bare URL used
null(MD034, no-bare-urls)
189-633
: Aggregated Review for Historical Changelog Entries
The remaining changelog entries—from versions 6.7.9 through 5.2.0—are generally well maintained with consistent formatting, clear commit references, and accurate contributor attributions. Please take a moment to review these sections for any minor punctuation issues (as highlighted by static analysis) and to ensure that all bare URLs are formatted in line with Markdown best practices.🧰 Tools
🪛 LanguageTool
[uncategorized] ~417-~417: You might be missing the article “the” here.
Context: ...fiers when uploading files also adds ability for UTApi methods to filter based on cu...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~558-~558: A punctuation mark might be missing here.
Context: ...hub.com//pull/403) [ee8533a
](https://github.com/pingdotgg/...(AI_EN_LECTOR_MISSING_PUNCTUATION)
[style] ~627-~627: Using many exclamation marks might seem excessive (in this case: 71 exclamation marks for a text that’s 21834 characters long)
Context: ...inge](https://github.com/juliusmarminge)! - implement a shared package that can...(EN_EXCESSIVE_EXCLAMATION)
🪛 markdownlint-cli2 (0.17.2)
214-214: Bare URL used
null(MD034, no-bare-urls)
343-343: Bare URL used
null(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md (6)
12-17
: 7.2.0 – Patch Changes: Dependency Update
The patch changes update the dependency for@uploadthing/shared
to 7.1.6 with an appropriate commit reference. Ensure that corresponding package metadata (e.g. in package.json) is updated accordingly.
60-67
: 7.1.1 – Refactor & Dependency Update
The refactor simplifying types for the built file route and the dependency update to@uploadthing/[email protected]
are well noted.
Minor nitpick: The empty brackets[]
after "Updated dependencies" appear unnecessary and could be removed for clarity.
158-160
: 7.0.1 – Dependency Update Note
The dependency update to@uploadthing/[email protected]
is documented here.
Minor nitpick: Consider removing the empty brackets[]
after "Updated dependencies" for consistency.
165-173
: 7.0.0 – Dependency Update: Duplicate Commit References
This section lists multiple entries of the same commit reference ([d69dd6e
]) for updating dependencies to[email protected]
and@uploadthing/[email protected]
. It may improve clarity to deduplicate the commit references.
178-183
: 6.7.0 – Minor Changes: onChange Prop Addition
The changelog now includes a feature that adds theonChange
prop to<UploadButton/>
and<UploadDropzone />
while deprecating theonDrop
prop.
Minor nitpick: A punctuation mark may be needed after the contributor credit on line 178 for consistency.🧰 Tools
🪛 LanguageTool
[uncategorized] ~178-~178: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434
](https://github.com/pingdotgg/...(AI_EN_LECTOR_MISSING_PUNCTUATION)
305-311
: 6.4.0 – Minor Changes: Sveltekit Support
The changelog now highlights Sveltekit support along with a documentation link.
Minor nitpick: The bare URL on line 310 could be wrapped in angle brackets or converted to a markdown link to better comply with markdown best practices.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
310-310: Bare URL used
null(MD034, no-bare-urls)
packages/vue/CHANGELOG.md (2)
174-178
: Version 6.7.0 – Minor Changes Entry
The entry for PR [#886] adds theonChange
prop to<UploadButton/>
and<UploadDropzone />
(while deprecatingonDrop
). The change is clearly documented. It might be worthwhile to ensure that migration notes or documentation updates accompany this breaking change if needed.
275-278
: Version 6.5.0 – Minor Changes (Vue and Nuxt Support)
This entry adds support for Vue and Nuxt (PR [#293]). The description is clear and gives proper credit. As a minor nitpick, the exclamation mark at the end of “nuxt support!” may be a bit informal for a changelog; consider toning it down for a more neutral tone.🧰 Tools
🪛 LanguageTool
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...(EN_EXCESSIVE_EXCLAMATION)
packages/solid/CHANGELOG.md (1)
269-273
: Dependency Update for Version 6.4.1
The update to@uploadthing/[email protected]
is clear. Note that the commit594ae8a
appears twice; consider deduplicating if that repetition is not intentional.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (45)
.changeset/curvy-rings-own.md
(0 hunks).changeset/fair-rockets-beg.md
(0 hunks).changeset/good-tables-jump.md
(0 hunks).changeset/nice-penguins-grow.md
(0 hunks).changeset/purple-shrimps-chew.md
(0 hunks)examples/backend-adapters/client-react/package.json
(1 hunks)examples/backend-adapters/client-vanilla/package.json
(1 hunks)examples/backend-adapters/client-vue/package.json
(1 hunks)examples/backend-adapters/package.json
(1 hunks)examples/backend-adapters/server/package.json
(1 hunks)examples/minimal-appdir/package.json
(1 hunks)examples/minimal-astro-react/package.json
(1 hunks)examples/minimal-expo/package.json
(2 hunks)examples/minimal-nuxt/package.json
(1 hunks)examples/minimal-pagedir/package.json
(1 hunks)examples/minimal-solidstart/package.json
(1 hunks)examples/minimal-sveltekit/package.json
(1 hunks)examples/minimal-tanstack-start/package.json
(1 hunks)examples/profile-picture/package.json
(2 hunks)examples/with-clerk-appdir/package.json
(1 hunks)examples/with-clerk-pagesdir/package.json
(1 hunks)examples/with-clerk-react-router/package.json
(1 hunks)examples/with-clerk-remix/package.json
(1 hunks)examples/with-drizzle-appdir/package.json
(1 hunks)examples/with-drizzle-pagesdir/package.json
(1 hunks)examples/with-novel/package.json
(2 hunks)examples/with-react-image-crop/package.json
(1 hunks)examples/with-serveractions/package.json
(1 hunks)examples/with-tailwindcss/package.json
(1 hunks)packages/expo/CHANGELOG.md
(4 hunks)packages/expo/package.json
(1 hunks)packages/nuxt/CHANGELOG.md
(7 hunks)packages/nuxt/package.json
(1 hunks)packages/react/CHANGELOG.md
(5 hunks)packages/react/package.json
(1 hunks)packages/shared/CHANGELOG.md
(3 hunks)packages/shared/package.json
(1 hunks)packages/solid/CHANGELOG.md
(5 hunks)packages/solid/package.json
(1 hunks)packages/svelte/CHANGELOG.md
(4 hunks)packages/svelte/package.json
(1 hunks)packages/uploadthing/CHANGELOG.md
(10 hunks)packages/uploadthing/package.json
(1 hunks)packages/vue/CHANGELOG.md
(4 hunks)packages/vue/package.json
(1 hunks)
💤 Files with no reviewable changes (5)
- .changeset/purple-shrimps-chew.md
- .changeset/good-tables-jump.md
- .changeset/curvy-rings-own.md
- .changeset/nice-penguins-grow.md
- .changeset/fair-rockets-beg.md
🚧 Files skipped from review as they are similar to previous changes (33)
- examples/backend-adapters/server/package.json
- packages/vue/package.json
- packages/nuxt/package.json
- packages/uploadthing/package.json
- packages/svelte/package.json
- examples/backend-adapters/client-vanilla/package.json
- examples/with-serveractions/package.json
- examples/with-novel/package.json
- examples/minimal-sveltekit/package.json
- examples/minimal-expo/package.json
- examples/with-tailwindcss/package.json
- examples/minimal-nuxt/package.json
- examples/minimal-solidstart/package.json
- examples/with-clerk-react-router/package.json
- packages/expo/package.json
- examples/backend-adapters/client-vue/package.json
- examples/with-react-image-crop/package.json
- examples/with-drizzle-pagesdir/package.json
- examples/with-clerk-appdir/package.json
- packages/solid/package.json
- examples/minimal-appdir/package.json
- examples/backend-adapters/package.json
- packages/shared/package.json
- packages/expo/CHANGELOG.md
- examples/profile-picture/package.json
- examples/minimal-pagedir/package.json
- examples/with-drizzle-appdir/package.json
- examples/with-clerk-pagesdir/package.json
- examples/minimal-tanstack-start/package.json
- examples/backend-adapters/client-react/package.json
- examples/with-clerk-remix/package.json
- examples/minimal-astro-react/package.json
- packages/react/package.json
🧰 Additional context used
🪛 LanguageTool
packages/nuxt/CHANGELOG.md
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/react/CHANGELOG.md
[uncategorized] ~143-~143: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/shared/CHANGELOG.md
[uncategorized] ~179-~179: A comma might be missing here.
Context: ...re: update paths to new api domain Previously the SDK version was just sent in the he...
(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~179-~179: A comma might be missing here.
Context: ...ly the SDK version was just sent in the header which made it cumbersome to make larg...
(AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA)
[uncategorized] ~180-~180: The preposition “to” seems more likely in this position.
Context: ...e it cumbersome to make large changes on the API without risking breaking older ...
(AI_EN_LECTOR_REPLACEMENT_PREPOSITION)
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...
(MAKE_CHANGES)
packages/solid/CHANGELOG.md
[uncategorized] ~169-~169: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434
](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~253-~253: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[a1481a2
](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
packages/svelte/CHANGELOG.md
[uncategorized] ~178-~178: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434
](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[uncategorized] ~253-~253: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[a1481a2
](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
packages/vue/CHANGELOG.md
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🪛 markdownlint-cli2 (0.17.2)
packages/react/CHANGELOG.md
264-264: Bare URL used
null
(MD034, no-bare-urls)
packages/shared/CHANGELOG.md
214-214: Bare URL used
null
(MD034, no-bare-urls)
343-343: Bare URL used
null
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
310-310: Bare URL used
null
(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md
351-351: Bare URL used
null
(MD034, no-bare-urls)
525-525: Bare URL used
null
(MD034, no-bare-urls)
603-603: Bare URL used
null
(MD034, no-bare-urls)
750-750: Bare URL used
null
(MD034, no-bare-urls)
🔇 Additional comments (164)
packages/react/CHANGELOG.md (2)
3-4
: New Version Header Clarity
The header## 7.2.0
clearly denotes the start of a new version section and follows semantic versioning. This makes it easy for users to locate new updates.
12-17
: Accurate Dependency Update Documentation
The "### Patch Changes" section documents the update of the dependency@uploadthing/shared
to version7.1.6
clearly. Please ensure that this update is consistent with the corresponding release notes and that any changes in behavior are well communicated to users.packages/uploadthing/CHANGELOG.md (7)
3-11
: New Version Entry & Tailwind v4 CSS Plugin
The new changelog entry for 7.5.0 is clear and well structured. The added minor change for the Tailwind v4 CSS plugin (lines 7–10) is documented with a link to the pull request and commit, which is great. Please double‐check that the provided usage example meets the current project structure.
12-20
: Tailwind Plugin Usage Code Block
The CSS snippet usage (lines 12–20) is informative and correctly formatted. The inline comment on the dependency path (line 18) is helpful; ensure it remains consistent with any updated documentation.
21-25
: Custom Fetch Override Feature Entry
The changelog entry for the custom fetch override (lines 21–25) is concise and matches similar updates in related packages. Confirm that any migration notes or updates in documentation reflect this new behavior.
26-32
: Patch Change: Improved Error Handling in utapi
This update (lines 26–32) documents the fix that prevents errors from being silently ignored in utapi. The details are clear, and it should help downstream users troubleshoot issues earlier. Please verify that any breaking changes are communicated in the migration guide if necessary.
35-39
: Patch Change: Allow Deeply Nested Objects in JsonArray
The fix for supporting deeply nested objects in JsonArray (lines 35–39) is straightforward and well documented. This should improve compatibility for users managing complex data structures.
40-45
: Patch Change: NewufsUrl
Field & Deprecation Notice
The addition of the newufsUrl
field (lines 40–45) with the prescribed format (https://APP_ID.ufs.sh/f/FILE_KEY
) is clearly stated, along with the deprecation of theurl
andappUrl
fields. This change will require careful migration—please ensure that the documentation and migration guides fully address these updates.
46-49
: Updated Dependencies Section
The dependency update for @uploadthing/[email protected] (lines 46–49) is properly noted. Verify that this version bump is compatible with all related packages and that no downstream issues arise.packages/nuxt/CHANGELOG.md (17)
3-10
: Version 7.1.6 Update: Dependency and Version Header
The changelog entry for version 7.1.6 correctly introduces the new version header and documents the updated dependency (@uploadthing/[email protected]) along with its commit reference.
15-18
: Patch Update for PR [#1108]: Contributor Acknowledgment
The patch change clearly documents PR [#1108] with its commit reference and shows appreciation to [@juliusmarminge]. This entry is clear and informative.
20-22
: Updated Dependency in Version 7.1.5
The updated dependency section now reflects @uploadthing/[email protected]. Please verify that this change is aligned with the package dependency definitions across related files.
28-30
: Dependency Update for Version 7.1.4
The changelog now shows that @uploadthing/vue has been updated to version 7.1.4. Ensure consistency with other package version updates within this release.
43-46
: Fix for Module Options in Version 7.1.2
The entry for PR [#1056] documents the fix for module options not being honored due to static analysis. It is informative and provides proper credit.
55-58
: Refactor Simplification in Version 7.1.1
The changelog entry that simplifies the types for the built file route is clear and concise.
66-67
: Updated Dependency in Version 7.1.1
This entry records the dependency update to @uploadthing/[email protected] accurately.
74-77
: New Feature: "Go to Definition" Support in Version 7.1.0
The minor changes add support for specifying a route endpoint that facilitates "Go to Definition". The contributor details are clearly noted.
79-82
: Detailed Explanation for Endpoint Configuration
The added description about accepting a function for endpoint resolution offers clear context and aids user understanding.
108-111
: Fix for Options Forwarding in Version 7.1.0
The patch entry for correcting the issue where options were not forwarded to the uploadthing handler is precise and well-documented.
113-115
: Dependency Update in the 7.1.0 Patch Section
This section updates @uploadthing/vue to version 7.1.0 with proper commit references. The entry is correct.
122-125
: Version 7.0.3 Dependency Update
The entry properly documents the update for @uploadthing/vue to version 7.0.3.
158-161
: Version 6.5.10 Dependency Update
The changelog correctly reflects the update of @uploadthing/vue to version 6.7.0 along with the associated commit.
180-182
: Version 6.5.7 Dependency Update
This entry documents the update to @uploadthing/[email protected] accurately.
188-191
: Version 6.5.6 Dependency Update
The update to @uploadthing/[email protected] is clearly logged with its commit reference.
224-228
: Fix for Bad Release Artifacts in Version 6.5.1
The patch for addressing bad release artifacts (PR [#767]) is well documented and appropriately credits the contributor.
240-242
: Final Dependency Update for Version 6.5.0
This final patch update correctly registers the updated dependency for @uploadthing/vue to version 6.5.0.packages/shared/CHANGELOG.md (15)
3-11
: New Version 7.1.6 Section Added
The new changelog entry for version 7.1.6 is well structured. It clearly lists the patch changes with the commit reference and properly credits [@juliusmarminge]. Please double-check that the commit link is correct.
16-24
: Version 7.1.5 Update
The patch changes and dependency update for 7.1.5 follow the established format nicely. The updated dependency for@uploadthing/[email protected]
is clearly noted.
29-37
: Version 7.1.4 Entry
The changelog entry for 7.1.4 is concise and maintains consistency with the other versions.
42-46
: Version 7.1.3 Changelog Detail
The patch entry for 7.1.3 (bumping internal effect dependencies) is straightforward and clear.
51-60
: Version 7.1.2 Patch Changes
The entries for 7.1.2 effectively document both the internal effect version bump and the fix for content-disposition header conformance to RFC6266.
65-68
: Version 7.1.1 Dependency Update
The update to@uploadthing/[email protected]
is clearly stated and consistent with the changelog style.
73-82
: Version 7.1.0 Minor Change & Examples
The introduction of support for specifying a route endpoint (for “Go to Definition”) is clearly explained. The associated examples (lines 85–104) provide useful context. If available, consider linking to further documentation for users who want more details.
107-110
: Version 7.1.0 Dependency Bump
The dependency bump on internal effect dependencies is clearly noted.
111-119
: Version 7.1.0 Sensitive Data Handling
The entry detailing the redaction of sensitive fields and the updated dependency (@uploadthing/[email protected]
) is precise and clear.
124-129
: Version 7.0.3 – Internal Package Removal
The removal of the internal dropzone package is well documented to prevent potential peer dependency conflicts.
130-134
: Version 7.0.3 – Vite Monorepo Fix
The fix addressing the Vite monorepo issue (e.g.$RefreshSig$ is not a function
) is clear and concise.
135-140
: Version 7.0.3 – MIME Type Preference
The update to prefer the browser‐recognized MIME type over file extension lookup is clearly described.
145-149
: Version 7.0.2 Variable Name Correction
The correction of variable names in this entry is straightforward and documented appropriately.
154-157
: Version 7.0.1 Dependency Update
The dependency update to@uploadthing/[email protected]
is simple and well noted.
171-173
: Version 7.0.0 – Streaming Upload Process
The changelog clearly explains the removal of polling in favor of a streaming upload process, which should enhance performance and provide instant feedback.packages/svelte/CHANGELOG.md (23)
3-10
: New Version 7.2.0 – Minor Changes Entry Added
This section clearly introduces version 7.2.0 with a new minor feature that allows a custom fetch override. The contributor credit and link to #1099 are properly documented.
22-29
: 7.1.5 – Patch Changes: Peer Dependency Relaxation and Dependency Update
The changes here document relaxed peer dependency requirements (via [#1108]) and update@uploadthing/shared
to 7.1.5. The commit reference and credit are clear.
35-38
: 7.1.4 – Dependency Update Entry
The dependency update to@uploadthing/[email protected]
is straightforward and clearly presented.
43-46
: 7.1.3 – Dependency Update Entry
The update of@uploadthing/shared
to 7.1.3 is clear and concise.
51-55
: 7.1.2 – Dependency Update Entry
This block documents the dependency update to@uploadthing/[email protected]
with dual commit references, providing enough detail for future traceability.
72-80
: 7.1.0 – Minor Changes: Route Endpoint Feature
This section adds support for specifying a route endpoint that enhances the “Go to Definition” feature. The description and contributor credit are clear and the change is well documented.
106-124
: 7.1.0 – Patch Changes: Dependency Bumps and Peer Dependency Updates
The patch changes detail multiple updates:
- Bumped internal effect dependencies ([
01b1363
]).- Updated the Svelte peer dependency range and allowed Svelte v5 ([
176b2e9
], [f73f393
]).- Updated
@uploadthing/shared
to 7.1.0.
All commit references and credits are provided in a clear manner.
129-144
: 7.0.3 – Patch Changes: Dropzone Removal, File Picker Fix, & Dependency Update
This block documents:
- The removal of the internal dropzone package to prevent peer dependency conflicts ([chore: remove dropzone pacakge #977]).
- A fix for a file picker issue ([fix: dropzone behavior #980]).
- The dependency update to
@uploadthing/[email protected]
.
The entries are clear and concise.
150-152
: 7.0.2 – Dependency Update Entry
The update correctly upgrades@uploadthing/shared
to 7.0.2.
186-191
: 6.7.0 – Patch Changes: Dependency Update
The dependency update to@uploadthing/[email protected]
is clearly and succinctly documented.
196-199
: 6.6.3 – Dependency Update Entry
The update of@uploadthing/shared
to 6.7.8 is precise and accurate.
204-207
: 6.6.2 – Dependency Update Entry
The dependency update here correctly advances@uploadthing/shared
to 6.7.7.
212-220
: 6.6.1 – Patch Changes: onUploadProgress Fix & Dependency Update
This section fixes out-of-orderonUploadProgress
events (thanks to [#860]) and updates@uploadthing/shared
to 6.7.6. The documentation is clear and well organized.
225-229
: 6.6.0 – Minor Changes: Adding onDrop Prop
The new addition of theonDrop
prop for theUploadDropzone
component is captured clearly.
232-237
: 6.6.0 – Patch Changes: Dependency Update
The patch changes update@uploadthing/shared
to 6.7.5 in a clear, concise manner.
242-247
: 6.5.4 – Patch Changes: Multiple Dependency Updates
This block documents updates to both@uploadthing/shared
(now 6.7.4) and@uploadthing/[email protected]
. The changes are clearly delineated.
252-255
: 6.5.3 – Dependency Update Entry
The update to@uploadthing/[email protected]
is straightforward and clear.🧰 Tools
🪛 LanguageTool
[uncategorized] ~253-~253: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[a1481a2
](https://github.com/pingdotgg/...(AI_EN_LECTOR_MISSING_PUNCTUATION)
260-264
: 6.5.2 – Dependency Update Entry
This section correctly updates@uploadthing/shared
to 6.7.2.
269-274
: 6.5.1 – Dependency Update Entry
The dependency update to@uploadthing/[email protected]
is well documented.
279-282
: 6.5.0 – Minor Changes: Effect Rewrite
The effect rewrite introduced in [#457] is noted with proper credit. The description provides sufficient context.
285-292
: 6.5.0 – Patch Changes: Dependency Updates
This patch change updates@uploadthing/dropzone
to 0.4.0 and@uploadthing/shared
to 6.7.0. The commit references and details are clear.
297-300
: 6.4.1 – Patch Changes: Dropzone Dependency Update
The update to@uploadthing/[email protected]
is straightforward and documented accurately.
314-318
: 6.4.0 – Patch Changes: Dependency Updates
The patch changes update dependencies for@uploadthing/dropzone
(to 0.3.0) and@uploadthing/shared
(to 6.6.0), which is consistent with other entries.packages/vue/CHANGELOG.md (27)
3-11
: Version 7.2.0 – Minor Changes Entry
The new version header and “Minor Changes” section are clearly added. The entry credits PR [#1099] with a commit reference and explains the new custom fetch override feature succinctly. Please double‐check that the language accurately reflects the intended feature for consistency with other package changelogs.
12-17
: Version 7.2.0 – Patch Changes Entry
The patch changes section correctly lists the updated dependency (@uploadthing/[email protected]
) for this release. The commit reference is provided, and the formatting is consistent with the changelog’s style.
22-29
: Version 7.1.5 – Patch Changes Update
The patch update entry for version 7.1.5 has two parts: the note on PR [#1108] describing relaxed peer dependency requirements and the corresponding dependency update (@uploadthing/[email protected]
). Both parts are clear and properly formatted.
35-42
: Version 7.1.4 – Patch Changes Update
This update includes the entry for PR [#1103] (tidying up peer dependency ranges) and the updated dependency (@uploadthing/[email protected]
). The information is clearly segmented and follows the established format.
48-50
: Version 7.1.3 – Dependency Update
The dependency update for version 7.1.3 (updating to@uploadthing/[email protected]
) is simple and consistent with previous entries.
56-59
: Version 7.1.2 – Dependency Update
The patch changes for version 7.1.2 clearly list the updated dependency (@uploadthing/[email protected]
) along with the corresponding commit references.
65-68
: Version 7.1.1 – Refactor Note and Dependency Update
The entry for PR [#1044] describes a refactor to simplify types for the built file route. This change is well documented and the contributor is correctly credited. (The dependency update note on the following line appears standard.)
77-85
: Version 7.1.0 – Minor Changes Entry
The new feature for specifying the route endpoint (supporting “Go to Definition”) is clearly described over lines 77–85, with details explaining the new function-accepting mechanism. It would be good to verify that the examples elsewhere (if any) are updated accordingly.
111-113
: Version 7.1.0 – Patch Changes (Dependency Bump Part 1)
The entry referencing commit [01b1363
] correctly documents the bump of internal effect dependencies, with thanks to the contributor.
115-118
: Version 7.1.0 – Patch Changes (Dependency Bump Part 2)
The subsequent “Updated dependencies” entry is clear and consolidates multiple commit references for updating@uploadthing/shared
to 7.1.0.
125-129
: Version 7.0.3 – PR [#977] Entry
This entry details the removal of the internal dropzone package to prevent peer dependency conflicts. The description is concise and well credited.
131-135
: Version 7.0.3 – PR [#980] Entry
The fix for preventing the file picker from opening twice is clearly noted, with complete attribution to the contributor.
136-139
: Version 7.0.3 – Dependency Update
The “Updated dependencies” entry, which sets@uploadthing/shared
to 7.0.3, is straightforward and consistently formatted.
146-148
: Version 7.0.2 – Dependency Update
The patch change for version 7.0.2 detailing the update to@uploadthing/[email protected]
is clear and formatted correctly.
161-166
: Version 7.0.0 – Bulk Dependency Update
The dependency update section for version 7.0.0 shows multiple commit references updating bothuploadthing
and@uploadthing/shared
to version 7.0.0. The consolidation of repeated commit links is acceptable, though you may want to double-check that the repetition is intentional.
182-185
: Version 6.7.0 – Patch Changes Dependency Update
The dependency update to@uploadthing/[email protected]
is succinct and fits the changelog’s style.
192-194
: Version 6.6.3 – Dependency Update
The updated dependency entry for@uploadthing/[email protected]
is clear and consistent with previous entries.
200-202
: Version 6.6.2 – Dependency Update
The entry appropriately reflects the upgrade to@uploadthing/[email protected]
.
208-211
: Version 6.6.1 – PR [#860] Fix Entry
The fix entry for PR [#860] regarding the ordering ofonUploadProgress
events is well described and credited.
213-215
: Version 6.6.1 – Dependency Update
The dependency update to@uploadthing/[email protected]
is clearly presented.
221-225
: Version 6.6.0 – Minor Changes Entry
The addition of theonDrop
prop for theUploadDropzone
component is clearly noted, with gratitude to the contributor.
228-232
: Version 6.6.0 – Patch Changes Dependency Update
The “Updated dependencies” section correctly upgrades to@uploadthing/[email protected]
along with the associated commit references.
238-240
: Version 6.5.4 – Dependency Update
The dependency updates reflecting@uploadthing/[email protected]
and@uploadthing/[email protected]
are neatly documented.
248-250
: Version 6.5.3 – Dependency Update
The upgrade to@uploadthing/[email protected]
is clearly captured with the relevant commit reference.
256-259
: Version 6.5.2 – Dependency Update
This patch change updates the dependency to@uploadthing/[email protected]
in a clear and consistent manner.
265-268
: Version 6.5.1 – Dependency Update
The changelog now reflects the dependency bump to@uploadthing/[email protected]
. The commit references and formatting match the project’s standards.
282-286
: Version 6.5.0 – Patch Changes Dependency Update
The final dependency update listing for@uploadthing/[email protected]
and@uploadthing/[email protected]
is well presented with multiple commit references.packages/solid/CHANGELOG.md (73)
3-11
: New Release Entry for Version 7.2.0
The new version header and minor changes for 7.2.0 (the custom fetch override via PR #1099) are clearly documented with appropriate links and commit references. The formatting is consistent with previous entries.
12-17
: Patch Changes for Version 7.2.0 – Dependency Update
The patch changes updating the dependency to@uploadthing/[email protected]
are well presented and correctly formatted. Please verify that this version update is consistent with related packages.
22-26
: Chore Update for Version 7.1.5 – Relaxed Peer Dependency Requirements
The entry for PR #1108 explains the relaxed peer dependency requirements clearly. It is helpful that the commit hash and contributor attribution are included.
27-29
: Dependency Update for Version 7.1.5
Updating@uploadthing/shared
to version 7.1.5 is clearly indicated. This entry follows the established format and signals dependency consistency.
35-37
: Dependency Update for Version 7.1.4
The updated dependency to@uploadthing/[email protected]
is correctly noted. No further action is required here.
43-45
: Dependency Update for Version 7.1.3
The changelog clearly documents the update to@uploadthing/[email protected]
. The concise entry is clear and consistent.
51-54
: Dependency Update for Version 7.1.2
The combined dependency update (with multiple commit references) to@uploadthing/[email protected]
is well captured and follows previous patterns.
60-66
: Chore and Dependency Update for Version 7.1.1
The refactor (simplifying types for the built file route) is clearly documented, and the dependency update to@uploadthing/[email protected]
is shown. This entry meets the documentation standards.
72-77
: New Feature for Version 7.1.0 – Route Endpoint Specification
The new feature that adds support for specifying a route endpoint (which enhances “Go to Definition”) is a useful addition. Please ensure that related documentation and tests are updated accordingly.
106-114
: Patch Dependency Update for Version 7.1.0
The bump in internal effect dependencies together with the dependency update to@uploadthing/[email protected]
is clearly described. Double-check that all examples and downstream code reference the new version correctly.
120-135
: Changelog for Version 7.0.3 – Multiple Fixes and Dependency Updates
The removal of the internal dropzone package (to prevent peer dependency conflicts) and the fix for the file picker issue are well documented. The subsequent dependency update to@uploadthing/[email protected]
is clearly grouped.
141-143
: Dependency Update for Version 7.0.2
The update to@uploadthing/[email protected]
is succinct and consistent with other entries.
149-150
: Dependency Update for Version 7.0.1
The changelog shows the dependency update to@uploadthing/[email protected]
. The notation using brackets appears acceptable; consider confirming that formatting is consistent with similar entries.
156-161
: Major Dependency Update for Version 7.0.0
The extensive update—with repeated commit links—and the bump for bothuploadthing
and@uploadthing/shared
to version 7.0.0 signals a major revision. Everything is documented in a detailed and structured manner.
169-173
: New Feature Addition in Version 6.6.0 – onChange Prop
Adding theonChange
prop to<UploadButton/>
and<UploadDropzone />
(while deprecatingonDrop
) is a valuable enhancement. Note the static analysis hint regarding punctuation; please verify that the commit message text meets your style guidelines.🧰 Tools
🪛 LanguageTool
[uncategorized] ~169-~169: A punctuation mark might be missing here.
Context: ...hub.com//pull/886) [079b434
](https://github.com/pingdotgg/...(AI_EN_LECTOR_MISSING_PUNCTUATION)
177-190
: Deprecation and Dependency Update for Version 6.6.0
The renaming ofuseUploadThing
tocreateUploadThing
(with deprecation noted) is communicated clearly, along with the dependency update to@uploadthing/[email protected]
.
196-198
: Dependency Update for Version 6.5.3
The update to@uploadthing/[email protected]
is properly noted.
204-206
: Dependency Update for Version 6.5.2
The changelog clearly shows the update to@uploadthing/[email protected]
, keeping consistency across versions.
212-216
: Bug Fix in Version 6.5.1 – onUploadProgress Events
The fix addressing out-of-orderonUploadProgress
events is important, and the contributor attribution is clear.
217-219
: Dependency Update for Version 6.5.1
The dependency has been updated to@uploadthing/[email protected]
. This is concise and correctly follows your established format.
225-228
: New Feature in Version 6.5.0 – onDrop Prop for UploadDropzone
Adding theonDrop
prop to theUploadDropzone
component enhances usability. The description is clear and well formatted.
232-236
: Dependency Update for Version 6.5.0
The update to@uploadthing/[email protected]
in this patch changes section is properly documented.
242-246
: Dependency Update for Version 6.4.4
The update featuring commit links for both@uploadthing/[email protected]
and an update for@uploadthing/[email protected]
is clearly presented.
252-254
: Dependency Update for Version 6.4.3
The single-line update to@uploadthing/[email protected]
is simple and clear.🧰 Tools
🪛 LanguageTool
[uncategorized] ~253-~253: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[a1481a2
](https://github.com/pingdotgg/...(AI_EN_LECTOR_MISSING_PUNCTUATION)
260-263
: Dependency Update for Version 6.4.2
The update to@uploadthing/[email protected]
is correctly noted with multiple commit references.
279-282
: Feature Addition in Version 6.4.0
The entry from PR #457 (effect rewrite) is well documented. In light of the static analysis hint, double-check the punctuation in the commit message text.
285-290
: Dependency Updates in Version 6.4.0 – Patch Changes
The dependency updates for@uploadthing/[email protected]
and@uploadthing/[email protected]
are presented in a clear and consistent list.
297-299
: Dependency Update for Version 6.3.4
The update to@uploadthing/[email protected]
is concise and in line with your changelog practices.
305-308
: Dependency Update for Version 6.3.3
The update that bumps@uploadthing/dropzone
to 0.3.0 and@uploadthing/shared
to 6.6.0 is clearly documented.
314-317
: Bug Fix in Version 6.3.2 – Dropzone Submission
The fix for ensuring the dropzone submits correctly when inside a form is clearly captured, and the subsequent dependency update to@uploadthing/[email protected]
is noted.
327-329
: Dependency Update for Version 6.3.1
The update to@uploadthing/[email protected]
is straightforward and consistent with prior entries.
335-342
: Feature Addition in Version 6.3.0 – Client Headers Option
The new feature to add client headers is well documented. The introductory description sets the context nicely before the code example.
344-365
: Code Example for Version 6.3.0 – Usage Demonstration
The detailed examples showing how to useuseUploadThing
and<UploadButton>
are very helpful. The formatting and inline code provide clear guidance for users.
370-378
: Fix and Dependency Update in Version 6.2.1
The fix for the issue with theworkspace:
protocol and the subsequent dependency updates for@uploadthing/[email protected]
and@uploadthing/[email protected]
are well laid out.
383-387
: Feature Addition in Version 6.2.0 – skipPolling Option
Adding theskipPolling
option in response to PR #654 is a useful flexibility improvement for users.
390-408
: Multiple API and Refactoring Updates in Version 6.2.0 Patch Changes
This series of updates—including API consistency improvements, internal refactoring, and a fix for dropzone endpoint handling—are comprehensively documented. The dependency update to@uploadthing/[email protected]
is also included.
414-416
: Dependency Update for Version 6.1.5 (Dropzone)
The update to@uploadthing/[email protected]
is succinctly noted.
422-431
: Chore and Dependency Update in Version 6.1.4
Removing the unused classNames utility and updating the dependency to@uploadthing/[email protected]
is clearly explained and improves maintainability.
436-440
: Bug Fix in Version 6.1.3
The removal of the required package argument from the generated function is a necessary fix and is clearly stated.
445-453
: Analytics Reporting and Dependency Update in Version 6.1.2
The analytics reporting improvement and corresponding dependency update to@uploadthing/[email protected]
are well documented.
457-472
: Minification and Dependency Updates in Version 6.1.1
The minification of the usedropzone hook (which allows SolidJS projects to drop an extra dependency) and the consolidated dependency updates are clearly presented.🧰 Tools
🪛 LanguageTool
[misspelling] ~464-~464: This word is normally spelled with a hyphen.
Context: ...as our own minimal hook has been made framework agnostic and is now bundled with the main pack...(EN_COMPOUNDS_FRAMEWORK_AGNOSTIC)
478-482
: Feature Addition in Version 6.1.0 – Async onBeforeUploadBegin
Adding the ability to pass an asynconBeforeUploadBegin
callback is a useful enhancement.
485-488
: Dependency Update for Version 6.1.0 Patch
The update to@uploadthing/[email protected]
is clear and maintains consistency.
491-497
: Major Feature Changes in Version 6.0.0 – Callback Sequencing
Supporting the return of data from the server-sideonUploadComplete
callback—with clear sequencing before the client-side callback—is a significant and well-documented enhancement.
498-505
: Additional Feature in Version 6.0.0 – Arbitrary Callback URLs
The new support for arbitrary callback URLs is explained clearly, with a good code example provided. This will benefit users with nonstandard endpoints.
515-520
: Minor Feature Additions in Version 6.0.0 – Preprocessing and Error Typing
The additional features (such as the newonBeforeUploadBegin
callback for preprocessing file details and the typed handling of upload errors) are well documented.
527-537
: Comprehensive Dependency Updates in Version 6.0.0 Patch Changes
The multipronged dependency updates, consolidating the major version bump for bothuploadthing
and@uploadthing/shared
, are detailed and maintain consistency across related packages.🧰 Tools
🪛 LanguageTool
[style] ~528-~528: In American English, abbreviations like “etc.” require a period.
Context: ...essing of files (ie changing file names etc) - [#451](https://github.com/pingdotgg...(ETC_PERIOD)
552-556
: Bug Fix in Version 5.4.1 – JSON Error Handling
Improving error handling for invalid JSON parsing is a critical fix. The commit message and links are clear.
557-560
: Dependency Update for Version 5.4.1
The update to@uploadthing/[email protected]
is correctly noted.
565-569
: Feature Addition in Version 5.4.0 – Auto Upload Mode
Introducing the auto upload mode for the dropzone component enhances usability. The contributor attribution adds context.🧰 Tools
🪛 LanguageTool
[uncategorized] ~567-~567: It appears that a hyphen is missing (if ‘auto’ is not used in the context of ‘cars’).
Context: ...](https://github.com/Mr0Bread)! - feat: auto upload mode for dropzone component ### Patc...(AUTO_HYPHEN)
572-576
: Bug Fix in Version 5.4.0 Patch Changes – Tailwind Config
Removing the unused prefix in the Tailwind configuration to ensure correct CSS output is a beneficial clean-up.
581-585
: Bug Fix in Version 5.3.1 – Progress Bar Styles
The fix for missing progress bar styles in the compiled stylesheet is clearly documented, along with the dependency update to@uploadthing/[email protected]
.🧰 Tools
🪛 LanguageTool
[uncategorized] ~584-~584: This verb does not appear to agree with the subject. Consider using a different form.
Context: ...! - fix bug where progress bar styles was not included in the compiled stylesheet...(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
594-598
: Feature Addition in Version 5.3.0 – Theming Support
Supporting theming components is a valuable enhancement. The entry is succinct and informative.
603-607
: Bug Fix in Version 5.2.1 – generateComponents Return Value
The fix ensuring thatgenerateComponents
returns the correct components is clearly outlined.
612-616
: Feature Addition in Version 5.2.0 – onUploadBegin Prop
The inclusion of theonUploadBegin
prop (for both React and Solid) is a useful enhancement.
619-622
: Dependency Update for Version 5.2.0 Patch Changes
Updating to@uploadthing/[email protected]
is straightforward and maintains version consistency.
627-631
: Bug Fix in Version 5.1.2 – Coherent File Info
The fix for ensuring coherent file information across methods is well documented, along with clear examples of the revised object shape.
644-654
: Dependency Update for Version 5.1.2
The dependency update to@uploadthing/[email protected]
is properly detailed.
657-661
: Chore Update in Version 5.1.1 – Dependency Bump
The update to the@uploadthing/shared
dependency (as part of overall maintenance) is clear and properly attributed.
662-666
: Bug Fix in Version 5.1.1 – getUploadthingUrl() Adjustment
Swapping the order of cases in thegetUploadthingUrl()
function is a minor but necessary correction.
667-674
: Dependency Update for Version 5.1.1
The consolidated dependency updates (including those for@uploadthing/shared
) are coherent and maintain consistency with the rest of the changelog.
677-680
: Feature Addition in Version 5.1.0 – Upload Progress and Solid Fixes
The addition of upload progress and the fix to restrict server-only logging in Solid are beneficial.
686-692
: Bug Fix in Version 5.1.0 Patch Changes – Preflight and Reset Styles
The adjustments to disable preflight requests and add inline reset styles improve robustness.
693-696
: Dependency Update for Version 5.1.0
The update to@uploadthing/[email protected]
is clearly documented.
703-707
: Major Feature Addition in Version 5.0.0 – Client Side Metadata
Allowing client side metadata with file uploads represents an important new feature. The summary is clear and instructive.🧰 Tools
🪛 LanguageTool
[uncategorized] ~706-~706: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...b.com/juliusmarminge)! - feat!: allow client side metadata to be passed along with the fi...(EN_COMPOUND_ADJECTIVE_INTERNAL)
708-757
: Comprehensive Documentation for Version 5.0.0
The detailed summary and code examples that follow provide excellent guidance for users on how to implement the new features. Ensure that all code examples are kept in sync with the new APIs.
815-822
: Minor Feature Improvement in Version 5.0.0 – generateComponents Simplification
Allowing the genericFileRouter
to be passed once ingenerateComponents
simplifies usage. This is a valuable quality-of-life improvement.
827-832
: Dependency Update in Version 5.0.0 Patch Changes
The consolidated dependency updates are consistent with the overall major release and ensure version alignment.
833-842
: Internal Refactoring in Version 4.1.3
The refactoring to use a new shared package and the corresponding dependency updates are well documented. This entry contributes to long-term maintainability.
848-852
: Dependency Update in Version 3.0.6
The dependency update to[email protected]
is succinctly noted. Verify that the version alignment is correct across the ecosystem.🧰 Tools
🪛 LanguageTool
[uncategorized] ~849-~849: A punctuation mark might be missing here.
Context: ...4d9782b194feea74fd6abc2312bd105ae0f5d), [c58b19e
](https://github.com/pingdotgg/...(AI_EN_LECTOR_MISSING_PUNCTUATION)
857-867
: Bug Fix in Version 3.0.5 – Blob Upload Support
Improving blob upload support to include non-image/video/audio file types is an important fix. The dependency update to[email protected]
is appropriately mentioned.
872-877
: Version Sync in Version 3.0.4
The synchronization of versions, as noted by [@t3dotgg], is straightforward and helps ensure consistency across releases.
882-890
: Feature Addition in Version 1.0.1 – SolidJS Adapter
The inclusion of the SolidJS adapter and the associated dependency update to[email protected]
complete the changelog nicely for this early version.🧰 Tools
🪛 LanguageTool
[style] ~884-~884: Using many exclamation marks might seem excessive (in this case: 48 exclamation marks for a text that’s 27490 characters long)
Context: ...nks @OrJDev! - feat: SolidJS adapter - Updated depe...(EN_EXCESSIVE_EXCLAMATION)
efc186f
to
6fd0b5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
packages/react/CHANGELOG.md (1)
264-264
: Fix the bare URL in the changelog.The URL should be wrapped in angle brackets to comply with markdown best practices.
Apply this diff to fix the URL formatting:
-https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61 +<https://github.com/pingdotgg/uploadthing/blob/main/examples/with-novel/uploadthing/novel-plugin.ts#L50-L61>🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
264-264: Bare URL used
null(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md (1)
310-310
: Format the bare URL as a markdown link.Convert the bare URL to a proper markdown link for better readability and to follow markdown best practices.
- https://docs.uploadthing.com/getting-started/svelte + [https://docs.uploadthing.com/getting-started/svelte](https://docs.uploadthing.com/getting-started/svelte)🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
310-310: Bare URL used
null(MD034, no-bare-urls)
packages/shared/CHANGELOG.md (2)
214-214
: Consider using markdown link syntax for bare URLs.For better readability and consistency, consider formatting the bare URLs using markdown link syntax:
-See upstream issue: https://github.com/Effect-TS/effect/issues/3057 +See upstream issue: [Effect-TS/effect#3057](https://github.com/Effect-TS/effect/issues/3057) -https://docs.uploadthing.com/getting-started/svelte +[Getting Started with Svelte](https://docs.uploadthing.com/getting-started/svelte)Also applies to: 343-343
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
214-214: Bare URL used
null(MD034, no-bare-urls)
265-265
: Fix grammar: Use "fewer" with countable nouns.For better grammar, use "fewer" instead of "less" when referring to countable items like kilobytes of JavaScript:
-chore: remove `@effect/schema` from client bundle resulting in up to 15kB less JS shipped to client (#794) +chore: remove `@effect/schema` from client bundle resulting in up to 15kB fewer JS shipped to client (#794)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (45)
.changeset/curvy-rings-own.md
(0 hunks).changeset/fair-rockets-beg.md
(0 hunks).changeset/good-tables-jump.md
(0 hunks).changeset/nice-penguins-grow.md
(0 hunks).changeset/purple-shrimps-chew.md
(0 hunks)examples/backend-adapters/client-react/package.json
(1 hunks)examples/backend-adapters/client-vanilla/package.json
(1 hunks)examples/backend-adapters/client-vue/package.json
(1 hunks)examples/backend-adapters/package.json
(1 hunks)examples/backend-adapters/server/package.json
(1 hunks)examples/minimal-appdir/package.json
(1 hunks)examples/minimal-astro-react/package.json
(1 hunks)examples/minimal-expo/package.json
(2 hunks)examples/minimal-nuxt/package.json
(1 hunks)examples/minimal-pagedir/package.json
(1 hunks)examples/minimal-solidstart/package.json
(1 hunks)examples/minimal-sveltekit/package.json
(1 hunks)examples/minimal-tanstack-start/package.json
(1 hunks)examples/profile-picture/package.json
(2 hunks)examples/with-clerk-appdir/package.json
(1 hunks)examples/with-clerk-pagesdir/package.json
(1 hunks)examples/with-clerk-react-router/package.json
(1 hunks)examples/with-clerk-remix/package.json
(1 hunks)examples/with-drizzle-appdir/package.json
(1 hunks)examples/with-drizzle-pagesdir/package.json
(1 hunks)examples/with-novel/package.json
(2 hunks)examples/with-react-image-crop/package.json
(1 hunks)examples/with-serveractions/package.json
(1 hunks)examples/with-tailwindcss/package.json
(1 hunks)packages/expo/CHANGELOG.md
(4 hunks)packages/expo/package.json
(1 hunks)packages/nuxt/CHANGELOG.md
(7 hunks)packages/nuxt/package.json
(1 hunks)packages/react/CHANGELOG.md
(5 hunks)packages/react/package.json
(1 hunks)packages/shared/CHANGELOG.md
(3 hunks)packages/shared/package.json
(1 hunks)packages/solid/CHANGELOG.md
(5 hunks)packages/solid/package.json
(1 hunks)packages/svelte/CHANGELOG.md
(4 hunks)packages/svelte/package.json
(1 hunks)packages/uploadthing/CHANGELOG.md
(10 hunks)packages/uploadthing/package.json
(1 hunks)packages/vue/CHANGELOG.md
(4 hunks)packages/vue/package.json
(1 hunks)
💤 Files with no reviewable changes (5)
- .changeset/curvy-rings-own.md
- .changeset/good-tables-jump.md
- .changeset/nice-penguins-grow.md
- .changeset/fair-rockets-beg.md
- .changeset/purple-shrimps-chew.md
🚧 Files skipped from review as they are similar to previous changes (34)
- packages/nuxt/package.json
- packages/shared/package.json
- examples/backend-adapters/server/package.json
- examples/backend-adapters/client-vanilla/package.json
- packages/solid/package.json
- examples/backend-adapters/client-react/package.json
- examples/minimal-appdir/package.json
- packages/svelte/package.json
- examples/minimal-expo/package.json
- examples/with-clerk-appdir/package.json
- examples/with-serveractions/package.json
- examples/backend-adapters/client-vue/package.json
- examples/minimal-nuxt/package.json
- examples/with-drizzle-pagesdir/package.json
- examples/with-clerk-pagesdir/package.json
- examples/with-novel/package.json
- examples/minimal-solidstart/package.json
- examples/with-tailwindcss/package.json
- examples/with-clerk-react-router/package.json
- examples/with-react-image-crop/package.json
- examples/minimal-pagedir/package.json
- examples/with-clerk-remix/package.json
- packages/expo/package.json
- examples/minimal-sveltekit/package.json
- examples/backend-adapters/package.json
- packages/expo/CHANGELOG.md
- examples/minimal-astro-react/package.json
- packages/uploadthing/package.json
- examples/minimal-tanstack-start/package.json
- examples/with-drizzle-appdir/package.json
- packages/vue/package.json
- examples/profile-picture/package.json
- packages/react/package.json
- packages/solid/CHANGELOG.md
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
packages/uploadthing/CHANGELOG.md
357-357: Bare URL used
null
(MD034, no-bare-urls)
531-531: Bare URL used
null
(MD034, no-bare-urls)
609-609: Bare URL used
null
(MD034, no-bare-urls)
756-756: Bare URL used
null
(MD034, no-bare-urls)
packages/react/CHANGELOG.md
264-264: Bare URL used
null
(MD034, no-bare-urls)
packages/shared/CHANGELOG.md
214-214: Bare URL used
null
(MD034, no-bare-urls)
343-343: Bare URL used
null
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
310-310: Bare URL used
null
(MD034, no-bare-urls)
🪛 LanguageTool
packages/nuxt/CHANGELOG.md
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/shared/CHANGELOG.md
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...
(MAKE_CHANGES)
[grammar] ~265-~265: Did you mean “fewer”? The noun “JS” is countable.
Context: ...m client bundle resulting in up to 15kB less JS shipped to client (#794) - [#806]...
(FEWER_LESS)
packages/vue/CHANGELOG.md
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🔇 Additional comments (16)
packages/nuxt/CHANGELOG.md (2)
3-9
: LGTM! The new version entry follows the changelog format.The new version 7.1.6 correctly documents the dependency update to
@uploadthing/[email protected]
with proper commit reference.
1-242
: LGTM! The changelog maintains consistent formatting.The changelog follows the conventional format with clear sections for versions, changes, and dependencies. Each entry includes proper links to commits and pull requests.
🧰 Tools
🪛 LanguageTool
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...(EN_EXCESSIVE_EXCLAMATION)
packages/react/CHANGELOG.md (1)
3-16
: LGTM! The changelog entry for version 7.2.0 is well structured.The changelog entry follows the conventional format with clear sections for Minor and Patch changes, proper PR references, and contributor acknowledgments.
packages/svelte/CHANGELOG.md (1)
3-16
: LGTM! Well-documented version bump.The changelog entry for version 7.2.0 is clear and properly formatted, with appropriate links to the PR, commit, and contributor.
packages/vue/CHANGELOG.md (4)
3-4
: LGTM!The version entry follows the Keep a Changelog format and aligns with the PR objectives.
5-10
: LGTM!The minor changes section is well-documented, properly credits the contributor, and accurately describes the custom fetch override feature mentioned in the PR objectives.
12-16
: LGTM!The patch changes section properly documents the dependency update with the correct version and commit reference.
18-289
: LGTM!The historical entries are properly maintained and follow a consistent format throughout the changelog.
🧰 Tools
🪛 LanguageTool
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...(EN_EXCESSIVE_EXCLAMATION)
packages/shared/CHANGELOG.md (1)
3-10
: LGTM! The changelog entry is well-formatted and informative.The changelog entry for version 7.1.6 follows the conventional format and clearly describes the patch change for allowing deeply nested objects in JsonArray.
packages/uploadthing/CHANGELOG.md (7)
7-20
: New Tailwind v4 CSS plugin feature.The addition of a Tailwind v4 CSS plugin allows direct import into CSS files. The implementation includes clear usage instructions with code examples.
21-24
: Custom fetch override feature added.The feature allows customization of fetch behavior, enhancing flexibility in handling requests.
26-30
: NewUTApi.generateSignedURL
method.Added capability to generate signed URLs for private files without requiring an API request, improving performance and reducing unnecessary network calls.
34-40
: Improved error handling in utapi.Fixed an issue where errors were being silently ignored, enhancing error visibility and debugging capabilities.
41-45
: Support for deeply nested objects in JsonArray.Enhanced JsonArray functionality to handle complex data structures with deeply nested objects.
46-50
: URL field changes require attention.The introduction of
ufsUrl
field and deprecation ofurl
andappUrl
fields requires migration planning.This is a duplicate of a previous review comment that highlighted the need for migration planning. The original comment correctly identified the impact and provided guidance for transitioning to the new field structure.
52-54
: Dependency update.Updated
@uploadthing/shared
to version 7.1.6 to maintain compatibility.
e9e63bd
to
142c076
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (46)
.changeset/curvy-rings-own.md
(0 hunks).changeset/fair-rockets-beg.md
(0 hunks).changeset/good-tables-jump.md
(0 hunks).changeset/nice-penguins-grow.md
(0 hunks).changeset/poor-needles-drive.md
(0 hunks).changeset/purple-shrimps-chew.md
(0 hunks)examples/backend-adapters/client-react/package.json
(1 hunks)examples/backend-adapters/client-vanilla/package.json
(1 hunks)examples/backend-adapters/client-vue/package.json
(1 hunks)examples/backend-adapters/package.json
(1 hunks)examples/backend-adapters/server/package.json
(1 hunks)examples/minimal-appdir/package.json
(1 hunks)examples/minimal-astro-react/package.json
(1 hunks)examples/minimal-expo/package.json
(2 hunks)examples/minimal-nuxt/package.json
(1 hunks)examples/minimal-pagedir/package.json
(1 hunks)examples/minimal-solidstart/package.json
(1 hunks)examples/minimal-sveltekit/package.json
(1 hunks)examples/minimal-tanstack-start/package.json
(1 hunks)examples/profile-picture/package.json
(2 hunks)examples/with-clerk-appdir/package.json
(1 hunks)examples/with-clerk-pagesdir/package.json
(1 hunks)examples/with-clerk-react-router/package.json
(1 hunks)examples/with-clerk-remix/package.json
(1 hunks)examples/with-drizzle-appdir/package.json
(1 hunks)examples/with-drizzle-pagesdir/package.json
(1 hunks)examples/with-novel/package.json
(2 hunks)examples/with-react-image-crop/package.json
(1 hunks)examples/with-serveractions/package.json
(1 hunks)examples/with-tailwindcss/package.json
(1 hunks)packages/expo/CHANGELOG.md
(4 hunks)packages/expo/package.json
(1 hunks)packages/nuxt/CHANGELOG.md
(7 hunks)packages/nuxt/package.json
(1 hunks)packages/react/CHANGELOG.md
(5 hunks)packages/react/package.json
(1 hunks)packages/shared/CHANGELOG.md
(3 hunks)packages/shared/package.json
(1 hunks)packages/solid/CHANGELOG.md
(5 hunks)packages/solid/package.json
(1 hunks)packages/svelte/CHANGELOG.md
(4 hunks)packages/svelte/package.json
(1 hunks)packages/uploadthing/CHANGELOG.md
(10 hunks)packages/uploadthing/package.json
(1 hunks)packages/vue/CHANGELOG.md
(4 hunks)packages/vue/package.json
(1 hunks)
💤 Files with no reviewable changes (6)
- .changeset/curvy-rings-own.md
- .changeset/fair-rockets-beg.md
- .changeset/nice-penguins-grow.md
- .changeset/poor-needles-drive.md
- .changeset/purple-shrimps-chew.md
- .changeset/good-tables-jump.md
🚧 Files skipped from review as they are similar to previous changes (33)
- examples/with-serveractions/package.json
- packages/nuxt/package.json
- packages/shared/package.json
- packages/vue/package.json
- examples/minimal-solidstart/package.json
- examples/with-clerk-appdir/package.json
- examples/minimal-nuxt/package.json
- examples/with-drizzle-appdir/package.json
- examples/minimal-expo/package.json
- examples/backend-adapters/client-react/package.json
- examples/with-react-image-crop/package.json
- examples/with-tailwindcss/package.json
- examples/with-clerk-remix/package.json
- examples/minimal-astro-react/package.json
- examples/minimal-sveltekit/package.json
- examples/backend-adapters/client-vue/package.json
- examples/with-clerk-pagesdir/package.json
- packages/uploadthing/package.json
- examples/minimal-tanstack-start/package.json
- examples/minimal-pagedir/package.json
- examples/with-novel/package.json
- examples/backend-adapters/client-vanilla/package.json
- examples/with-clerk-react-router/package.json
- packages/react/package.json
- packages/solid/package.json
- examples/minimal-appdir/package.json
- examples/backend-adapters/package.json
- packages/expo/package.json
- examples/with-drizzle-pagesdir/package.json
- packages/solid/CHANGELOG.md
- examples/backend-adapters/server/package.json
- examples/profile-picture/package.json
- packages/svelte/package.json
🧰 Additional context used
🪛 LanguageTool
packages/expo/CHANGELOG.md
[uncategorized] ~132-~132: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
packages/nuxt/CHANGELOG.md
[uncategorized] ~111-~111: You might be missing the article “the” here.
Context: ...! - fix: options was not forwarded to uploadthing handler correctly - Updated dependenci...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~159-~159: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[079b434
](https://github.com/pingdotgg/...
(AI_EN_LECTOR_MISSING_PUNCTUATION)
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
packages/shared/CHANGELOG.md
[uncategorized] ~132-~132: Possible missing comma found.
Context: ...https://github.com/juraj98)! - fix vite monorepos sometimes complaining about `$Refresh...
(AI_HYDRA_LEO_MISSING_COMMA)
[style] ~181-~181: Consider shortening or rephrasing this to strengthen your wording.
Context: ...This change improves our flexibility to make changes to the API without needing to do a major...
(MAKE_CHANGES)
[grammar] ~265-~265: Did you mean “fewer”? The noun “JS” is countable.
Context: ...m client bundle resulting in up to 15kB less JS shipped to client (#794) - [#806]...
(FEWER_LESS)
packages/vue/CHANGELOG.md
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...
(EN_EXCESSIVE_EXCLAMATION)
🪛 markdownlint-cli2 (0.17.2)
packages/react/CHANGELOG.md
264-264: Bare URL used
null
(MD034, no-bare-urls)
packages/shared/CHANGELOG.md
214-214: Bare URL used
null
(MD034, no-bare-urls)
343-343: Bare URL used
null
(MD034, no-bare-urls)
packages/svelte/CHANGELOG.md
310-310: Bare URL used
null
(MD034, no-bare-urls)
packages/uploadthing/CHANGELOG.md
357-357: Bare URL used
null
(MD034, no-bare-urls)
531-531: Bare URL used
null
(MD034, no-bare-urls)
609-609: Bare URL used
null
(MD034, no-bare-urls)
756-756: Bare URL used
null
(MD034, no-bare-urls)
🔇 Additional comments (10)
packages/vue/CHANGELOG.md (2)
3-16
: LGTM! The changelog entry is well-structured and consistent.The new version entry properly documents:
- The minor version bump to 7.2.0
- The custom fetch override feature with PR reference (feat: add custom fetch override #1099)
- Credit to the contributor (@juliusmarminge)
- Updated dependency on @uploadthing/[email protected]
1-289
: LGTM! The changelog maintains good structure and consistency.The changelog follows the Keep a Changelog format and maintains a clear history of changes. The version increments and feature additions are consistent with the coordinated release across the UploadThing ecosystem.
🧰 Tools
🪛 LanguageTool
[style] ~278-~278: Using many exclamation marks might seem excessive (in this case: 13 exclamation marks for a text that’s 9408 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...(EN_EXCESSIVE_EXCLAMATION)
packages/nuxt/CHANGELOG.md (3)
3-9
: LGTM! Version entry follows semantic versioning.The new version entry correctly documents the dependency update to
@uploadthing/[email protected]
with proper commit reference.
15-104
: Well-documented changes with clear examples.The changelog entries effectively document recent changes with:
- Clear PR references and commit hashes
- Detailed explanations of changes
- Helpful examples for new features
1-243
: Excellent changelog structure and consistency.The changelog follows best practices:
- Clear version headings
- Proper categorization of changes
- Consistent formatting throughout
- Well-tracked dependencies
🧰 Tools
🪛 LanguageTool
[uncategorized] ~111-~111: You might be missing the article “the” here.
Context: ...! - fix: options was not forwarded to uploadthing handler correctly - Updated dependenci...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[uncategorized] ~159-~159: A punctuation mark might be missing here.
Context: ...atch Changes - Updated dependencies [[079b434
](https://github.com/pingdotgg/...(AI_EN_LECTOR_MISSING_PUNCTUATION)
[style] ~236-~236: Using many exclamation marks might seem excessive (in this case: 9 exclamation marks for a text that’s 5957 characters long)
Context: ...rkowski)! - feat: vue and nuxt support! ### Patch Changes - Updated dependenc...(EN_EXCESSIVE_EXCLAMATION)
packages/expo/CHANGELOG.md (1)
3-18
: LGTM! Well-structured changelog entry.The changelog entry for version 7.2.0 is properly formatted and includes:
- Clear reference to PR feat: add custom fetch override #1099
- Proper attribution to @juliusmarminge
- Accurate description of the minor change (custom fetch override)
- Correct documentation of dependency updates
packages/svelte/CHANGELOG.md (1)
3-16
: LGTM! Consistent changelog entry.The changelog entry for version 7.2.0 is consistent with other packages and includes:
- Clear reference to PR feat: add custom fetch override #1099
- Proper attribution to @juliusmarminge
- Accurate description of the minor change (custom fetch override)
- Correct documentation of dependency updates
packages/react/CHANGELOG.md (1)
3-16
: LGTM! Consistent changelog entry.The changelog entry for version 7.2.0 is consistent with other packages and includes:
- Clear reference to PR feat: add custom fetch override #1099
- Proper attribution to @juliusmarminge
- Accurate description of the minor change (custom fetch override)
- Correct documentation of dependency updates
packages/shared/CHANGELOG.md (1)
3-10
: LGTM! Well-documented changelog entry.The patch change for allowing deeply nested objects when using JsonArray is properly documented with the PR reference and contributor acknowledgment.
packages/uploadthing/CHANGELOG.md (1)
3-54
: LGTM! Comprehensive changelog entry.The changes are well-documented with:
- Clear feature descriptions
- PR references
- Contributor acknowledgments
- Proper versioning (minor for new features, patch for fixes)
- [#1128](https://github.com/pingdotgg/uploadthing/pull/1128) | ||
[`e7ccec9`](https://github.com/pingdotgg/uploadthing/commit/e7ccec9c7fe31618a3bae1962608650f7d91d5a9) | ||
Thanks [@juliusmarminge](https://github.com/juliusmarminge)! - chore: add new | ||
`ufsUrl` field with `https://APP_ID.ufs.sh/f/FILE_KEY` url. deprecated `url` | ||
and `appUrl` fields. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Migration required for URL field deprecation.
The deprecation of url
and appUrl
fields requires attention in several areas:
- Update code that directly accesses these fields to use
ufsUrl
instead - Review and update documentation examples
- Consider adding migration notes to your changelog
The change is well-supported with deprecation warnings and backward compatibility, allowing for a gradual transition to the new field.
Run the following script to find usages of the deprecated fields:
🏁 Script executed:
#!/bin/bash
# Description: Find usages of deprecated url and appUrl fields
# Test: Search for field usage in code. Expect: Instances where these fields are used.
echo "Searching for deprecated field usages..."
rg -A 2 'url: |appUrl: ' || echo "No direct field usage found"
echo "Searching for field access..."
rg -A 2 '\.url|\.appUrl' || echo "No field access found"
Length of output: 60624
Migration required for deprecated URL fields
Our investigation confirms that several parts of the codebase—including examples, documentation, and tests—still reference the deprecated url
and appUrl
fields instead of the new ufsUrl
. In addition to inline deprecation warnings (e.g., in packages/uploadthing/src/_internal/upload-browser.ts
and internal handler files), the grep output shows widespread usage of these fields across various modules. Please update the affected code and documentation examples to use ufsUrl
and consider adding explicit migration instructions in the changelog.
- Update example adapters and client integrations to reference
ufsUrl
- Revise documentation snippets to reflect the new field naming
- Ensure tests simulate the correct behavior using
ufsUrl
for forward compatibility
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@uploadthing/[email protected]
Minor Changes
36b0df6
Thanks @juliusmarminge! - feat: allow
custom fetch override
Patch Changes
[
f08b20e
,36b0df6
]:@uploadthing/[email protected]
Minor Changes
36b0df6
Thanks @juliusmarminge! - feat: allow
custom fetch override
Patch Changes
[
f08b20e
]:@uploadthing/[email protected]
Minor Changes
36b0df6
Thanks @juliusmarminge! - feat: allow
custom fetch override
Patch Changes
[
f08b20e
]:@uploadthing/[email protected]
Minor Changes
36b0df6
Thanks @juliusmarminge! - feat: allow
custom fetch override
Patch Changes
[
f08b20e
]:[email protected]
Minor Changes
#1138
ad75280
Thanks @juliusmarminge! - feat: add
tailwind v4 css plugin
Usage:
#1099
36b0df6
Thanks @juliusmarminge! - feat: allow
custom fetch override
#1146
6b937e5
Thanks @juliusmarminge! - feat: add
UTApi.generateSignedURL
method to generate a signed URL for a private filewithout making an API request
Patch Changes
#1125
aab8ab6
Thanks @juliusmarminge! - fix: improve
error handling in utapi
sometimes errors got silently ignored when they shouldn't have
#1127
f08b20e
Thanks @juliusmarminge! - fix: allow
deeply nested objects when using JsonArray
#1128
e7ccec9
Thanks @juliusmarminge! - chore: add new
ufsUrl
field withhttps://APP_ID.ufs.sh/f/FILE_KEY
url. deprecatedurl
and
appUrl
fields.Updated dependencies
[
f08b20e
]:@uploadthing/[email protected]
Minor Changes
36b0df6
Thanks @juliusmarminge! - feat: allow
custom fetch override
Patch Changes
[
f08b20e
]:@uploadthing/[email protected]
Patch Changes
[
36b0df6
]:@uploadthing/[email protected]
Patch Changes
f08b20e
Thanks @juliusmarminge! - fix: allow
deeply nested objects when using JsonArray
Summary by CodeRabbit
New Features
Bug Fixes
Chores