Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: @uploadthing/mime-types exports not supported in Expo #1013

Merged
merged 15 commits into from
Nov 5, 2024

Conversation

juliusmarminge
Copy link
Member

@juliusmarminge juliusmarminge commented Oct 14, 2024

Closes #999

  • flatten export paths since Expo doesn't resolve exports condition by default. This is similar to what we do for the main uploadthing package which has multiple entrypoints as well
  • modify file.slice() logic cause RN blobs suck

Summary by CodeRabbit

  • New Features

    • Enhanced compatibility for the @uploadthing/mime-types package with legacy module resolutions in Expo.
    • Improved file slicing mechanism for the upload functionality, optimizing file uploads by preventing unnecessary slicing.
  • Documentation

    • Updated documentation for the createUpload function to include a warning about the limitations of resumable uploads in React Native.
  • Chores

    • Restructured the @uploadthing/mime-types package to improve modularity and organization of MIME type exports.
    • Updated the BASE_URL in the upload client to ensure correct API endpoint usage.

Copy link

changeset-bot bot commented Oct 14, 2024

🦋 Changeset detected

Latest commit: 80eaae5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@uploadthing/mime-types Patch
uploadthing Patch
@uploadthing/shared Patch
@uploadthing/expo Patch
@uploadthing/nuxt Patch
@uploadthing/react Patch
@uploadthing/solid Patch
@uploadthing/svelte Patch
@uploadthing/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-uploadthing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 7:32pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
legacy-docs-uploadthing ⬜️ Skipped (Inspect) Nov 5, 2024 7:32pm

@juliusmarminge juliusmarminge mentioned this pull request Oct 14, 2024
2 tasks
Copy link

pkg-pr-new bot commented Oct 14, 2024

Open in Stackblitz

More templates

pnpm add https://pkg.pr.new/pingdotgg/uploadthing/@uploadthing/mime-types@1013
pnpm add https://pkg.pr.new/pingdotgg/uploadthing@1013

commit: 80eaae5

Copy link
Contributor

github-actions bot commented Oct 14, 2024

📦 Bundle size comparison

Bundle Size (gzip) Visualization
Main 27.50KB See Treemap 📊
PR (a15c753) 27.51KB See Treemap 📊
Diff ↑8.00B

Copy link
Contributor

coderabbitai bot commented Oct 14, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces several changes to enhance the functionality and compatibility of the @uploadthing/mime-types package and the upload functionality. Key modifications include a patch to support legacy module resolution in Expo, an update to the file slicing mechanism for uploads, and improvements to the documentation regarding resumable uploads in React Native. Additionally, the package.json and turbo.json files for the MIME types package have been restructured to improve modularity and output specifications.

Changes

File Path Change Summary
.changeset/grumpy-spies-hunt.md Added patch for @uploadthing/mime-types for legacy module resolution support in Expo.
.changeset/sixty-monkeys-smell.md Introduced patch for file slicing in upload functionality to optimize upload efficiency.
docs/src/app/(docs)/api-reference/client/page.mdx Updated documentation for createUpload to include a warning about resumable uploads in React Native.
packages/mime-types/package.json Updated exports field and files array to reflect new paths for MIME types, enhancing modularity.
packages/mime-types/turbo.json Modified outputs property in build task to include multiple directories for build outputs.
packages/uploadthing/src/internal/upload.browser.ts Updated uploadWithProgress to conditionally slice files based on rangeStart parameter.
examples/backend-adapters/client-vanilla/src/uploadthing.ts Changed BASE_URL from "http://localhost:3003" to "http://localhost:3000" for API requests.

Assessment against linked issues

Objective Addressed Explanation
Support legacy module resolution for Expo (#999)
Fix file upload issues related to MIME types (#999)

Possibly related PRs

Suggested reviewers

  • markflorkowski
  • t3dotgg

Poem

🐇 In the meadow where uploads play,
A patch was made to save the day.
Files now slice with care and grace,
In Expo's arms, they'll find their place.
With docs that guide through every twist,
Our uploads dance, they can't be missed! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

A new canary is available for testing. You can install this latest build in your project with:

pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add @uploadthing/[email protected]
pnpm add [email protected]
pnpm add @uploadthing/[email protected]

@github-actions github-actions bot removed the release canary Trigger a canary release to npm label Oct 14, 2024
@Sorono-Dev
Copy link

Working great and fix the issue that make Expo crash thank you

@sudhanshug16
Copy link

Would love to get this merged :)

@vercel vercel bot temporarily deployed to Preview – legacy-docs-uploadthing November 5, 2024 19:31 Inactive
@juliusmarminge juliusmarminge merged commit 7ae1ed9 into main Nov 5, 2024
18 of 19 checks passed
@juliusmarminge juliusmarminge deleted the fix-expo-v7 branch November 5, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Expo broken on v7
4 participants