Fix channel_gamma compatibility func #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across some breakage when attempting to use the dothat module with the sn3218 v2 module: specifically that the
default_gamma_tableattribute isn't available at the module level which breaksdothat.backlight(and I assumedot3k.backlightfrom the looks of it). When digging into the background I also found this error in the compatibility funcs.Note this PR doesn't fix the issue with the display-o-tron but I don't think it's actually fixable from this end (I tried using module level data-descriptors to work around it without pre-constructing an instance of
SN3218but that doesn't work as the module isn't a class). I'll post a separate PR to make display-o-tron compatible with both v2 and v1 versions of this module.