Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sn3218 compat #65

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Conversation

waveform80
Copy link
Contributor

As mentioned in pimoroni/sn3218-python#1 this PR fixes up compatibility with v2 of the sn3218 module by conditionally importing the class and instantiating it as a replacement for the module (which is otherwise imported if the class cannot be so v1 should continue to work).

May as well switch to internal unittest.mock too :)
@Gadgetoid Gadgetoid merged commit 1161818 into pimoroni:master Jan 8, 2025
@Gadgetoid
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants