2 court info #17
Merged
2 court info #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kg6zvp did you want to review this properly? It's not complex - so I can also just merge without review. |
kg6zvp
approved these changes
Sep 22, 2019
| const selected_court = court_info[props.court] | ||
| return ( | ||
| <div className="Court"> | ||
| <p><a href={selected_court.url}>{selected_court.fullname}</a> – {selected_court.phone_info}</p> |
There was a problem hiding this comment.
Could you make the phone number a tel: link? Otherwise, looks good to me. Merge whenever. 👍
There was a problem hiding this comment.
That's not completely trivial given React's escaping rules and the frequent presence of more than 1 phone number. I'll merge for now and add an issue.
|
Opened an issue about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a simple widget to display the selected court info (court name passed in via props). Data is currently defined as a variable inside the component.