-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improved design and UX in /dash page #2
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
33abb75
removed unused div element from dom tree
rudrodip 7a18e2a
Update import path for toast component
rudrodip f0a670d
Remove unused code for selecting themes
rudrodip 2075de0
Add SelectTheme component
rudrodip 0b655bd
Refactor GraphLayout component
rudrodip fae311b
Add button and select theme components to graph page
rudrodip File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
"use client"; | ||
|
||
import { | ||
Select, | ||
SelectContent, | ||
SelectItem, | ||
SelectTrigger, | ||
SelectValue, | ||
} from "@/components/ui/select"; | ||
|
||
interface SelectThemeProps { | ||
handleThemeChange: (value: string) => void; | ||
} | ||
|
||
export default function SelectTheme({ handleThemeChange }: SelectThemeProps) { | ||
return ( | ||
<Select onValueChange={(value: string) => handleThemeChange(value)}> | ||
<SelectTrigger className=" mb-1 w-[180px]"> | ||
<SelectValue placeholder="Select Theme" /> | ||
</SelectTrigger> | ||
<SelectContent> | ||
<SelectItem value="solarizedDark">Solarized Dark</SelectItem> | ||
<SelectItem value="solarizedLight">Solarized Light</SelectItem> | ||
<SelectItem value="standard">Standard</SelectItem> | ||
<SelectItem value="classic">Classic</SelectItem> | ||
<SelectItem value="githubDark">GitHub Dark</SelectItem> | ||
<SelectItem value="halloween">Halloween</SelectItem> | ||
<SelectItem value="teal">Teal</SelectItem> | ||
<SelectItem value="leftPad">Left Pad</SelectItem> | ||
<SelectItem value="dracula">Dracula</SelectItem> | ||
<SelectItem value="blue">Blue</SelectItem> | ||
<SelectItem value="panda">Panda</SelectItem> | ||
<SelectItem value="sunny">Sunny</SelectItem> | ||
<SelectItem value="pink">Pink</SelectItem> | ||
<SelectItem value="YlGnBu">YlGnBu</SelectItem> | ||
</SelectContent> | ||
</Select> | ||
); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Things are much better now.
However could you please make sure the rendered canvas is responsive?
output.mp4