improved design and UX in /dash page #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to a Personal Account owned by @phukon on Vercel. @phukon first needs to authorize it. |
phukon
reviewed
Mar 25, 2024
| </Button> | ||
| <SelectTheme handleThemeChange={handleThemeChange} /> | ||
| </div> | ||
| <div className="relative w-[400px] md:w-[900px]"> |
There was a problem hiding this comment.
Great work! Things are much better now.
However could you please make sure the rendered canvas is responsive?
output.mp4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Result
clack-p-1.mp4
Changes
SelectThemefunctionality from the /dash page & created a separate component for itcopy 🔗button in the graph/page.tsx for UI consistencygraphandgraph-layoutcomponent, as they are now solely responsible for changing their theme state (Future imrpovement: using custom context for theme)activity calender, it gives more flexibility to work with web specific features like click, hover etc)