Add ArrayChangeKeyCaseFunctionReturnTypeExtension

[VincentLanglet]

Closes phpstan/phpstan#11795
Closes phpstan/phpstan#10960

cc @staabm

[phpstan-bot]

This pull request has been marked as ready for review.

[staabm]

lgtm - thanks

[VincentLanglet]

I updated the PR to also support uppercase-string @ondrejmirtes

[ondrejmirtes]

Calling getOffsetValueType is too expensive. You can $valueTypes = $constantArray->getValueTypes() and then access $i to get it.

[VincentLanglet]

Changed

[ondrejmirtes]

Thank you.

[ondrejmirtes]

Would be nice to add a similar extension for mb_convert_case, would you look into it? Context: phpstan/phpstan#12452

Thanks!

[VincentLanglet]

Would be nice to add a similar extension for mb_convert_case, would you look into it? Context: phpstan/phpstan#12452

Thanks!

Do you have a reproducer ?

Because, for me, the mb_convert_case extension is handled by

phpstan-src/src/Type/Php/StrCaseFunctionsReturnTypeExtension.php

Line 45 in e2b5a60

'mb_convert_case' => 2,

And we can see in the history that it was handled for lowercase-string and upper-case string
https://github.com/phpstan/phpstan-src/commits/e2b5a60fa52460ba3addd519b07e2244809878ee/src/Type/Php/StrCaseFunctionsReturnTypeExtension.php

[ondrejmirtes]

I'm sorry, I haven't checked personally and trusted the user. PHPStan already handles it well https://phpstan.org/r/fad685d0-5331-4af2-8bb9-d0d1a0f81d00.

[VincentLanglet]

Yes, it works fine https://phpstan.org/r/b269ff18-e0b8-42d4-9586-87edaee9fccf