Support uppercase string

Author: VincentLanglet

src/Type/Php/ArrayChangeKeyCaseFunctionReturnTypeExtension.php

@@ -10,6 +10,7 @@
 use PHPStan\Type\Accessory\AccessoryNonEmptyStringType;
 use PHPStan\Type\Accessory\AccessoryNonFalsyStringType;
 use PHPStan\Type\Accessory\AccessoryNumericStringType;
+use PHPStan\Type\Accessory\AccessoryUppercaseStringType;
 use PHPStan\Type\Accessory\NonEmptyArrayType;
 use PHPStan\Type\ArrayType;
 use PHPStan\Type\Constant\ConstantArrayTypeBuilder;
@@ -117,6 +118,8 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection,
 					}
 					if ($case === CASE_LOWER) {
 						$types[] = new AccessoryLowercaseStringType();
+					} elseif ($case === CASE_UPPER) {
+						$types[] = new AccessoryUppercaseStringType();
 					}
 
 					return TypeCombinator::intersect(...$types);

tests/PHPStan/Analyser/nsrt/array-change-key-case.php

@@ -42,12 +42,12 @@ public function sayHello(
 
 		assertType('array<lowercase-string, string>', array_change_key_case($arr2));
 		assertType('array<lowercase-string, string>', array_change_key_case($arr2, CASE_LOWER));
-		assertType('array<string, string>', array_change_key_case($arr2, CASE_UPPER));
+		assertType('array<uppercase-string, string>', array_change_key_case($arr2, CASE_UPPER));
 		assertType('array<string, string>', array_change_key_case($arr2, $case));
 
 		assertType('array<int|lowercase-string, string>', array_change_key_case($arr3));
 		assertType('array<int|lowercase-string, string>', array_change_key_case($arr3, CASE_LOWER));
-		assertType('array<int|string, string>', array_change_key_case($arr3, CASE_UPPER));
+		assertType('array<int|uppercase-string, string>', array_change_key_case($arr3, CASE_UPPER));
 		assertType('array<int|string, string>', array_change_key_case($arr3, $case));
 
 		assertType('array<int, string>', array_change_key_case($arr4));
@@ -57,22 +57,22 @@ public function sayHello(
 
 		assertType('array<lowercase-string, string>', array_change_key_case($arr5));
 		assertType('array<lowercase-string, string>', array_change_key_case($arr5, CASE_LOWER));
-		assertType('array<string, string>', array_change_key_case($arr5, CASE_UPPER));
+		assertType('array<uppercase-string, string>', array_change_key_case($arr5, CASE_UPPER));
 		assertType('array<string, string>', array_change_key_case($arr5, $case));
 
 		assertType('array<lowercase-string&non-falsy-string, string>', array_change_key_case($arr6));
 		assertType('array<lowercase-string&non-falsy-string, string>', array_change_key_case($arr6, CASE_LOWER));
-		assertType('array<non-falsy-string, string>', array_change_key_case($arr6, CASE_UPPER));
+		assertType('array<non-falsy-string&uppercase-string, string>', array_change_key_case($arr6, CASE_UPPER));
 		assertType('array<non-falsy-string, string>', array_change_key_case($arr6, $case));
 
 		assertType('array<lowercase-string&non-empty-string, string>', array_change_key_case($arr7));
 		assertType('array<lowercase-string&non-empty-string, string>', array_change_key_case($arr7, CASE_LOWER));
-		assertType('array<non-empty-string, string>', array_change_key_case($arr7, CASE_UPPER));
+		assertType('array<non-empty-string&uppercase-string, string>', array_change_key_case($arr7, CASE_UPPER));
 		assertType('array<non-empty-string, string>', array_change_key_case($arr7, $case));
 
 		assertType('array<lowercase-string, string>', array_change_key_case($arr8));
 		assertType('array<lowercase-string, string>', array_change_key_case($arr8, CASE_LOWER));
-		assertType('array<string, string>', array_change_key_case($arr8, CASE_UPPER));
+		assertType('array<uppercase-string, string>', array_change_key_case($arr8, CASE_UPPER));
 		assertType('array<string, string>', array_change_key_case($arr8, $case));
 
 		assertType('array{foo: 1, bar?: 2}', array_change_key_case($arr9));