Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP PR to help reviewing oauth-moodle-dev #2

Open
wants to merge 457 commits into
base: oauth-moodle
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
457 commits
Select commit Hold shift + click to select a range
3f44a98
chore(GHA): Use `google-github-actions/release-please-action@v3` (#476)
erikmd Mar 20, 2022
fbbe567
chore(.github/ISSUE_TEMPLATE/*.md): Add `--tags` (#483)
erikmd Apr 21, 2022
7c14d4c
docs(src/main/*): Move server options to ad-hoc section in man pages
hernoufM Mar 22, 2022
590034f
deps(opam): Upgrade cmdliner version to 1.1.1 & Improve man pages
hernoufM Mar 22, 2022
c6ae2ca
docs(src/main/*): Document exit codes in man pages forall cmd/subcmd
hernoufM Apr 6, 2022
6cb82d6
Merge pull request #480 from hernoufM/upgrade-cmdliner.1.1.0
erikmd Apr 28, 2022
b91050e
fix(learnocaml_common.ml): Ask token (not secret) when opening exerci…
JossyYila May 30, 2022
c538200
ci(update-index.sh): Add a script to update docs/index.md
cesclass Jun 23, 2022
7174547
docs(README.md): Update/Fix README.md
cesclass Jun 23, 2022
2fdc853
docs(index.md): Update index.md
cesclass Jun 23, 2022
24c56b3
ci(check-update-index.yml): Add a workflow to check index.md
cesclass Jun 26, 2022
dd16e46
Merge pull request #492 from pfitaxel/index-update
erikmd Jun 30, 2022
bcb0ff7
build(static-binaries): Fix building of static binaries on CI (#497)
yurug Sep 15, 2022
9bc28a6
deps(opam): Bump ssl (0.5.10 -> 0.5.12) (#499)
erikmd Sep 30, 2022
e55cf61
ci(pin-artifacts.yml): Add build artifacts links within upstream comm…
erikmd Nov 26, 2022
c1054ab
fix(learnocaml_report.css): Display multiple spaces in code excerpts …
erikmd Dec 3, 2022
1c068dd
fix(web-app): Disable the Sync button at load time
erikmd Dec 16, 2022
7ea03f1
fix(web-app): Remove automatic dialog (cf. Mechanism-2 of PR #372)
erikmd Dec 16, 2022
918b79e
fix(web-app): Add Reload button that replaces Mechanism-2 of PR #372
erikmd Dec 28, 2022
dc5c89c
fix(learnocaml_common.ml): Remove unused var (leftover of PR #489)
erikmd Dec 28, 2022
dd69f3c
fix(web-app): Disable Sync after local save for a static deployment
erikmd Dec 28, 2022
b72c6d3
Merge pull request #506 from pfitaxel/fix-reload
yurug Jan 6, 2023
acab77e
chore(master): release 0.14.1 (#486)
github-actions[bot] Jan 6, 2023
64f8e44
chore(release.yml): s/git/https/ to avoid a git-clone timeout error
erikmd Jan 7, 2023
dcb2f90
chore(.github/ISSUE_TEMPLATE/*): Fix label names
erikmd Jan 7, 2023
7205c39
docs: Refactor `ISSUE_TEMPLATE`s to use GitHub issue forms (#509)
erikmd Jan 7, 2023
9000a18
chore(LICENSE): Refactor header so GitHub's parser recognizes the MIT…
erikmd Jan 13, 2023
ffb8abc
chore(LICENSE): Bump year
erikmd Jan 13, 2023
6cb8165
ci(*.yml): Use actions/checkout@v3
erikmd Jan 13, 2023
a99c61b
ci(macos): Fix `brew upgrade` failure
erikmd Jan 13, 2023
4de34a7
Merge pull request #513 from pfitaxel/fix-ci-macos
erikmd Jan 13, 2023
97668ac
chore(.github/ISSUE_TEMPLATE/config.yml): Add "questions" keyword
erikmd Feb 1, 2023
a4f9425
chore: Fix README to better reflect the history of the development
yurug Feb 10, 2023
04bb39f
docs: Fix date in README.md and Copyright headers (#517)
yurug Mar 10, 2023
68221ba
ci(macos): Fix `brew upgrade` failure, bis (#518)
erikmd Mar 12, 2023
a6e4c5e
fix(partition-view): Use Ctrl-click or ⌘-click (instead of middle-cli…
yurug Mar 12, 2023
56db6a0
chore: Update PULL_REQUEST_TEMPLATE.md
erikmd Mar 24, 2023
af83c70
ci(macos): Fix `brew upgrade` failure, ter (#536)
erikmd Apr 12, 2023
3a7c42e
feat(js_utils): Add HTMLElement.title support
erikmd Apr 17, 2023
6b7b226
feat(web-app): Add feedback button with internationalized tooltip
Apr 11, 2023
8878c9b
Merge pull request #535 from pfitaxel/feedback
erikmd Apr 18, 2023
58b3644
feat(partition-view): Add a selector to show (tokens, nicks, or anon …
Plictox May 1, 2023
84b7863
ci(macos): Run the `macOS` workflow as well in the weekly CI build
erikmd May 1, 2023
69006f8
ci(docker): Use docker/build-push-action@v4 (#544)
erikmd May 1, 2023
a31ff2b
ci(docker): Fix GHA input name: s/build_args/build-args/
erikmd May 1, 2023
046087d
ci(docker): Fix build-args syntax (docker/build-push-action@v4)
erikmd May 1, 2023
8d86f01
refactor(partition-view): Move adhoc CSS code to learnocaml_partition…
erikmd May 1, 2023
84bc393
fix(web-app): Fix `process_html_file` w.r.t. `base_url`
erikmd May 1, 2023
185328c
chore: Add 2 checkboxes in PULL_REQUEST_TEMPLATE.md
erikmd May 1, 2023
1584a08
Merge pull request #547 from pfitaxel/dont-prefix-absolute-urls
erikmd May 1, 2023
03669eb
feat(ui): better string input dialog
AltGr May 4, 2023
c341fca
feat(ui): allow name input on teacher token creation
AltGr May 4, 2023
d5d82fc
feat(ui): allow partial CSV export
AltGr May 4, 2023
8c2c639
fix(ui): show different status for open and closed assigned exercises
AltGr May 4, 2023
b20ce4e
feat(ui): teacher tab: highlight the "apply" button on unsaved changes
AltGr May 4, 2023
651456a
feat(ui): add some inline documentation to the teacher tab
AltGr May 4, 2023
1b88a18
fix(ui): update fr translation
AltGr May 4, 2023
e060517
fix(i18n): fix escaping issue in i18n
AltGr May 9, 2023
ce8c006
ci(docker): Replace `LABEL` Dockerfile commands with `labels:` (GHA) …
erikmd May 16, 2023
41c9b65
chore(docker): Fix org.opencontainers.image.source label
erikmd May 16, 2023
4e8ff45
fix: ports for docker.io/maildev/maildev
erikmd May 22, 2023
7f63d40
docs(demo-repository): Enable use_passwd, Disable use_moodle by dflt
erikmd May 22, 2023
0b150b9
Merge pull request #549 from AltGr/teacher-page-improvements
AltGr Jun 12, 2023
9694dd9
Merge branch 'master' into oauth-moodle-dev
erikmd Jun 15, 2023
a2b3726
bug: duplicate translation definition
Jun 15, 2023
b50ab2e
bug: missing parenthesis
Jun 15, 2023
78793be
fix: fixing dependencies
Jun 16, 2023
49fa30a
chore: Start .mailmap file
erikmd Jun 18, 2023
8bdd46f
chore: Add credit-region.sh
erikmd Jun 18, 2023
0cc9480
chore: Generalize credit-region.sh
erikmd Jun 19, 2023
b25d249
chore: Add missing bash option
erikmd Jun 19, 2023
211a3fd
chore: Add credit-region.el
erikmd Jun 19, 2023
e54a50e
chore(git blame): Add option -w
erikmd Jun 19, 2023
da672dc
fix: wrong signature for callbcak functions
Jun 20, 2023
a7688b2
fix: learnocaml_lti_main errors
Jun 20, 2023
42b2807
fix: handling error for crsf_token
Jun 20, 2023
c36beac
fix: handling error for token_index in signature_oauth
Jun 20, 2023
099a61b
feat: token_index.mli: fonction documentation
Jul 3, 2023
b36f7f9
fix: *.opam
erikmd Jul 5, 2023
c45b349
fix: compilation
erikmd Jul 5, 2023
48583ba
feat(ui): teacher tab: Display last synced student's draft (≠ graded …
Plictox Jul 7, 2023
d6155ff
feat: dependencies related to irmin
Jul 21, 2023
617c41d
feat: random_nonce function
Jul 21, 2023
b3f2f85
feat: module NonceIndex added for the token-nonce mapping
Jul 21, 2023
562a619
fix: correctings for token_index.ml
Jul 24, 2023
799bbc0
feat: function from_nonce added in NonceIndex module
Jul 28, 2023
a1a682e
feat: deleting the entry for NonceIndex after logout
Jul 28, 2023
3119c32
fix: wrong module name
Jul 28, 2023
e47f4a3
feat: creating the nonce for first connection
Jul 28, 2023
3fdfbc8
fix: renaming token to nonce
Jul 28, 2023
7f2b6cf
fix(ui): Use proper URL fragments ("#tab=…", not "#tab%3D…") (#557)
erikmd Aug 18, 2023
1a0c2ef
fix(web-api): percent-decode before path-splitting (#560)
tsani Aug 23, 2023
c479765
chore(master): release 0.15.0 (#511)
github-actions[bot] Aug 23, 2023
c9a833b
docs(opam): Cite Louis Gesbert in the Learn-OCaml maintainers team
erikmd Aug 23, 2023
ecb2c28
chore(.opam.locked): Update manually the version
erikmd Aug 23, 2023
f7ffc6f
fix(translations): Add missing fr.po.header
erikmd Aug 25, 2023
ea4f2bc
refactor(translations): gettext: Use CLI option `--no-wrap`
erikmd Aug 25, 2023
b4d68e8
Merge pull request #562 from pfitaxel/fix-po
erikmd Aug 28, 2023
10c9fc3
fix(teacher_tab): Display (Open/Close)GloballyInconsistent exos and f…
erikmd Aug 28, 2023
6c41457
fix(teacher_tab): partly fix Open/Close handling w.r.t. Assignments
erikmd Aug 12, 2023
3a0ceb4
test(Learnocaml_data): Add support for ppx_expect & ppx_inline_test
erikmd Aug 27, 2023
2b84fc4
Merge pull request #559 from pfitaxel/fix-open-close
erikmd Sep 15, 2023
60f3906
chore(macos): Fix `brew upgrade` failure (#563)
erikmd Sep 25, 2023
1152b26
chore(macos): Fix `brew upgrade` failure (#565)
erikmd Oct 20, 2023
25780ba
feat(UI): Add possibility to choose exercise display order
hernoufM Jun 15, 2023
91f827b
feat(UI): Rework of the exercise index
AltGr Oct 19, 2023
4f9766b
feat(UI): add exercise sorting by focus skill
AltGr Oct 24, 2023
ac967a5
Merge pull request #564 from ocaml-sf/exercises-display
AltGr Oct 24, 2023
bf6a931
refactor(Learnocaml_teacher_tab): Move critical code apart in update_…
erikmd Oct 27, 2023
c18da2a
test: Add ppx_expect tests for update_exercise_assignments
erikmd Oct 27, 2023
49d82e4
fix: update_exercise_assignments's handling of Closed/Open status
erikmd Oct 28, 2023
569d536
test: Refactor ppx_expect tests to display more details in the trace
erikmd Oct 28, 2023
c326629
Merge pull request #566 from pfitaxel/fix-558
AltGr Oct 30, 2023
9176975
deps(opam): learn-ocaml 0.x does not build with asak 0.4 (#570)
erikmd Nov 2, 2023
b84132e
ci(*.yml): Move opam-publish in a separate workflow to enable testing…
erikmd Nov 2, 2023
fbfa6a1
chore(master): release 0.16.0 (#561)
github-actions[bot] Nov 3, 2023
dfa95ac
chore(CHANGELOG.md): Remove duplicate lines
erikmd Nov 3, 2023
cad060f
ci(release.yml): Replace `hub` (not installed anymore) with `gh`
erikmd Nov 3, 2023
6a3ce07
fix(grading): avoid failing on sampling arrays with unique elements
AltGr Nov 2, 2023
0816f95
Merge pull request #568 from AltGr/noloop
AltGr Nov 3, 2023
b03bdfe
feat!: Implement pre-compilation of exercises and graders
AltGr Apr 1, 2022
47d5a06
feat: Enable downloading for only the relevant artifacts (bc or js)
AltGr Mar 31, 2022
2792faf
refactor: Get rid of the pseudo-cipher
AltGr Apr 1, 2022
87ee902
fix: Fix a small race condition in builder
AltGr Apr 1, 2022
eaad14c
perf: Make `learn-ocaml build` parallel by default
AltGr Apr 1, 2022
787840b
feat: Include Prelude/Prepare and shadow them
AltGr Apr 6, 2022
a97f813
fix: Properly type samplers
AltGr Apr 6, 2022
7422ca4
fix: Avoid double-printing of internal grader errors
AltGr Apr 7, 2022
e63359e
perf: Dump the cmis for grading only once
AltGr Apr 7, 2022
c61a4d0
fix: Fix segfault on graders using samplers returning newly defined e…
AltGr Apr 8, 2022
7825a6b
fix: Be more precise on the definition and lookup of samplers
AltGr Apr 8, 2022
46631d8
build: Make `make testrun` parallel
AltGr Apr 8, 2022
3cd75f5
feat(ppx-metaquot): Add transformation introducing the `register_samp…
hernoufM Apr 3, 2022
f0e8346
feat: Restore compatibility with static deployment
AltGr Apr 12, 2022
99e913d
refactor: Rename and generalise `recorder` to `ppx_autoregister`
AltGr Apr 13, 2022
d22a788
feat: Add support for a `test_libs.txt` file in exercises
AltGr Apr 15, 2022
e768616
feat: Preprocessing and typing of samplers and printers
AltGr Apr 21, 2022
3fc41ca
feat: Provide lib to compile grader helper libraries
AltGr Apr 19, 2022
7d27523
fix: Fix printer registration in the grader
AltGr Apr 20, 2022
c432909
fix: Do some cleanup & Fix `mutation_testing` test lib
AltGr Apr 20, 2022
264db4c
refactor: Generalize sampler typing
AltGr Apr 21, 2022
1ec3af6
fix: Allow printer registration in prepare/prelude & Fix print callba…
AltGr Apr 21, 2022
54851dd
refactor: Disable debug flags
AltGr Apr 22, 2022
f028b75
docs: Update French translation
AltGr Apr 22, 2022
9155145
docs!: Remove doc tutorial on `depend.txt` (it will need rewriting)
AltGr Apr 22, 2022
2c89d9e
docs: Update doc for pre-compiled exercises + `test_libs.txt`
AltGr Apr 22, 2022
32ad13e
fix: Fix dune dependency glitch on recompilation of `mutation_test`
AltGr Apr 22, 2022
466e80c
fix(docker): Include jsoo in Dockerfile, which is now needed
AltGr Apr 22, 2022
fa2cd23
fix(ci): Fix permission issues
AltGr Apr 22, 2022
5b4e0ab
docs: Add/Update copyright headers
AltGr Apr 22, 2022
365cbb7
fix: Expose `prepare.ml` file
yurug Jul 27, 2022
57ca10b
fix(partition-view): Reactivate the feature
yurug Jul 27, 2022
ee57ac1
fix(CLI): Report JSON parse error origin and locations
AltGr Oct 26, 2023
cb417d1
strengthening(grader): Add a safeguard against grading workers going …
AltGr Oct 26, 2023
ead187e
fix(grader): allow exercises to use vg, gg
AltGr Oct 26, 2023
942edc2
fix(teacher_tab): use newer asak compatible with precompilation
nobrakal Sep 11, 2023
f572990
doc: update index.md
AltGr Oct 26, 2023
f1abb7d
fix(build): update lockfiles
AltGr Oct 26, 2023
b94f053
fix(CI): attempt to fix running the docker image on the corpus
AltGr Oct 26, 2023
91a418e
fix(CI): disable compat tests with 0.12, 0.13
AltGr Oct 27, 2023
6ce797f
fix(docker): install more libs in server image
AltGr Oct 31, 2023
6356328
Merge pull request #481 from AltGr/a7977b52
AltGr Nov 3, 2023
6583af4
fix(grader): avoid errors with too many open files on parallel builds
AltGr Oct 27, 2023
82d9bea
feat(server): add a `--replace` option
AltGr Oct 27, 2023
995a79d
feat(grader): Show a status line on what is being built
AltGr Oct 30, 2023
6cee13c
Merge pull request #567 from AltGr/server-replace
AltGr Nov 24, 2023
01eae90
feat(CI): Deploy artifacts to github-pages
AltGr Dec 5, 2023
a1ae152
Merge pull request #576 from ocaml-sf/deploy-artifacts
AltGr Dec 5, 2023
27b3b7e
CI: Fixing artifacts publication
AltGr Dec 5, 2023
e56d654
CI: Fixing artifacts publication
AltGr Dec 5, 2023
38f746e
CI: Fixing artifacts publication
AltGr Dec 5, 2023
1b78dea
CI: Fixing artifacts publication
AltGr Dec 5, 2023
bd6ebf8
CI: Fixing artifacts publication
AltGr Dec 5, 2023
d863e57
CI: Fixing artifacts publication
AltGr Dec 5, 2023
9cf5486
ci: Fix jekyll-build-pages source for https://ocaml-sf.org/learn-ocam…
erikmd Dec 12, 2023
fde66f5
Fixing OSX CI
AltGr Dec 12, 2023
fb300f6
Fixing OSX CI again
AltGr Dec 12, 2023
6e9cd2b
ci(release.yml): Next release version will be 1.0.0
erikmd Feb 9, 2024
a242084
fix: Avoid using `lsof -Q` which is only available from lsof 4.95.0
erikmd Feb 9, 2024
3c9c123
fix(UI): Small CSS fix for exercise lists on small screens
AltGr Feb 9, 2024
fe2a806
fix: Do exercise recompilation correctly with `--replace` (#584)
AltGr Feb 12, 2024
6535692
feat: Add CLI option `learn-ocaml build --build-dir=[./_learn-ocaml-b…
erikmd Feb 12, 2024
4e8c999
chore(master): release 1.0.0 (#572)
github-actions[bot] Feb 13, 2024
3d47998
chore(test-opam-publish.yml): Run preflight (#586)
erikmd Feb 13, 2024
9972239
chore(CHANGELOG.md): Backup last edit in release notes
erikmd Feb 16, 2024
0a69394
ci(macos): s/macos-latest/macos-14/ (#598)
erikmd Apr 11, 2024
b7ed29c
ci(GHA): Use actions/checkout@v4 (#599)
erikmd Apr 11, 2024
97ff4af
chore: Rename local var (app_dir -> temp_dir) to avoid any ambiguity …
erikmd Apr 6, 2024
a47f8dd
feat(CLI): Add option `learn-ocaml build serve --serve-during-build`
erikmd Apr 8, 2024
3b14462
fix(server): Add missing flush in Learnocaml_server.kill_running
erikmd Apr 9, 2024
2784290
style: Fix displayed version to adapt to git tags naming convention
erikmd Apr 9, 2024
cc6caa3
fix(docker): Add missing alpine package (lsof)
erikmd Apr 9, 2024
dc6f569
Merge pull request #597 from pfitaxel/feat/serve-during-rebuild
erikmd Apr 19, 2024
8cabe07
chore(release.yml): Make "style:" conventional-commits category visible
erikmd Apr 19, 2024
f318b95
docs(CONTRIBUTING.md): minor update
erikmd Apr 20, 2024
d2c8d65
fix(CI): Use macos-13 for static-builds (#603)
erikmd Jul 26, 2024
5780d3a
build(deps): bump dawidd6/action-download-artifact from 2 to 6 in /.g…
dependabot[bot] Jan 16, 2025
e34b5f7
feat(build): Migrate ocplib-i18n to ppxlib
AltGr Sep 28, 2021
d73e5a0
Use pin-depends until release of newer ocp-indent-nlfork
AltGr Sep 28, 2021
9b789c9
Update stdlib file names for 4.13
AltGr Sep 28, 2021
49c7208
fix(build): Fix/disable some warnings
AltGr Jul 22, 2024
4b30226
Update genlifter.ml from upstrim ppx_tools
AltGr Jul 22, 2024
b2a2186
Remove dependency on ocaml-migrate-parsetree
AltGr Jul 22, 2024
60a2e07
Upgrade to OCaml 4.13
AltGr Jul 22, 2024
965e42e
Udate to OCaml 4.14.2
AltGr Jul 23, 2024
d565011
Disable Asak for now (it's not compatible with OCaml 5.0 at the moment)
AltGr Jul 23, 2024
7d096a5
Update dune-project
AltGr Jul 23, 2024
d0ac3b5
ocplib-json-typed is now json-data-encoding
AltGr Jul 23, 2024
0c9c994
Update opam files for OCaml 5.0
AltGr Jul 23, 2024
841d586
ppx_ocplib_i18n doesn't cope well with dune sandboxing
AltGr Jul 23, 2024
c5ee058
Disable partitioning functionality for now (asak isn't compatible wit…
AltGr Jul 23, 2024
22decce
Update stdlib cmi list
AltGr Jul 23, 2024
91421ae
Now compiles (but is broken) with 5.0.0
AltGr Jul 23, 2024
5a52fe3
Fix a bunch of deprecation warnings & errors
AltGr Jul 24, 2024
5a1264f
Adjust jsoo compilation flags
AltGr Jul 24, 2024
029b614
Working with OCaml 5.0.0 / jsoo 5.0.1
AltGr Jul 24, 2024
e46d9b6
Update jsoo to 5.1.1
AltGr Jul 24, 2024
a3e89a1
Many fixes and update for jsoo 5
AltGr Jul 25, 2024
1a76ddb
fix: Actually bind the `--dry-run` flag
AltGr Jul 25, 2024
ec60736
Improve web-worker debug messages
AltGr Jul 25, 2024
4faac64
Adjust to OCaml 5.1.1
AltGr Jul 25, 2024
5f5dbb7
feat: complete porting to OCaml 5.1 and jsoo 5.8
AltGr Jul 25, 2024
9d757cd
feat: bump version to 1.1.0
AltGr Jul 25, 2024
046d7dd
feat: Reenable asak (using pin-depends for compat patch with OCaml 5)
AltGr Jul 25, 2024
8012c6b
fix(CI): fix Dockerfile and client dependencies
AltGr Jul 25, 2024
a5b4abf
fix(CI): use older dependency releases in lockfile
AltGr Jul 25, 2024
283456d
fix(CI): fix static builds and some specific deps
AltGr Jul 25, 2024
e721ad4
fix(CI): fix base Alpine version for final Docker images
AltGr Jul 25, 2024
31b244c
Fixes following review
AltGr Jul 26, 2024
379c47b
chore: Make dune-build a bit more verbose (for debugging purpose)
erikmd Jan 16, 2025
c50b77d
deps(opam): Bump conf-pkg-config
erikmd Jan 16, 2025
2081069
deps(opam): Bump conf-libssl
erikmd Jan 18, 2025
a636b26
deps(opam): Skip conduit-lwt-unix's latest release for now
erikmd Jan 18, 2025
6b0bc56
fix(build): Update linking flags (needed for POSIX & macOS static bin…
erikmd Jan 18, 2025
3e8afe8
fix(build): Fix static build on macOS w.r.t. libzstd
erikmd Jan 18, 2025
6f6be0f
build(js_of_ocaml): Remove `--no-source-map` from root dune file
erikmd Jan 18, 2025
cb5c1dd
Remove temporary pin-depends
AltGr Jan 22, 2025
d66a184
Update to OCaml 5.1.1, jsoo 5.8.2 (#602)
erikmd Jan 26, 2025
62f6e24
chore: Fix Markdown badges URL
erikmd Jan 26, 2025
c8174f8
chore: ./scripts/update-index.sh
erikmd Jan 26, 2025
21cf0da
Merge branch 'master' into oauth-moodle-dev
erikmd Feb 17, 2025
b588c87
fix(opam): Fix opam.locked files following the merge
erikmd Feb 17, 2025
378e2f5
fix(translations): Repair fr.po file following the merge
erikmd Feb 17, 2025
ec14ca0
deps(opam): Add irmin-git
erikmd Feb 17, 2025
a50b5b5
deps(opam): Bump minimal version of decompress (1.0.0)
erikmd Feb 22, 2025
ee61243
build(dune): ppx_ocplib_i18n doesn't cope well with dune sandboxing
erikmd Feb 23, 2025
6331e6f
deps(opam): Fix the irmin-git version, may be lifted anytime
erikmd Feb 23, 2025
6d9f7ca
deps(opam): Add letters & Update .locked files
erikmd Feb 27, 2025
887eb3e
refactor(learnocaml_sendmail): Use library letters
erikmd Mar 2, 2025
00099cc
refactor(server): Use library decompress.de
erikmd Mar 2, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: better error msg for X-token registration
    This fix the first point of the issue ocaml-sf#405.
EmileRolley committed Jul 20, 2021

Verified

This commit was signed with the committer’s verified signature.
erikmd Erik Martin-Dorel
commit e27415cf67ba4c976f96067fd1d201999b7692af
4 changes: 3 additions & 1 deletion src/state/learnocaml_store.ml
Original file line number Diff line number Diff line change
@@ -339,7 +339,9 @@ module Token = struct

let register ?(allow_teacher=false) token =
if not allow_teacher && is_teacher token then
Lwt.fail (Invalid_argument "Registration of teacher token not allowed")
Lwt.fail
(Invalid_argument "Registration of teacher token forbidden. \
Logout and use a new teacher token?")
else
Lwt.catch (fun () ->
Lwt_io.with_file ~mode:Lwt_io.Output ~perm:0o700 (save_path token)