WIP PR to help reviewing oauth-moodle-dev #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, `git describe` does not seem to read tags created by release-please.
The new version of cmdliner has added support for UTF-8 encoded characters within man pages. At the same time, a new module has been added, whose features will replace deprecated `Term.eval*` evaluation functions and `Term.info`. Additionally, this commit refactors man pages, making it a bit cleaner to read.
Upgrade to cmdliner.1.1.1 and improve clarity of manuals
Related: ocaml-sf#490 Co-authored-by: Erik Martin-Dorel <[email protected]>
* Add missing links in "Howtos" from docs/index.md * Fix URLs format in "License and copyright" * Remove unnecessary spaces before bullet list elements
* Update index.md with the updated README.md using update-index.sh
* The workflow check out the repo and execute update-index.sh. Then it check the diffs using git diff on index.md. Related: ocaml-sf#490 Co-authored-by: Erik Martin-Dorel <[email protected]>
Automate the update of `docs/index.md`
…sf#497) See https://github.com/ocaml-sf/learn-ocaml/actions/runs/2681164428/jobs/4179683350 Close ocaml-sf#496 Signed-off-by: Yann Regis-Gianas <[email protected]>
This fixes "bug 0" of issue ocaml-sf#505.
…#372) This fixes "bugs 1, 2" of issue ocaml-sf#505.
…-sf#372 This button triggers a "Fetch_save" and makes a menu appear, allowing end users to reuse their latest graded code, their latest saved code, or the initial template code. This button only shows up when a non-static backend is detected. Update the French translation as well. This fixes "bug 3" of issue ocaml-sf#505. Close ocaml-sf#493 Close ocaml-sf#505
…#489) This small patch avoids a warning and also saves one HTTP request.
Remove Mechanism-2 (ocaml-sf#372), Add a 3-fold on-demand Reload button, Fix extra minor bugs
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Erik Martin-Dorel <[email protected]>
``` Cloning into '/home/runner/.opam/plugins/opam-publish/repos/ocaml%opam-repository'... fatal: unable to connect to github.com: github.com[0: 140.82.113.3]: errno=Connection timed out ```
it's a bit annoying to have the client depend on asak just because of a datatype that's not used, but fixing that would require some reorganisation.
(so that it's already in the Docker images)
Fix CI's FTBFS on (macOS, opam/--locked)
href: mirage/ocaml-conduit@f5facd8 TODO-Later: Remove `<` bound, Bump cohttp-lwt-unix's minimal version, Fix build
- hopefully -
Avoid the following error at ld time:
```
ld: Undefined symbols:
_ZSTD_compressStream2, referenced from:
_caml_zstd_compress in ocamlcommon.a[114](zstd.npic.o)
_ZSTD_createCCtx, referenced from:
_caml_zstd_compress in ocamlcommon.a[114](zstd.npic.o)
_ZSTD_decompress, referenced from:
_caml_zstd_decompress in ocamlcommon.a[114](zstd.npic.o)
_ZSTD_freeCCtx, referenced from:
_caml_zstd_compress in ocamlcommon.a[114](zstd.npic.o)
clang: error: linker command failed with exit code 1 (use -v to see invocation)
File "caml_startup", line 1:
Error: Error during linking (exit code 1)
ocamlc src/main/.learnocaml_main.eobjs/byte/dune__exe__Learnocaml_main.{cmi,cmti}
ocamlc src/repo/.learnocaml_process_repository_lib.objs/byte/learnocaml_process_exercise_repository.{cmo,cmt}
ocamlc src/repo/.learnocaml_process_repository_lib.objs/byte/learnocaml_process_tutorial_repository.{cmo,cmt}
```
as for some reason a duplicate flag was passed, causing failure: href: https://github.com/ocaml-sf/learn-ocaml/actions/runs/12846419515/job/35821578447?pr=602 ``` ocaml-sf#26 15.79 - File "src/app/dune", line 86, characters 7-30: ocaml-sf#26 15.79 - 86 | (name learnocaml_student_view) ocaml-sf#26 15.79 - ^^^^^^^^^^^^^^^^^^^^^^^ ocaml-sf#26 15.79 - (cd _build/default/src/app && /home/opam/.opam/5.1/bin/js_of_ocaml --no-source-map --no-source-map --opt=2 --enable=use-js-string --target-env=browser -o learnocaml_student_view.bc.js /home/opam/.opam/5.1/lib/cstruct/cstruct.js /home/opam/.opam/5.1/lib/bigstringaf/runtime.js ../ace-lib/ace_bindings.js learnocaml_student_view.bc-for-jsoo) ocaml-sf#26 15.79 - js_of_ocaml: option '--no-source-map' cannot be repeated ocaml-sf#26 15.79 - Usage: js_of_ocaml [COMMAND] … ocaml-sf#26 15.79 - Try 'js_of_ocaml --help' for more information. ``` using js_of_ocaml 5.9.1
now that asak 0.5 and ocp-indent-nlfork 1.5.5 are published.
(@AltGr) This mainly required time debugging and finding which parts of the code where silently failing with the newer version. Once I found the way to make our version of ppx_metaquot work with the newer ppxlib (very small code change in the end, but it took quite a bit of digging the ppxlib api), most of the effort was actually in updating jsoo rather than OCaml. We stick at 5.1 for now because ppx_tools (of which we vendor a patched bit) could easily work with it, but isn't ported to 5.2 yet. There has been lots of improvements in jsoo in the 5.x branch, and I expect things to be faster although I haven't run benches.
$(git rev-parse master) = c8174f8 Conflicts: .github/workflows/static-builds.yml Dockerfile dune-project learn-ocaml-client.opam learn-ocaml-client.opam.locked learn-ocaml.opam learn-ocaml.opam.locked src/app/learnocaml_index_main.ml src/main/dune src/main/learnocaml_server_main.ml src/main/linking_flags.sh src/state/dune src/state/learnocaml_api.ml src/utils/lwt_utils.ml translations/fr.po Note: * {learn-ocaml.opam.locked, learn-ocaml-client.opam.locked} were overwritten as is from master, so an upcoming commit should fix them. * the ocamlnet package was removed as it is not 5.x compatible, so the branch doesn't compile yet.
- ppx_tools → ocaml < 5.1.0
not available because the package is pinned to version 5.1.1
$ opam install --solver=aspcud --criteria="-sum(solution,avoid-version),-count(removed),-count(down),-count(changed)" safepass cryptokit
$ opam lock .
$ sed -i.bak learn-ocaml-client.opam.locked -e '/ocaml-base-compiler/d'
$ sed -i.bak learn-ocaml.opam.locked -e '/ocaml-base-compiler/d'
$ opam install --solver=aspcud --criteria="-sum(solution,avoid-version),-count(removed),-count(down),-count(changed)" irmin-git.3.10.0 $ opam lock . $ sed -e '/ocaml-base-compiler/d' -i learn-ocaml-client.opam.locked learn-ocaml.opam.locked
Goal: just reduce the elapsed time of opam deps' constraints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.