Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme training script args and requirements #28

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

s1lent4gnt
Copy link

The command pip install rl_zoo3 is not included in the requirements.

Running the training command resulted in an error: rl_zoo3_conf.yaml could not be found because it is located in the examples folder.

When running the gym-lowcostrobot training command, I received an error: unexpected keyword argument 'observation_mode'.
This issue arises from the observation_mode keyword argument in the rl_zoo3_conf.yaml file for the ReachCube-V0 environment.

The argument -orga does not exist in the train script of rl_zoo3.

@perezjln
Copy link
Owner

perezjln commented Jul 1, 2024

Hello @qgallouedec, would you mind having a look, for the orga please.
I suppose it is --orga assuming the correct version of zoo.
@lil-km - Regarding rl_zoo3_conf.yaml , we should maybe put the example/ dir as prefix to prevent confusion.

@qgallouedec
Copy link
Collaborator

Thanks @lil-km!

The command pip install rl_zoo3 is not included in the requirements

It's because it's not required for installing this package. rl_zoo3 is only required if you want to train one env with it. You can add pip install rl_zoo3 before the training command though.

I suppose it is --orga assuming the correct version of zoo.

No, orga is for pushing to hub (rl_zoo3.push_to_hub)

So appart from installation instruction, lgtm

@perezjln
Copy link
Owner

perezjln commented Jul 4, 2024

Thanks @qgallouedec ,

No, orga is for pushing to hub (rl_zoo3.push_to_hub)

So it means one should add this extra command into the readme maybe.

@perezjln perezjln merged commit 0b542db into perezjln:main Jul 4, 2024
4 checks passed
@qgallouedec
Copy link
Collaborator

Make sure to place the rl-zoo3 installation command in the right section (I can see it hasn't been corrected in this pr)

@s1lent4gnt s1lent4gnt deleted the fix/readme-training-script-args branch July 4, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants