Fully Functional Python 3 - using requests in place of urllib2 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rows command to set sorting to nothing if none is specified
Updated requirement to requests
|
All Tests pass! The changes to the test files were to adjust it to the defaults in 2.8 after I validated they were correct using the open refine UI. The very first test case I had to adjust, I had to make the column all numbers before the sting conversion would work for all columns. That was also the case when I used the UI. |
daniel-butler
changed the title
This was referenced May 20, 2018
|
fixes for the following issues # #11 # |
…n file when creating new projects.
psychemedia
reviewed
Jan 3, 2019
| @@ -639,12 +643,11 @@ def get_reconciliation_services(self): | |||
| def get_reconciliation_service_by_name_or_url(self, name): | |||
| recon_services = self.get_reconciliation_services() | |||
| for recon_service in recon_services: | |||
| if recon_service['name'] == name or recon_service['url'] == name: | |||
| if recon_service['name'] == name or recon_service['server_url'] == name: | |||
There was a problem hiding this comment.
This change breaks lookups on wikidata reconciliation for me. Also line 676.
|
Creating a new project in OR 3.1 fails for me; works okay-ish with OR 2.8, although the project is created as |
|
Do you have any minimal working examples of how to do reconciliation? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on fixing the facet engine. All but some of the tutorial tests pass