extended CLI (create projects and templating export) #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paulmakepeace I can try to find a bit of time to tinker with this again; would be great to have a canonical py3 version of the client available. Not strictly related to the OR py client, but in the ballpark, IIRC I also got stuck on linking a py based linked reconciliation service which I need to revisit... |
moved parser from refine.py to google/refine/__main__.py to allow module execution (python -m google.refine); script refine.py is now just a forwarding to __main__.py
…based on Docker images.
default to main versions option for multiple tags option for host port improved usage of sudo more examples in help screen
create project from url has never worked before new_project_defaults are outdated
fixed bug #1 (option columnWidths broken since v0.3.2) fixed bug #2 (commands create and export templating broken since v0.3.5) added --download command extended --info command improved performance of --export command improved error handling and user feedback removed support for legacy docker option --link added detailed usage instructions with examples moved and extended instructions from docker/README.md to README.md added usage instructions for Python library added chapter on Binder openrefineder added badges for docker, pypi and binder added usage instructions for tests script added note to myself for distributing releases moved all functions from parser to cli module separated export and template function improved code style (PEP8)
new feature: xml root element will be discovered if recordPath is not set bugfix: newly introduced option projectTags was not working in 0.3.7 bugfix: txt defaulted to fixed-width (should be line-based) bugfix: default recordPath for json was not working in 0.3.7 bugfix: default sheets option was broken (but xls, xlsx, ods is broken in OpenRefine >=2.8 anyway, see #4) tests: added sample files and an ipython notebook for comprehensive tests of create option
|
Hey @paulmakepeace
I have realigned the code in the fork as much as possible to the Python Client Library. There are a few things I can contribute to the core, I think. These are the new pull requests (and I'm closing this general one now):
I won't be able to work on the project for a few months. After the break I'll work on the tests in #19 and the port to Python 3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paul, maybe you want to "cherry-pick"? The code quality should be better than my first pull request half a year ago but I am still learning. Please let me know if you have any advice on how to better align to your codebase.