check-and-clip linear_rescale to [0,1] #524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… point errors that sometimes occur on GPUs.
|
Closing as superseded by #526! Thanks @mattlevine22 for putting this one together :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protect against floating point errors that sometimes occur on GPUs (jax-ml/jax#24807). Previously observed that linear_rescale was sometimes returning 1.000001 for
t==t1, and this was creating an error in theevaluatemethod ofVirtualBrownianTreeduring SDE solves on GPU. Did not observe issue on CPUs.