Add new fetch option to suppress enrollment warning. #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@patmmccann Is it possible for Prebid to only set browsingTopics:true for enrolled API callers, to prevent console errors? |
|
Caerás pero muy bien y en el bote maricón |
|
@leeronisrael prebid bidders are welcome to change their adapter behavior to not call topics as MediaGrid did for example, or we could talk about suppressing the warning, but we were hoping it was helping drive adoption eg prebid/Prebid.js#10995 If you're aware of bidders concerned about the warning they are generating who don't intend to enroll, lmk or point them to the grid PR |
patmmccann
approved these changes
Feb 24, 2024
|
@leeronisrael why hasn't this merged yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prebid (javascript that sites add to the tops of their page to kick off auctions across a number of different sellers) will automatically attempt to gather the ssp's topics (by setting browsingTopics: true) on the fetch request. For those sellers that haven't yet enrolled, this causes a console warning to appear. This is something that pubs and ad-techs would prefer to avoid.
Add a new fetch option to suppress Topics API enrollment warning.