Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q: Why browsingTopics: true by default on all outgoing bidder requests? #11148

Open
orazumov-zeta opened this issue Feb 27, 2024 · 4 comments
Open

Comments

@orazumov-zeta
Copy link
Contributor

Type of issue

Question

Description

Why browsingTopics: true by default on outgoing bidder requests? (sources)
Related PR: Core: enable Sec-Browsing-Topics header on outgoing bidder requests #10340

image

Not all bidders support this. As a result, in Chrome console, I see numerous errors of the type 'Attestation check for Topics on URL failed.' There is an option 'topicsHeader' to control this. Perhaps it would be better to have browsingTopics enabled not by default, but only when this option is explicitly specified?

Steps to reproduce

Open the Chrome browser console on any page where Prebid.js is running with configured bidders that do not support browsingTopics (for example, appnexus, mediafuse, sovrn, minutemedia, etc.). You will see errors Attestation check for Topics on URL failed.

image

Test page

Here you can see such error: https://www.bmwblog.com/2024/02/26/how-a-bmw-7-series-turned-from-city-cruiser-to-off-road-adventurer/

Expected results

Actual results

Platform details

Prebid.js 8.35
Chrome 121.0.6167.184 (Official Build) (arm64)

Other information

Core: enable Sec-Browsing-Topics header on outgoing bidder requests

@dgirardi
Copy link
Collaborator

Are those error messages a problem? As far as I know they are inconsequential, so it seems reasonable to try to include topics by default, since for the exchanges that can accept them they are valuable.

@patmmccann
Copy link
Collaborator

We were hoping the error messages would encourage adoption. The Chrome team actually noted this in their repo patcg-individual-drafts/topics#289

My inclination is bidders generating warnings should handle individually.

@dgirardi
Copy link
Collaborator

We can set suppressTopicsEnrollmentWarning: true unless debug is true.

@patmmccann patmmccann moved this from Triage to Ready for Dev in Prebid.js Tactical Issues table Mar 1, 2024
@msperone
Copy link

msperone commented Sep 5, 2024

A fix for this error would be greatly appreciated! I understand the perspective of throwing errors to encourage adoption of the feature. But this is a lot of noise in the javascript console and has caused my team to miss some legitimate errors.

I like the idea to suppress the error unless debugging is turned on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for Dev
Development

No branches or pull requests

4 participants