Spec: Fix broken references to Shared Storage #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexmturner PTAL! |
|
I just realized "The SharedStorage's run() method" doesn't flow as well as "The WindowSharedStorage's run() method", so I dropped the possessive. |
alexmturner
approved these changes
Aug 21, 2024
github-actions bot
added a commit
that referenced
this pull request
Aug 21, 2024
SHA: 49cd4e0 Reason: push, by alexmturner Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like a change upstream in the Shared Storage spec means we need to update our references: WICG/shared-storage#171
The "Go through all monkey patches" issue on line 1166 still stands :)
Preview | Diff