Spec: Improve definition of the encryption algorithm #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexmturner, PTAL! Direct preview link to the modified algorithm: https://pr-preview.s3.amazonaws.com/dmcardle/private-aggregation-api/pull/155.html#encrypt-the-payload |
dmcardle
commented
Aug 19, 2024
alexmturner
reviewed
Aug 19, 2024
alexmturner
reviewed
Aug 20, 2024
alexmturner
reviewed
Aug 20, 2024
|
@alexmturner I took your advice and made a few edits, PTAL at this latest revision! |
alexmturner
approved these changes
Aug 21, 2024
This adds a missing return step to the algorithm definition, adds an explicit instruction to throw when encryption fails, and attempts to clarify our commentary on RFC9180. Followup to patcg-individual-drafts#147
|
Rebased and squashed — PTAL! |
dmcardle
commented
Aug 22, 2024
github-actions bot
added a commit
that referenced
this pull request
Aug 22, 2024
SHA: 80bc584 Reason: push, by alexmturner Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a missing return step to the algorithm definition, adds an explicit instruction to throw when encryption fails, and attempts to clarify our commentary on RFC9180.
Followup to #147
Preview | Diff