Spec: Fix algorithm declarations #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcardle
force-pushed
the
dmcardle-spec-algorithm
branch
2 times, most recently
from
9c23648 to
8ccaed2
Compare
|
@alexmturner PTAL! I'm not sure how exactly the Shared Storage monkey patches should be marked up, but there's an |
alexmturner
reviewed
Aug 2, 2024
dmcardle
force-pushed
the
dmcardle-spec-algorithm
branch
from
8ccaed2 to
676ad00
Compare
The Bikeshed Documentation (dated 8 March 2024) says, "Algorithms can be explicitly indicated in your markup by putting the algorithm attribute on a container element or a heading" [1]. Through trial and error, I discovered that algorithm-specific markup is not generated when you write <dfn algorithm>. Instead, the <dfn> tag must be wrapped in something like <div algorithm>. This change has at least two positive results: 1. Local variables are no longer declared in the global scope! 2. We can now click on local variables and they are highlighted in pretty colors. [1]: https://speced.github.io/bikeshed/#var-and-algorithms
dmcardle
force-pushed
the
dmcardle-spec-algorithm
branch
from
676ad00 to
d106166
Compare
|
@alexmturner PTAL! |
alexmturner
reviewed
Aug 6, 2024
|
Hey Alex, PTAL :) |
github-actions bot
added a commit
that referenced
this pull request
Aug 19, 2024
SHA: 80fbc0f Reason: push, by alexmturner Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
dmcardle
added a commit
to dmcardle/private-aggregation-api
that referenced
this pull request
Aug 19, 2024
This adds a missing return step to the algorithm definition, adds an explicit instruction to throw when encryption fails, and attempts to clarify our commentary on RFC9180. Followup to patcg-individual-drafts#147
dmcardle
added a commit
to dmcardle/private-aggregation-api
that referenced
this pull request
Aug 22, 2024
This adds a missing return step to the algorithm definition, adds an explicit instruction to throw when encryption fails, and attempts to clarify our commentary on RFC9180. Followup to patcg-individual-drafts#147
alexmturner
pushed a commit
that referenced
this pull request
Aug 22, 2024
This adds a missing return step to the algorithm definition, adds an explicit instruction to throw when encryption fails, and attempts to clarify our commentary on RFC9180. Followup to #147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Bikeshed Documentation (dated 8 March 2024) says, "Algorithms can be explicitly indicated in your markup by putting the algorithm attribute on a container element or a heading" 1.
Through trial and error, I discovered that algorithm-specific markup is not generated when you write
<dfn algorithm>. Instead, the<dfn>tag must be wrapped in something like<div algorithm>.This change has at least two positive results:
Preview | Diff