Skip to content

Update ThemesIndexControllerTest.php #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update ThemesIndexControllerTest.php #541

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3326c28
Update ThemesIndexControllerTest.php by removing the usage of legacy …
LeonardoPagani May 3, 2025
77976c8
Merge branch 'master' into master
LeonardoPagani May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions ...PassboltCe/AccountSettings/tests/TestCase/Controller/Themes/ThemesIndexControllerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,11 @@

namespace Passbolt\AccountSettings\Test\TestCase\Controller\Themes;

use App\Test\Factory\UserFactory;
use App\Test\Lib\AppIntegrationTestCase;
use App\Utility\UuidFactory;
use Cake\ORM\Locator\LocatorAwareTrait;
use Passbolt\AccountSettings\Test\Factory\AccountSettingFactory;

/**
* @uses \Passbolt\AccountSettings\Controller\Themes\ThemesIndexController
Expand All @@ -32,20 +35,19 @@ class ThemesIndexControllerTest extends AppIntegrationTestCase
*/
protected $AccountSettings;

public array $fixtures = [
'plugin.Passbolt/AccountSettings.AccountSettings',
];

public function setUp(): void
{
parent::setUp();
$this->AccountSettings = $this->fetchTable('AccountSettings');
$this->AccountSettings = $this->fetchTable('Passbolt/AccountSettings.AccountSettings');
}

public function testThemesIndexSuccess()
{
$user = UserFactory::make()->user()->persist();
AccountSettingFactory::make()->theme('midgar')->withUser($user)->persist();

// Authenticate as ada and list the themes
$this->logInAsUser();
$this->logInAs($user);
$this->get('/account/settings/themes.json?api-version=v2');
$this->assertResponseOk();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to add an assertion here, ensuring that the theme midgar is well returned in the response.

}
Expand Down