Update ThemesIndexControllerTest.php #541
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AccountSettings fixture to complete task passbolt#536
|
|
|
|
| $this->logInAsUser(); | ||
| $this->logInAs($user); | ||
| $this->get('/account/settings/themes.json?api-version=v2'); | ||
| $this->assertResponseOk(); |
There was a problem hiding this comment.
I would suggest to add an assertion here, ensuring that the theme midgar is well returned in the response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#536
This pull request is a:
Checklist
What you did
As part of my Trainee assessment for a summer internship at passbolt to update an existing unit test as described in task #536. I have completed this task and am opening a pull request with my changes.
Updated ThemeIndexControllerTest.php to use Fixture Factories instead of legacy fixtures.
removed:
public $fixtures = [
'plugin.Passbolt/AccountSettings.AccountSettings',
];
modified testThemesIndexSucess() to use fixture factoring as it requires a user to be created and authenticated.
did not alter testThemesIndexErrorNotAuthenticated() as no factory is needed.