Skip to content

feat: Allow freeform text view resizing in modal dialogs #2910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 16, 2025

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Jul 16, 2025

Summary

  • let modals expand horizontally
  • allow resizing text views horizontally as well
  • document change in the alpha changelog

Testing

  • npm test
  • npm run lint

https://chatgpt.com/codex/tasks/task_e_6877e3a0583c832da0d111e2ba26b7a5

Summary by CodeRabbit

  • Style
    • Modal windows now have a flexible width that can expand beyond 540px while maintaining a minimum width.
    • Text input fields are now resizable both horizontally and vertically and cannot shrink below their container size.
    • Left-aligned fields maintain a fixed proportional width and no longer shrink in flexible layouts.
    • Label widths in fields are now controlled by CSS variables for consistent proportional sizing.

Copy link

I will reformat the title to use the proper commit message syntax.

Copy link

The label codex cannot be used here.

@parse-github-assistant parse-github-assistant bot changed the title fix: allow freeform text view resizing fix: Allow freeform text view resizing Jul 16, 2025
Copy link

coderabbitai bot commented Jul 16, 2025

Warning

Rate limit exceeded

@mtrezza has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 27 minutes and 28 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between efb9d8f and 98a1bdb.

📒 Files selected for processing (2)
  • src/components/Field/Field.scss (2 hunks)
  • src/components/Modal/Modal.scss (1 hunks)
📝 Walkthrough

Walkthrough

The changes adjust CSS styles in three component files. The modal's width is now flexible with a minimum constraint using a CSS variable, the text input can be resized both horizontally and vertically, and the field's left section is prevented from shrinking with fixed proportional width set via CSS variables. The Field.react.js component updates inline width style to a CSS custom property for label width ratio.

Changes

File(s) Change Summary
src/components/Modal/Modal.scss Changed .modal width from fixed 540px to width: auto; min-width: var(--modal-min-width, 540px); with new CSS variable; adjusted horizontal centering and removed width transition and animation mixin
src/components/TextInput/TextInput.scss Added min-width: 100%; min-height: 100%; and changed .text_input resize property from vertical to both
src/components/Field/Field.scss Added flex-shrink: 0; and set min-width, width, and max-width using CSS variables for .left class; changed .right flex shorthand to flex: 1 0 auto
src/components/Field/Field.react.js Replaced inline width style with CSS custom property --modal-label-ratio for label width ratio

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

parse-github-assistant bot commented Jul 16, 2025

🚀 Thanks for opening this pull request!

@parseplatformorg
Copy link
Contributor

parseplatformorg commented Jul 16, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/components/TextInput/TextInput.scss (1)

19-20: Consider constraining the resize to the viewport

resize: both lets users grow the <textarea> beyond the modal (and even viewport) width/height.
A small cap avoids layout break-outs on ultra-wide drags:

   resize: both;
+  max-width: 100%;
+  max-height: 80vh; /* keeps the box inside the visible viewport */
+  overflow: auto;

Keeping the element boxed-in improves usability on small screens and prevents horizontal scroll bars from appearing at the page level.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0c34e55 and 8705cc5.

📒 Files selected for processing (3)
  • changelogs/CHANGELOG_alpha.md (1 hunks)
  • src/components/Modal/Modal.scss (1 hunks)
  • src/components/TextInput/TextInput.scss (1 hunks)
🔇 Additional comments (2)
src/components/Modal/Modal.scss (1)

15-17: Add an upper bound to avoid off-screen modals

With width: auto the modal now grows with its content; a wide <textarea> can push it past the viewport.
Adding a max-width maintains the new flexibility while keeping the dialog fully visible:

   width: auto;
   min-width: 540px;
+  max-width: 90vw;

Also verify that the centering transform in @include modalAnimation() still compensates for the dynamic width—otherwise the modal’s left edge will drift right as it widens.

changelogs/CHANGELOG_alpha.md (1)

8-11: Changelog entry looks good

The note clearly documents the UI fix and matches the code change.

coderabbitai[bot]
coderabbitai bot previously approved these changes Jul 16, 2025
coderabbitai[bot]
coderabbitai bot previously approved these changes Jul 16, 2025
coderabbitai[bot]
coderabbitai bot previously approved these changes Jul 16, 2025
coderabbitai[bot]
coderabbitai bot previously approved these changes Jul 16, 2025
@mtrezza mtrezza changed the title fix: Allow freeform text view resizing feat: Allow freeform text view resizing in modal dialogs Jul 16, 2025
coderabbitai[bot]
coderabbitai bot previously approved these changes Jul 16, 2025
coderabbitai[bot]
coderabbitai bot previously approved these changes Jul 16, 2025
coderabbitai[bot]
coderabbitai bot previously approved these changes Jul 16, 2025
@mtrezza mtrezza linked an issue Jul 16, 2025 that may be closed by this pull request
3 tasks
@mtrezza mtrezza merged commit 1399162 into alpha Jul 16, 2025
11 checks passed
@mtrezza mtrezza deleted the codex/make-text-view-resizable-freeform branch July 16, 2025 23:39
parseplatformorg pushed a commit that referenced this pull request Jul 16, 2025
# [7.3.0-alpha.18](7.3.0-alpha.17...7.3.0-alpha.18) (2025-07-16)

### Features

* Allow freeform text view resizing in modal dialogs ([#2910](#2910)) ([1399162](1399162))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.3.0-alpha.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released-alpha Released as alpha version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow config parameter dialog to be resized in width
2 participants