-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: Allow freeform text view resizing in modal dialogs #2910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I will reformat the title to use the proper commit message syntax. |
The label |
Warning Rate limit exceeded@mtrezza has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 27 minutes and 28 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe changes adjust CSS styles in three component files. The modal's width is now flexible with a minimum constraint using a CSS variable, the text input can be resized both horizontally and vertically, and the field's left section is prevented from shrinking with fixed proportional width set via CSS variables. The Field.react.js component updates inline width style to a CSS custom property for label width ratio. Changes
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
🚀 Thanks for opening this pull request! |
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/components/TextInput/TextInput.scss (1)
19-20
: Consider constraining the resize to the viewport
resize: both
lets users grow the<textarea>
beyond the modal (and even viewport) width/height.
A small cap avoids layout break-outs on ultra-wide drags:resize: both; + max-width: 100%; + max-height: 80vh; /* keeps the box inside the visible viewport */ + overflow: auto;Keeping the element boxed-in improves usability on small screens and prevents horizontal scroll bars from appearing at the page level.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
changelogs/CHANGELOG_alpha.md
(1 hunks)src/components/Modal/Modal.scss
(1 hunks)src/components/TextInput/TextInput.scss
(1 hunks)
🔇 Additional comments (2)
src/components/Modal/Modal.scss (1)
15-17
: Add an upper bound to avoid off-screen modalsWith
width: auto
the modal now grows with its content; a wide<textarea>
can push it past the viewport.
Adding a max-width maintains the new flexibility while keeping the dialog fully visible:width: auto; min-width: 540px; + max-width: 90vw;
Also verify that the centering transform in
@include modalAnimation()
still compensates for the dynamic width—otherwise the modal’s left edge will drift right as it widens.changelogs/CHANGELOG_alpha.md (1)
8-11
: Changelog entry looks goodThe note clearly documents the UI fix and matches the code change.
# [7.3.0-alpha.18](7.3.0-alpha.17...7.3.0-alpha.18) (2025-07-16) ### Features * Allow freeform text view resizing in modal dialogs ([#2910](#2910)) ([1399162](1399162))
🎉 This change has been released in version 7.3.0-alpha.18 |
Summary
Testing
npm test
npm run lint
https://chatgpt.com/codex/tasks/task_e_6877e3a0583c832da0d111e2ba26b7a5
Summary by CodeRabbit