fix: Modal text input can be resized smaller than its cell in Safari browser #2930

mtrezza · 2025-07-19T21:29:04Z

Summary

allow TextInput to shrink after being enlarged

Testing

npm test

https://chatgpt.com/codex/tasks/task_e_687b44fd7a44832d9b5e0204057f841b

Summary by CodeRabbit

Style
- Improved text input responsiveness by adjusting minimum width and height using dynamic CSS variables.
- Enhanced label styling consistency by refining CSS variable application and removing fallback values for cleaner styling.
- Introduced a new CSS variable to standardize minimum row height across components.

parse-github-assistant · 2025-07-19T21:29:06Z

The label codex cannot be used here.

parse-github-assistant · 2025-07-19T21:29:09Z

I will reformat the title to use the proper commit message syntax.

coderabbitai · 2025-07-19T21:29:10Z

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The .text_input CSS class's min-width and min-height were changed from fixed values to dynamic values based on CSS variables. The CSS custom property --modal-label-ratio was moved from the inner left label container to the outer wrapping <div>. Fallback values for CSS variables were removed from .left class styles, and a new CSS variable --modal-row-min-height was introduced and used in .right.

Changes

File(s)	Change Summary
src/components/TextInput/TextInput.scss	Changed `.text_input` `min-width` and `min-height` to use CSS variables `--modal-min-width`, `--modal-label-ratio`, and `--modal-row-min-height` instead of fixed values
src/components/Field/Field.react.js	Moved CSS variable `--modal-label-ratio` from inline style on left label container to outer wrapping `<div>`
src/components/Field/Field.scss	Removed fallback values from `.left` width and max-width CSS variables; introduced `--modal-row-min-height` variable and used it for `.right` min-height

Possibly related PRs

feat: Allow freeform text view resizing in modal dialogs #2910: Modified handling of --modal-label-ratio and styling of .text_input and left label container, related to layout flexibility and consistency.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 26a602e and a542032.

📒 Files selected for processing (2)

src/components/Field/Field.scss (1 hunks)
src/components/TextInput/TextInput.scss (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai auto-generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

parse-github-assistant · 2025-07-19T21:29:12Z

🚀 Thanks for opening this pull request!

parseplatformorg · 2025-07-19T21:29:16Z

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

# [7.3.0-alpha.25](7.3.0-alpha.24...7.3.0-alpha.25) (2025-07-19) ### Bug Fixes * Modal text input can be resized smaller than its cell in Safari browser ([#2930](#2930)) ([82a0cdc](82a0cdc))

parseplatformorg · 2025-07-19T23:56:05Z

🎉 This change has been released in version 7.3.0-alpha.25

fix: TextInput cannot shrink after resize in Safari

757374c

mtrezza added the codex label Jul 19, 2025 — with ChatGPT Connector

parse-github-assistant bot removed the codex label Jul 19, 2025

parse-github-assistant bot changed the title ~~fix: text input cannot shrink after resize in Safari~~ fix: Text input cannot shrink after resize in Safari Jul 19, 2025

coderabbitai bot previously approved these changes Jul 19, 2025

View reviewed changes

fix: text input can shrink below modal width

67f9872

mtrezza dismissed coderabbitai[bot]’s stale review via 67f9872 July 19, 2025 21:45

fix: textarea resizable smaller than modal

26a602e

coderabbitai bot previously approved these changes Jul 19, 2025

View reviewed changes

fix

e6118cc

mtrezza dismissed coderabbitai[bot]’s stale review via e6118cc July 19, 2025 23:51

mtrezza changed the title ~~fix: Text input cannot shrink after resize in Safari~~ fix: Modal text input can be resized smaller than its cell in Safari browser Jul 19, 2025

Merge branch 'alpha' into codex/fix-textinput-resizing-issue-in-safari

a542032

mtrezza merged commit 82a0cdc into alpha Jul 19, 2025
10 of 11 checks passed

mtrezza deleted the codex/fix-textinput-resizing-issue-in-safari branch July 19, 2025 23:53

parseplatformorg added the state:released-alpha Released as alpha version label Jul 19, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: Modal text input can be resized smaller than its cell in Safari browser #2930

fix: Modal text input can be resized smaller than its cell in Safari browser #2930

Uh oh!

mtrezza commented Jul 19, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

parse-github-assistant bot commented Jul 19, 2025

Uh oh!

parse-github-assistant bot commented Jul 19, 2025

Uh oh!

coderabbitai bot commented Jul 19, 2025 •

edited

Loading

Review failed

Walkthrough

Changes

Possibly related PRs

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

parse-github-assistant bot commented Jul 19, 2025 •

edited

Loading

Uh oh!

parseplatformorg commented Jul 19, 2025 •

edited

Loading

Uh oh!

Uh oh!

parseplatformorg commented Jul 19, 2025

Uh oh!

Uh oh!

Uh oh!

fix: Modal text input can be resized smaller than its cell in Safari browser #2930

fix: Modal text input can be resized smaller than its cell in Safari browser #2930

Uh oh!

Conversation

mtrezza commented Jul 19, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Summary by CodeRabbit

Uh oh!

parse-github-assistant bot commented Jul 19, 2025

Uh oh!

parse-github-assistant bot commented Jul 19, 2025

Uh oh!

coderabbitai bot commented Jul 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Possibly related PRs

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

parse-github-assistant bot commented Jul 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parseplatformorg commented Jul 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎉 Snyk checks have passed. No issues have been found so far.

Uh oh!

Uh oh!

parseplatformorg commented Jul 19, 2025

Uh oh!

Uh oh!

mtrezza commented Jul 19, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 19, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

parse-github-assistant bot commented Jul 19, 2025 •

edited

Loading

parseplatformorg commented Jul 19, 2025 •

edited

Loading