Skip to content

fix: Race condition on info panel request shows info panel data not corresponding to selected cell #2909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 16, 2025
Merged

fix: Race condition on info panel request shows info panel data not corresponding to selected cell #2909

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4565aa8
fix: cancel pending AggregationPanel requests
mtrezza Jul 16, 2025
bd8ac30
fix: allow cancelling info panel requests
mtrezza Jul 16, 2025
685e11c
fix: cancel AggregationPanel requests
mtrezza Jul 16, 2025
7765962
fix: cancel stale info panel requests
mtrezza Jul 16, 2025
296b970
fix: cancel stale info panel queries
mtrezza Jul 16, 2025
d882c61
fix: cancel aggregation panel query
mtrezza Jul 16, 2025
ef1e63a
fix: allow selecting new cell while info panel loads
mtrezza Jul 16, 2025
35e1fe7
fix: cannot select new cell during info panel loading
mtrezza Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 33 additions & 2 deletions src/dashboard/Data/Browser/Browser.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,9 @@ class Browser extends DashboardView {
this.fetchAggregationPanelData = this.fetchAggregationPanelData.bind(this);
this.setAggregationPanelData = this.setAggregationPanelData.bind(this);

// Handle for the ongoing info panel cloud function request
this.currentInfoPanelQuery = null;

this.dataBrowserRef = React.createRef();

window.addEventListener('popstate', () => {
Expand Down Expand Up @@ -299,6 +302,10 @@ class Browser extends DashboardView {
if (this.currentQuery) {
this.currentQuery.cancel();
}
if (this.currentInfoPanelQuery) {
this.currentInfoPanelQuery.cancel?.();
this.currentInfoPanelQuery = null;
}
this.removeLocation();
window.removeEventListener('mouseup', this.onMouseUpRowCheckBox);
}
Expand Down Expand Up @@ -346,20 +353,37 @@ class Browser extends DashboardView {
}

fetchAggregationPanelData(objectId, className, appId) {
if (this.currentInfoPanelQuery) {
this.currentInfoPanelQuery.cancel?.();
this.currentInfoPanelQuery = null;
}

this.setState({
isLoadingInfoPanel: true,
});

const params = {
object: Parse.Object.extend(className).createWithoutData(objectId).toPointer(),
};
let requestTask;
const options = {
useMasterKey: true,
requestTask: task => {
requestTask = task;
},
};
const appName = this.props.params.appId;
const cloudCodeFunction =
this.state.classwiseCloudFunctions[`${appId}${appName}`]?.[className][0].cloudCodeFunction;
Parse.Cloud.run(cloudCodeFunction, params, options).then(

const promise = Parse.Cloud.run(cloudCodeFunction, params, options);
promise.cancel = () => requestTask?.abort();
this.currentInfoPanelQuery = promise;
promise.then(
result => {
if (this.currentInfoPanelQuery !== promise) {
return;
}
if (result && result.panel && result.panel && result.panel.segments) {
this.setState({ AggregationPanelData: result, isLoadingInfoPanel: false });
} else {
Expand All @@ -371,13 +395,20 @@ class Browser extends DashboardView {
}
},
error => {
if (this.currentInfoPanelQuery !== promise) {
return;
}
this.setState({
isLoadingInfoPanel: false,
errorAggregatedData: error.message,
});
this.showNote(this.state.errorAggregatedData, true);
}
);
).finally(() => {
if (this.currentInfoPanelQuery === promise) {
this.currentInfoPanelQuery = null;
}
});
}

setAggregationPanelData(data) {
Expand Down
Loading