fix: Race condition on info panel request shows info panel data not corresponding to selected cell #2909
Conversation
|
I will reformat the title to use the proper commit message syntax. |
parse-github-assistant
bot
changed the title
|
🚀 Thanks for opening this pull request! |
|
Warning Rate limit exceeded@mtrezza has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 19 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis change adds an instance variable Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Browser
participant CloudFunction
User->>Browser: Triggers fetchAggregationPanelData
Browser->>Browser: Abort previous currentInfoPanelQuery (if any)
Browser->>CloudFunction: Request aggregation panel data
Browser->>Browser: Store currentInfoPanelQuery (promise)
alt Response received (success or error)
CloudFunction-->>Browser: Responds to request
Browser->>Browser: Check if promise matches currentInfoPanelQuery
alt Promise matches
Browser->>Browser: Update state / Handle response
Browser->>Browser: Clear currentInfoPanelQuery
else Promise mismatch
Browser->>Browser: Ignore response
end
end
alt Component unmounts
Browser->>Browser: Abort currentInfoPanelQuery and clear reference
end
Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
The label |
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/dashboard/Data/Browser/Browser.react.js (2)
305-308: Consider using optional chaining for cleaner code.The cleanup logic is correct and prevents memory leaks. However, the conditional check can be simplified using optional chaining.
Apply this diff to use optional chaining:
- if (this.currentInfoPanelQuery && this.currentInfoPanelQuery.abort) { - this.currentInfoPanelQuery.abort(); - this.currentInfoPanelQuery = null; - } + this.currentInfoPanelQuery?.abort?.(); + this.currentInfoPanelQuery = null;
355-412: Well-implemented request cancellation with minor style improvements.The implementation correctly handles request cancellation and prevents race conditions. The promise identity checks ensure only the latest response updates the state, which is exactly what's needed.
Consider these optional improvements for consistency:
- Use optional chaining for the initial abort check:
- if (this.currentInfoPanelQuery && this.currentInfoPanelQuery.abort) { - this.currentInfoPanelQuery.abort(); - this.currentInfoPanelQuery = null; - } + this.currentInfoPanelQuery?.abort?.(); + this.currentInfoPanelQuery = null;
- Use optional chaining for the xhr abort call:
- promise.abort = () => xhr && xhr.abort(); + promise.abort = () => xhr?.abort?.();The current implementation is functionally correct, but these changes would improve consistency with modern JavaScript patterns.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/dashboard/Data/Browser/Browser.react.js(4 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: mtrezza
PR: parse-community/parse-dashboard#2828
File: src/dashboard/Data/Browser/Browser.react.js:1605-1607
Timestamp: 2025-05-27T12:09:47.644Z
Learning: In script execution dialogs in Parse Dashboard (specifically the `confirmExecuteScriptRows` method in `src/dashboard/Data/Browser/Browser.react.js`), individual `setState` calls to update `processedScripts` counter should be kept as-is rather than batched, because this provides real-time progress feedback to users in the dialog UI.
src/dashboard/Data/Browser/Browser.react.js (1)
Learnt from: mtrezza
PR: parse-community/parse-dashboard#2828
File: src/dashboard/Data/Browser/Browser.react.js:1605-1607
Timestamp: 2025-05-27T12:09:47.644Z
Learning: In script execution dialogs in Parse Dashboard (specifically the `confirmExecuteScriptRows` method in `src/dashboard/Data/Browser/Browser.react.js`), individual `setState` calls to update `processedScripts` counter should be kept as-is rather than batched, because this provides real-time progress feedback to users in the dialog UI.
🪛 Biome (1.9.4)
src/dashboard/Data/Browser/Browser.react.js
[error] 305-305: Change to an optional chain.
Unsafe fix: Change to an optional chain.
(lint/complexity/useOptionalChain)
[error] 356-356: Change to an optional chain.
Unsafe fix: Change to an optional chain.
(lint/complexity/useOptionalChain)
[error] 380-380: Change to an optional chain.
Unsafe fix: Change to an optional chain.
(lint/complexity/useOptionalChain)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Docker linux/amd64
🔇 Additional comments (1)
src/dashboard/Data/Browser/Browser.react.js (1)
266-268: LGTM - Good addition of request tracking.The instance variable is well-documented and follows a clear naming pattern for tracking ongoing requests.
mtrezza
changed the title
mtrezza
changed the title
mtrezza
changed the title
# [7.3.0-alpha.17](7.3.0-alpha.16...7.3.0-alpha.17) (2025-07-16) ### Bug Fixes * Race condition on info panel request shows info panel data not corresponding to selected cell ([#2909](#2909)) ([6f45bb3](6f45bb3))
|
🎉 This change has been released in version 7.3.0-alpha.17 |
Summary
Testing
npm test(fails: jest not found)https://chatgpt.com/codex/tasks/task_e_687799d62140832d979bd3889c8b218a
Summary by CodeRabbit