Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare patch releases #899

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Prepare patch releases #899

merged 1 commit into from
Feb 11, 2025

Conversation

serban300
Copy link
Contributor

@serban300 serban300 commented Feb 11, 2025 •
edited
Loading

Related to:

prepare:

  • bounded-collections 0.2.3
  • impl-codec 0.7.1

revert primitive-types version to 0.13.1 since #897 didn't introduce any change to it

@serban300 serban300 self-assigned this Feb 11, 2025
@serban300
Prepare patch releases
6367fd1 
prepare:
- bounded-collections 0.2.3
- impl-codec 0.7.1
@serban300 serban300 force-pushed the decode-with-mem-tracking branch from 9550c85 to 6367fd1 Compare February 11, 2025 11:23
@serban300 serban300 mentioned this pull request Feb 11, 2025
Open
@ordian
Copy link
Member

ordian commented Feb 11, 2025

revert primitive-types version to 0.13.1 since #897 didn't introduce any change to it

Not sure what you mean: https://github.com/paritytech/parity-common/pull/897/files#diff-644194b7e8fa32cd9256e7bc51dc80f24bce4494e3f2b767bb4156f39e4f5358

@ordian
Copy link
Member

ordian commented Feb 11, 2025

ah, impl-codec should've been bumped and updated in primitive-types then

ordian
ordian approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could still do the bump if we update impl-codec in primitive-types, but it works without. not sure what is the best DevEx for upstream users though

@ordian
Copy link
Member

ordian commented Feb 11, 2025

https://github.com/paritytech/parity-common/blob/master/CONTRIBUTING.md#releasing-a-new-version

@serban300
Copy link
Contributor Author

serban300 commented Feb 11, 2025 •
edited
Loading

we could still do the bump if we update impl-codec in primitive-types, but it works without. not sure what is the best DevEx for upstream users though

Also not sure what is the best strategy. Personally I would bump only bounded-collections and impl-codec for the moment since they are the only ones that changed.

I can bump primitive-types in a separate PR if needed.

@serban300 serban300 merged commit 4b20ddd into master Feb 11, 2025
6 checks passed
@serban300 serban300 deleted the decode-with-mem-tracking branch February 11, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ordian ordian ordian approved these changes

@bkchr bkchr bkchr approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

Assignees

@serban300 serban300

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serban300 @ordian @bkchr @niklasad1