Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DecodeWithMemTracking and DecodeWithMemLimit in polkadot-sdk #7360

Open
serban300 opened this issue Jan 28, 2025 · 3 comments
Open

Use DecodeWithMemTracking and DecodeWithMemLimit in polkadot-sdk #7360

serban300 opened this issue Jan 28, 2025 · 3 comments
Assignees
@serban300

Comments

@serban300
Copy link
Contributor

serban300 commented Jan 28, 2025 •
edited
Loading

In paritytech/parity-scale-codec#616 we added support for decoding with mem limit in parity-scale-codec.

We would like to use that for RuntimeCall and Block
@serban300 serban300 self-assigned this Jan 28, 2025
@serban300 serban300 moved this to In Progress in Bridges + XCM Jan 29, 2025
@serban300 serban300 mentioned this issue Feb 11, 2025
Merged
@serban300
Copy link
Contributor Author

serban300 commented Feb 11, 2025 •
edited
Loading

I will publish at most one weekly update from now on in order to make it easier to track the progress here. Also will delete some of the older comments for the same reason.

13th February 2025

@serban300 serban300 mentioned this issue Feb 12, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 12, 2025
@serban300
Update some dependencies (#7548)
af4c745 
Related to #7360

Update some dependencies needed for implementing
`DecodeWithMemTracking`:
`parity-scale-codec` -> 3.7.4
`finality-grandpa` -> 0.16.3
`bounded-collections` -> 0.2.3
`impl-codec` -> 0.7.1
@serban300 serban300 mentioned this issue Feb 18, 2025
Merged
@serban300
Copy link
Contributor Author

serban300 commented Feb 18, 2025 •
edited
Loading

20 February 2025 update:

Next: will work on the logic for adding a memory limit when decoding the RuntimeCall

github-merge-queue bot pushed a commit that referenced this issue Feb 18, 2025
@serban300
implement DecodeWithMemTracking for frame pallets (#7598)
67279ec 
Related to #7360

This PR implements `DecodeWithMemTracking` for the types in the frame
pallets

The PR is verbose, but it's very simple. `DecodeWithMemTracking` is
simply derived for most of the types. There are only 3 exceptions which
are isolated into 2 separate commits.
clangenb pushed a commit to clangenb/polkadot-sdk that referenced this issue Feb 19, 2025
@serban300 @clangenb
Update some dependencies (paritytech#7548)
9b02177 
Related to paritytech#7360

Update some dependencies needed for implementing
`DecodeWithMemTracking`:
`parity-scale-codec` -> 3.7.4
`finality-grandpa` -> 0.16.3
`bounded-collections` -> 0.2.3
`impl-codec` -> 0.7.1
clangenb pushed a commit to clangenb/polkadot-sdk that referenced this issue Feb 19, 2025
@serban300 @clangenb
implement DecodeWithMemTracking for frame pallets (paritytech#7598)
322ffee 
Related to paritytech#7360

This PR implements `DecodeWithMemTracking` for the types in the frame
pallets

The PR is verbose, but it's very simple. `DecodeWithMemTracking` is
simply derived for most of the types. There are only 3 exceptions which
are isolated into 2 separate commits.
This was referenced Feb 19, 2025
Merged
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 19, 2025
@serban300
Derive DecodeWithMemTracking for cumulus pallets and for `polkadot-…
d60afc9 
…sdk` runtimes (#7627)

Related to #7360

Derive `DecodeWithMemTracking` for the structures in the cumulus pallets
and for the structures in the `polkadot-sdk` runtimes.

The PR contains no functional changes and no manual implementation. Just
deriving `DecodeWithMemTracking`.
@serban300 serban300 mentioned this issue Feb 19, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 20, 2025
@serban300
derive DecodeWithMemTracking for RuntimeCall (#7634)
e8d17cb 
Related to #7360
@serban300 serban300 changed the title Implement DecodeWithMemTracking for RuntimeCall Use DecodeWithMemTracking and DecodeWithMemLimit in polkadot-sdk Feb 21, 2025
@serban300 serban300 mentioned this issue Feb 21, 2025
Open
@serban300
Copy link
Contributor Author

27 February 2025 update:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@serban300 serban300

Labels
None yet
Projects
Bridges + XCM
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@serban300