Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: increase Go version #1335

Merged
merged 3 commits into from
Jan 27, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v4
with:
go-version: '1.22'
go-version: '1.23.5'
cache: false
- name: Go lint
uses: golangci/golangci-lint-action@v6
with:
version: v1.59.1
version: v1.63.4
args: --verbose
# Optional: if set to true then the all caching functionality will be complete disabled,
# takes precedence over all other caching options.
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.23.5'
# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@v3
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ jobs:
release:
permissions:
contents: write # for goreleaser/goreleaser-action to create a GitHub release
runs-on: ubuntu-latest
runs-on: ubuntu-22.04 # stick with older LTS release for continued debian support
steps:
- uses: actions/checkout@v4
- name: Install Go
uses: actions/setup-go@v4
with:
go-version: '1.22.2'
go-version: '1.23.5'
- name: Unshallow
run: git fetch --prune --unshallow
- name: Create release
Expand Down
3 changes: 2 additions & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
run:
go: '1.22'
go: '1.23.5'
issues-exit-code: 1
timeout: 10m
modules-download-mode: readonly
Expand Down Expand Up @@ -39,3 +39,4 @@ issues:
- G101 # Potential hardcoded credentials
- G114 # Use of net/http serve function that has no support for setting timeouts
- G113 # Potential uncontrolled memory consumption in Rat.SetString - this is fixed since go 1.17.7
- G115 # We do this everywhere (I suppose if it overflows, at least it will for everyone...)
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
###########################
#### Base image ####
###########################
FROM golang:1.22-buster AS base
FROM golang:1.23-buster AS base

# TODO add non-root user
LABEL org.opencontainers.image.authors="[email protected]"
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ TM_VERSION := $(shell go list -m github.com/cometbft/cometbft | sed 's
DOCKER := $(shell which docker)
PROJECT_NAME := paloma
HTTPS_GIT := https://github.com/palomachain/paloma.git
GOLANGCILINT_VERSION := 1.51.2
GOLANGCILINT_VERSION := 1.63.4

###############################################################################
## Version ##
Expand Down
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,9 @@ sudo chmod +x /usr/local/bin/palomad

### To build palomad using latest release

> [!IMPORTANT]
> Always make sure you're building against the latest released version of Go.

```shell
git clone https://github.com/palomachain/paloma.git
cd paloma
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/palomachain/paloma/v2

go 1.22.2
go 1.23.5

require (
cosmossdk.io/errors v1.0.1
Expand Down
Binary file modified third_party/golangci-lint
Binary file not shown.
Loading