ci: upgrade golint-ci

palomachain · byte-bandit · Jan 27, 2025 · Jan 27, 2025 · Jan 27, 2025 · Jan 27, 2025
commit 5c6934061df9181656277bb5f01ce2c964013582
diff --git a/.github/workflows/ci-test.yml b/.github/workflows/ci-test.yml
@@ -30,7 +30,7 @@ jobs:
       - name: Go lint
         uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.59.1
+          version: v1.63.4
           args: --verbose
           # Optional: if set to true then the all caching functionality will be complete disabled,
           #           takes precedence over all other caching options.

diff --git a/Makefile b/Makefile
@@ -9,7 +9,7 @@ TM_VERSION           := $(shell go list -m github.com/cometbft/cometbft | sed 's
 DOCKER               := $(shell which docker)
 PROJECT_NAME         := paloma
 HTTPS_GIT            := https://github.com/palomachain/paloma.git
-GOLANGCILINT_VERSION := 1.51.2
+GOLANGCILINT_VERSION := 1.63.4
 
 ###############################################################################
 ##                                  Version                                  ##

diff --git a/third_party/golangci-lint b/third_party/golangci-lint
diff --git a/testutil/rand/random.go b/testutil/rand/random.go
 	if err != nil {
 		panic(err)
 	}
 	if uint(n) != length {
 		panic("didn't read all bytes")
 	}
 	return res
diff --git a/x/valset/keeper/keep_alive.go b/x/valset/keeper/keep_alive.go
 		if _, found := lookup[string(v)]; !found {
 			// Looks like there's a new unjailed validator. Let's give them
 			// some time before considering jailing them again.
 			gs.Set(v, sdk.Uint64ToBigEndian(uint64(sdkCtx.BlockHeight())))
 		}
 	}

 	sdkCtx := sdk.UnwrapSDKContext(ctx)
 	store := k.gracePeriodStore(ctx)
 	bytes := store.Get(valAddr)
 	return libvalid.NotNil(bytes) && sdkCtx.BlockHeight()-int64(sdk.BigEndianToUint64(bytes)) <= cJailingGracePeriodBlockHeight
 }

 func (k Keeper) keepAliveStore(ctx context.Context) storetypes.KVStore {
diff --git a/x/valset/client/cli/query_get_snapshot_by_id.go b/x/valset/client/cli/query_get_snapshot_by_id.go

 			queryClient := types.NewQueryClient(clientCtx)

 			id := uint64(whoops.Must(strconv.Atoi(reqSnapshotId)))
 			params := &types.QueryGetSnapshotByIDRequest{
 				SnapshotId: id,
 			}
diff --git a/x/valset/gov_handler.go b/x/valset/gov_handler.go
 		case *types.SetPigeonRequirementsProposal:
 			targetBlockHeight := c.GetTargetBlockHeight()

 			if ctx.BlockHeight() >= int64(targetBlockHeight) {
 				// If the we're already past the target block height, we apply
 				// the requirements immediately. This is also true if the
 				// proposal does not contain a target block height.
diff --git a/x/valset/module.go b/x/valset/module.go
 		return nil
 	}

 	if reqs != nil && int64(reqs.TargetBlockHeight) <= sdkCtx.BlockHeight() {
 		err = am.keeper.SetPigeonRequirements(ctx, reqs.Requirements)
 		if err != nil {
 			logger.WithError(err).Error("error setting pigeon requirements")
diff --git a/x/evm/types/eth_txable.go b/x/evm/types/eth_txable.go
 				Payload:              m.GetPayload(),
 			},
 			feeArgs,
 			new(big.Int).SetInt64(int64(msg.GetId())),
 			new(big.Int).SetInt64(m.GetDeadline()),
 			common.HexToAddress(relayer),
 		}
 			common.HexToAddress(m.GetDeployerAddress()),
 			m.GetBytecode(),
 			feeArgs,
 			new(big.Int).SetInt64(int64(msg.GetId())),
 			new(big.Int).SetInt64(m.GetDeadline()),
 			common.HexToAddress(relayer),
 		}
diff --git a/x/evm/types/turnstone_abi.go b/x/evm/types/turnstone_abi.go
 			return common.HexToAddress(s)
 		}),
 		slice.Map(m.GetValset().GetPowers(), func(a uint64) *big.Int {
 			return big.NewInt(int64(a))
 		}),
 		big.NewInt(int64(m.GetValset().GetValsetID())),
 		bytes32,
 	)
 	if err != nil {
	if err != nil {
	panic(err)
	}
	if uint(n) != length {
Check failure on line 19 in testutil/rand/random.go GitHub Actions / Running linters `G115: integer overflow conversion int -> uint (gosec)`
	panic("didn't read all bytes")
	}
	return res
	if _, found := lookup[string(v)]; !found {
	// Looks like there's a new unjailed validator. Let's give them
	// some time before considering jailing them again.
	gs.Set(v, sdk.Uint64ToBigEndian(uint64(sdkCtx.BlockHeight())))
Check failure on line 155 in x/valset/keeper/keep_alive.go GitHub Actions / Running linters `G115: integer overflow conversion int64 -> uint64 (gosec)`
	}
	}

	sdkCtx := sdk.UnwrapSDKContext(ctx)
	store := k.gracePeriodStore(ctx)
	bytes := store.Get(valAddr)
	return libvalid.NotNil(bytes) && sdkCtx.BlockHeight()-int64(sdk.BigEndianToUint64(bytes)) <= cJailingGracePeriodBlockHeight
Check failure on line 210 in x/valset/keeper/keep_alive.go GitHub Actions / Running linters `G115: integer overflow conversion uint64 -> int64 (gosec)`
	}

	func (k Keeper) keepAliveStore(ctx context.Context) storetypes.KVStore {

	queryClient := types.NewQueryClient(clientCtx)

	id := uint64(whoops.Must(strconv.Atoi(reqSnapshotId)))
Check failure on line 30 in x/valset/client/cli/query_get_snapshot_by_id.go GitHub Actions / Running linters `G115: integer overflow conversion int -> uint64 (gosec)`
	params := &types.QueryGetSnapshotByIDRequest{
	SnapshotId: id,
	}
	case *types.SetPigeonRequirementsProposal:
	targetBlockHeight := c.GetTargetBlockHeight()

	if ctx.BlockHeight() >= int64(targetBlockHeight) {
Check failure on line 17 in x/valset/gov_handler.go GitHub Actions / Running linters `G115: integer overflow conversion uint64 -> int64 (gosec)`
	// If the we're already past the target block height, we apply
	// the requirements immediately. This is also true if the
	// proposal does not contain a target block height.
	return nil
	}

	if reqs != nil && int64(reqs.TargetBlockHeight) <= sdkCtx.BlockHeight() {
Check failure on line 189 in x/valset/module.go GitHub Actions / Running linters `G115: integer overflow conversion uint64 -> int64 (gosec)`
	err = am.keeper.SetPigeonRequirements(ctx, reqs.Requirements)
	if err != nil {
	logger.WithError(err).Error("error setting pigeon requirements")
	Payload: m.GetPayload(),
	},
	feeArgs,
	new(big.Int).SetInt64(int64(msg.GetId())),
Check failure on line 119 in x/evm/types/eth_txable.go GitHub Actions / Running linters `G115: integer overflow conversion uint64 -> int64 (gosec)`
	new(big.Int).SetInt64(m.GetDeadline()),
	common.HexToAddress(relayer),
	}
	common.HexToAddress(m.GetDeployerAddress()),
	m.GetBytecode(),
	feeArgs,
	new(big.Int).SetInt64(int64(msg.GetId())),
Check failure on line 298 in x/evm/types/eth_txable.go GitHub Actions / Running linters `G115: integer overflow conversion uint64 -> int64 (gosec)`
	new(big.Int).SetInt64(m.GetDeadline()),
	common.HexToAddress(relayer),
	}
	return common.HexToAddress(s)
	}),
	slice.Map(m.GetValset().GetPowers(), func(a uint64) *big.Int {
	return big.NewInt(int64(a))
Check failure on line 86 in x/evm/types/turnstone_abi.go GitHub Actions / Running linters `G115: integer overflow conversion uint64 -> int64 (gosec)`
	}),
	big.NewInt(int64(m.GetValset().GetValsetID())),
Check failure on line 88 in x/evm/types/turnstone_abi.go GitHub Actions / Running linters `G115: integer overflow conversion uint64 -> int64 (gosec)`
	bytes32,
	)
	if err != nil {