Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using /**/ to signal blank lines #632

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Stop using /**/ to signal blank lines #632

merged 2 commits into from
Sep 10, 2024

Commits on Sep 6, 2024

  1. Stop using /**/ to signal blank lines 

    In-band signaling is evil :)

The original idea behind /**/ was that it was difficult to control when
the coder generated a blank line, so we told the reindenter to delete
all blank lines unless they were specially marked with /**/. However,
it turns out that it's not too difficult to avoid unwanted blank lines.
The main problem used to be situations where we did a table.concat("\n")
where some elements in the list already have a newline. The fix is the
`concat_lines` function, which removes said newlines before we concat.
    @hugomg
    hugomg committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    3a00ae9 View commit details
    Browse the repository at this point in the history

  2. More beautifications 

    - Pay attention to blank lines
- Check USHRT_MAX at Pallene compile-time instead of C compile-time.
    @hugomg
    hugomg committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    0e05eb3 View commit details
    Browse the repository at this point in the history