Stop using /**/ to signal blank lines #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In-band signaling is evil :)
The original idea behind /**/ was that it was difficult to control when
the coder generated a blank line, so we told the reindenter to delete
all blank lines unless they were specially marked with /**/. However,
it turns out that it's not too difficult to avoid unwanted blank lines.
The main problem used to be situations where we did a table.concat("\n")
where some elements in the list already have a newline. The fix is the
`concat_lines` function, which removes said newlines before we concat.
- Pay attention to blank lines - Check USHRT_MAX at Pallene compile-time instead of C compile-time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In-band signaling is evil :)
The original idea behind
/**/was that it was difficult to control when the coder generated a blank line, so we told the reindenter to delete all blank lines unless they were specially marked with/**/. However, it turns out that it's not too difficult to avoid unwanted blank lines. The main problem used to be situations where we did a table.concat("\n") where some elements in the list already have a newline. The fix is theconcat_linesfunction, which removes said newlines before we concat.