Remove DirectoryFrontend #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daym
force-pushed
the
issue-8
branch
3 times, most recently
from
6eda4d6 to
4e23950
Compare
dancrossnyc
reviewed
Aug 12, 2022
dancrossnyc
reviewed
Aug 12, 2022
| Self::DirectoryRelativeOffset(x) => write!(fmt, "DirectoryRelativeOffset({:#x?})", x), | ||
| Self::EntryRelativeOffset(x) => write!(fmt, "EntryRelativeOffset({:#x?})", x), | ||
| Self::PhysicalAddress(x) => { | ||
| write!(fmt, "PhysicalAddress({:#x?})", x) |
There was a problem hiding this comment.
Can you write this as, write!(fmt, "PhysicalAddress({x:#x?})") ?
There was a problem hiding this comment.
Yeah, but I don't like magical string literal interpolation so much. Now one even has to be careful what to put in string literals, and scan it for variables to see whether those are in use? Not a fan.
And I say that as an IntelliJ IDEA user--in there, it's actually no problem.
dancrossnyc
reviewed
Aug 12, 2022
dancrossnyc
reviewed
Aug 12, 2022
dancrossnyc
reviewed
Aug 12, 2022
dancrossnyc
reviewed
Aug 12, 2022
dancrossnyc
reviewed
Aug 12, 2022
dancrossnyc
reviewed
Aug 12, 2022
Fixes <#8>.
dancrossnyc
reviewed
Aug 13, 2022
dancrossnyc
reviewed
Aug 13, 2022
dancrossnyc
reviewed
Aug 13, 2022
dancrossnyc
reviewed
Aug 13, 2022
dancrossnyc
approved these changes
Aug 13, 2022
This was referenced Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #8.
Note: Depends on #19 and was branched off that.