Skip to content

field name type_ used instead of type #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
daym opened this issue Aug 16, 2022 · 2 comments
Open

field name type_ used instead of type #22

daym opened this issue Aug 16, 2022 · 2 comments
Assignees
@daym

Comments

@daym
Copy link
Collaborator

daym commented Aug 16, 2022

because type is a keyword

This is for type_? If it helps, I've always written that as typ or dir_type or something.

Originally posted by @dancrossnyc in #20 (comment)
@daym
Copy link
Collaborator Author

daym commented Aug 16, 2022

Also concerns amd-apcb

@daym
Copy link
Collaborator Author

daym commented Aug 16, 2022 •
edited
Loading

A lot of #[allow(non_snake_case)] in amd-efs are just because of that. Also, the getter is type_() instead of type() as well.

@daym daym self-assigned this Aug 16, 2022
@daym daym mentioned this issue Aug 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daym daym

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daym