Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] Add tests for zero-byte file upload on spaces #10697

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented Dec 2, 2024

Description

In this PR, there is an added bug coverage test. Following scenarios are added for upload via TUS and webdav api:

- Scenario: public uploads a zero byte file to a public share folder
- Scenario: public uploads a zero byte file to a public share folder inside project space
- Scenario: public uploads a zero byte file to a public share project space

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • CI
  • locally
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nabim777 nabim777 self-assigned this Dec 2, 2024
@nabim777 nabim777 force-pushed the tests/zero-byte-upload branch 2 times, most recently from ac4f914 to 84fc885 Compare December 9, 2024 09:33
@nabim777 nabim777 changed the title [tests-only] Add tests for zero-byte file upload on spaces [tests-only] [full-ci] Add tests for zero-byte file upload on spaces Dec 9, 2024
@nabim777 nabim777 changed the title [tests-only] [full-ci] Add tests for zero-byte file upload on spaces [tests-only][full-ci] Add tests for zero-byte file upload on spaces Dec 9, 2024
@nabim777 nabim777 marked this pull request as ready for review December 9, 2024 10:41
@nabim777 nabim777 force-pushed the tests/zero-byte-upload branch 3 times, most recently from 94e35c9 to c496f3e Compare December 10, 2024 04:02
@nabim777 nabim777 force-pushed the tests/zero-byte-upload branch 2 times, most recently from e4591b7 to 2a5d18e Compare December 10, 2024 08:18
@nabim777 nabim777 requested a review from S-Panta December 10, 2024 08:19
@nabim777 nabim777 force-pushed the tests/zero-byte-upload branch from 2a5d18e to 3b4a444 Compare December 10, 2024 08:22
@nabim777 nabim777 force-pushed the tests/zero-byte-upload branch from 3b4a444 to fc2784b Compare December 10, 2024 09:37
@nabim777 nabim777 enabled auto-merge December 10, 2024 09:53
@nabim777 nabim777 disabled auto-merge December 10, 2024 09:54
@nabim777 nabim777 force-pushed the tests/zero-byte-upload branch from fc2784b to 03d9a2b Compare December 10, 2024 10:07
@nabim777 nabim777 force-pushed the tests/zero-byte-upload branch from 03d9a2b to 96f1a27 Compare December 12, 2024 06:32
@nabim777
Copy link
Member Author

nabim777 commented Dec 12, 2024

Scenario: public uploads a zero byte file to a public share folder

Since existing test uses the TUS library and is unable to get and check the response.
So, there is no check for the location header on TUS upload.
Will be done in another separate PR.

Copy link

sonarcloud bot commented Dec 12, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants