add scenario in expected failure

Signed-off-by: nabim777 <[email protected]>
owncloud · Dec 12, 2024 · 96f1a27 · 96f1a27
1 parent 286277f
commit 96f1a27
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 16 deletions.
diff --git a/tests/acceptance/bootstrap/TUSContext.php b/tests/acceptance/bootstrap/TUSContext.php
@@ -335,14 +335,14 @@ public function uploadFileUsingTus(
 	/**
 	 * @param string $source
 	 * @param string $destination
-	 * @param string|null $password
+	 * @param string $password
 	 *
 	 * @return void
 	 */
 	public function publicUploadFileUsingTus(
 		string  $source,
 		string  $destination,
-		?string $password,
+		string $password,
 	):void {
 		$password = $this->featureContext->getActualPassword($password);
 		if ($this->featureContext->isUsingSharingNG()) {

diff --git a/tests/acceptance/expected-failures-without-remotephp.md b/tests/acceptance/expected-failures-without-remotephp.md
@@ -195,6 +195,12 @@
 - [apiSpaces/publicLink.feature:28](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpaces/publicLink.feature#L28)
 - [apiSpaces/publicLink.feature:34](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpaces/publicLink.feature#L34)
 - [apiSpaces/publicLink.feature:40](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpaces/publicLink.feature#L40)
+- [apiSpaces/uploadSpaces.feature:98](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpaces/uploadSpaces.feature#L98)
+- [apiSpaces/uploadSpaces.feature:114](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpaces/uploadSpaces.feature#L114)
+- [apiSpaces/uploadSpaces.feature:130](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpaces/uploadSpaces.feature#L130)
+- [apiSpacesShares/shareUploadTUS.feature:407](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpacesShares/shareUploadTUS.feature#L407)
+- [apiSpacesShares/shareUploadTUS.feature:422](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpacesShares/shareUploadTUS.feature#L422)
+- [apiSpacesShares/shareUploadTUS.feature:439](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpacesShares/shareUploadTUS.feature#L439)
 - [apiSpacesShares/shareSpacesViaLink.feature:61](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpacesShares/shareSpacesViaLink.feature#L61)
 - [apiDepthInfinity/propfind.feature:74](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiDepthInfinity/propfind.feature#L74)
 - [apiDepthInfinity/propfind.feature:124](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiDepthInfinity/propfind.feature#L124)

diff --git a/tests/acceptance/features/apiSpaces/uploadSpaces.feature b/tests/acceptance/features/apiSpaces/uploadSpaces.feature
@@ -94,7 +94,7 @@ Feature: Upload files into a space
       | foo/bar     |
       | foo/bar/baz |
 
-  @issue-10649
+  @issue-10331 @issue-10469
   Scenario: public uploads a zero byte file to a public share folder
     Given using SharingNG
     And user "Alice" has created folder "/uploadFolder"
@@ -110,29 +110,29 @@ Feature: Upload files into a space
     And for user "Alice" folder "uploadFolder" of the space "Personal" should not contain these files:
       | textfile (1).txt |
 
-  @issue-10649
+  @issue-10331 @issue-10469
   Scenario: public uploads a zero byte file to a public share folder inside project space
     Given using SharingNG
     And user "Alice" has created a folder "/uploadFolder" in space "Project Ceres"
     And user "Alice" has created the following resource link share:
-      | resource        | uploadFolder |
-      | space           | Project Ceres     |
-      | permissionsRole | createOnly   |
-      | password        | %public%     |
+      | resource        | uploadFolder  |
+      | space           | Project Ceres |
+      | permissionsRole | createOnly    |
+      | password        | %public%      |
     When the public uploads file "filesForUpload/zerobyte.txt" to "textfile.txt" inside last link shared folder with password "%public%" using the public WebDAV API
     Then the HTTP status code should be "201"
     And for user "Alice" folder "uploadFolder" of the space "Project Ceres" should contain these files:
       | textfile.txt |
     And for user "Alice" folder "uploadFolder" of the space "Project Ceres" should not contain these files:
       | textfile (1).txt |
 
-  @issue-10649
+  @issue-10331 @issue-10469
   Scenario: public uploads a zero byte file to a public share project space
     Given using SharingNG
     And user "Alice" has created the following space link share:
-      | space           | Project Ceres  |
-      | permissionsRole | createOnly     |
-      | password        | %public% |
+      | space           | Project Ceres |
+      | permissionsRole | createOnly    |
+      | password        | %public%      |
     When the public uploads file "filesForUpload/zerobyte.txt" to "textfile.txt" inside last link shared folder with password "%public%" using the public WebDAV API
     Then the HTTP status code should be "201"
     And for user "Alice" the space "Project Ceres" should contain these files:

diff --git a/tests/acceptance/features/apiSpacesShares/shareUploadTUS.feature b/tests/acceptance/features/apiSpacesShares/shareUploadTUS.feature
@@ -403,7 +403,7 @@ Feature: upload resources on share using TUS protocol
     Then the HTTP status code should be "460"
     And for user "Alice" the content of the file "/textFile.txt" of the space "Personal" should be "original content"
 
-  @issue-10649
+  @issue-10331 @issue-10469
   Scenario: public uploads a zero byte file to a public share folder
     Given using SharingNG
     And user "Alice" has created folder "/uploadFolder"
@@ -418,15 +418,15 @@ Feature: upload resources on share using TUS protocol
     And for user "Alice" folder "uploadFolder" of the space "Personal" should not contain these files:
       | textfile (1).txt |
 
-  @issue-10649
+  @issue-10331 @issue-10469
   Scenario: public uploads a zero-byte file to a shared folder inside project space
     Given using SharingNG
     And the administrator has assigned the role "Space Admin" to user "Alice" using the Graph API
     And user "Alice" has created a space "Project" with the default quota using the Graph API
     And user "Alice" has created a folder "/uploadFolder" in space "Project"
     And user "Alice" has created the following resource link share:
       | resource        | uploadFolder |
-      | space           | Project     |
+      | space           | Project      |
       | permissionsRole | createOnly   |
       | password        | %public%     |
     When the public uploads a file from "filesForUpload/zerobyte.txt" to "textfile.txt" via TUS inside last link shared folder with password "%public%" using the WebDAV API
@@ -435,7 +435,7 @@ Feature: upload resources on share using TUS protocol
     And for user "Alice" folder "uploadFolder" of the space "Project" should not contain these files:
       | textfile (1).txt |
 
-  @issue-10649
+  @issue-10331 @issue-10469
   Scenario: public uploads a zero-byte file to a public share project space
     Given using SharingNG
     And the administrator has assigned the role "Space Admin" to user "Alice" using the Graph API