Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 (grapher) turn related questions into an object / TAS-676 #4108

Closed
wants to merge 2 commits into from

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Nov 4, 2024

Important

Merge owid/etl#3491 when merging this PR

Applies a breaking change to the Grapher config schema by migrating the relatedQuestions array to a relatedQuestion object. We only show the first related question and we don't want to add support for multiple related question in the future.

The SVG tester differences are due to a parent PR.

@owidbot
Copy link
Contributor

owidbot commented Nov 4, 2024

Quick links (staging server):

Site Admin Wizard Docs

Login: ssh owid@staging-site-relation-question

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-11-11 17:15:56 UTC
Execution time: 1.36 seconds

Copy link
Contributor

@danyx23 danyx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@sophiamersmann sophiamersmann changed the title 🔨 (grapher) turn related questions into an object 🔨 (grapher) turn related questions into an object / TAS-676 Nov 11, 2024
Copy link

Base automatically changed from remove-default-layer to master November 19, 2024 15:50
Copy link

github-actions bot commented Dec 4, 2024

This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected.

@github-actions github-actions bot added the stale label Dec 4, 2024
@github-actions github-actions bot closed this Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants