Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 grapher schema: update to version 006 #3491

Closed
wants to merge 1 commit into from

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Nov 4, 2024

Sibling PR of owid/owid-grapher#4108 that introduces a breaking change to the Grapher config schema (the relatedQuestions array is migrated to a relatedQuestion object).

@owidbot
Copy link
Contributor

owidbot commented Nov 4, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-update-grapher-schema-006

chart-diff: ✅ No charts for review.
data-diff: ✅ No differences found
Legend: +New  ~Modified  -Removed  =Identical  Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet

Automatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included

Edited: 2024-11-20 10:36:44 UTC
Execution time: 3.94 seconds

Copy link
Collaborator

@Marigold Marigold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lucasrodes lucasrodes changed the title 🔨 update grapher schema version to 006 🔨 grapher schema: update to version 006 Nov 13, 2024
@lucasrodes
Copy link
Member

This conflicts with later changes in master, which were made by merging #3558 (only two files though).

This PR proposes to use https://files.ourworldindata.org/schemas/grapher-schema.006.json, but currently master points to https://files.ourworldindata.org/schemas/grapher-schema.latest.json for some files (not all).

@sophiamersmann Could you look into the conflict and decide whether we should point to one or the other?

@sophiamersmann
Copy link
Member Author

sophiamersmann commented Dec 12, 2024

I'll close this PR because it's outdated and I probably won't merge it anytime soon.

As for your question: If the schema file was referred to in a comment, I replaced it with the latest version, so that we don't have to update those instances when the schema version is bumped. Using the fixed schema version is of course also fine though – it doesn't matter much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants