-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Explorers in the Data Catalog #4100
🎉 Explorers in the Data Catalog #4100
Conversation
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-11-01 00:27:06 UTC |
27b84f1
to
caba23c
Compare
830267f
to
9c8d313
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work here, ike!
I left a few small comments here and there, but overall this seems great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this is really nicely done! And, also, a lot of effort!
9c8d313
to
7b805bf
Compare
caba23c
to
493a5e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good now, except for that you're getting an import error
9109052
to
d83c236
Compare
493a5e3
to
1a0110b
Compare
d83c236
to
c510e3c
Compare
1a0110b
to
3d61b31
Compare
This became a much larger refactor than I thought it would, but I couldn't in good conscience add a bunch of forks to the already large
indexExplorerViewsToAlgolia
script without composing things a little more sensibly.Changes
baker/algolia/utils/charts.ts
andbaker/algolia/indexChartsToAlgola.ts
)explorerViews.ts
and go up from thereindexExplorerViewsAndCharts
script/index which uses theChartHit
interface (plus a new "type" enum)