✨ explorer thumbnails code review touchups

owid · Nov 8, 2024 · 3d61b31 · 3d61b31
1 parent ab0149f
commit 3d61b31
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 89 deletions.
diff --git a/functions/_common/grapherTools.ts b/functions/_common/grapherTools.ts
@@ -180,5 +180,5 @@ export function rewriteMetaTags(
             },
         })
 
-    return rewriter.transform(page as unknown as Response)
+    return rewriter.transform(page)
 }
diff --git a/functions/explorers/[slug].ts b/functions/explorers/[slug].ts
@@ -62,6 +62,7 @@ async function handleThumbnailRequest(
     try {
         const html = await explorerPage.text()
         const queryStr = url.searchParams.toString()
+        // The env URL class isn't compatible with the Url class from @ourworldindata/utils
         const urlObj = Url.fromURL(url.toString())
         const [windowEntityNames] = [urlObj]
             .map(migrateSelectedEntityNamesParam)

diff --git a/packages/@ourworldindata/explorer/readme.md b/packages/@ourworldindata/explorer/readme.md
-Original file line number
+Diff line change
@@ Expand Up / @@ -180,5 +180,5 @@ export function rewriteMetaTags( @@
                 },
             })
-        return rewriter.transform(page as unknown as Response)
+        return rewriter.transform(page)
     }