Don't have the comment include an NA docx link#17
Merged
carriewright11 merged 7 commits intocansavvy/no-docxfrom Jun 17, 2025
Merged
Don't have the comment include an NA docx link#17carriewright11 merged 7 commits intocansavvy/no-docxfrom
carriewright11 merged 7 commits intocansavvy/no-docxfrom
Conversation
Updating the action to suppress the docx part of the comment if there is no docx file
point to branch for this stacked PR for testing
kweav
changed the title
move back to branch I want to merge into since tests won't run on stacked right now
Contributor
Author
|
Tested over here: fhdsl/reproducibility_capstone#12 |
carriewright11
approved these changes
Jun 17, 2025
Contributor
carriewright11
left a comment
carriewright11
left a comment
There was a problem hiding this comment.
This works for now! thanks, @kweav !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the action fix in PR #14 to suppress the docx part of the comment if there is no docx file, rather than having a URL with "NA" in it displayed in the comment.
This is a little less DRY, but perhaps we can use a comment template to get around that if it's a concern?