Don't fail when there's no docx file#14
Merged
carriewright11 merged 20 commits intomainfrom Jun 17, 2025
Merged
Conversation
|
Re-rendered previews from the latest commit:
* note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea. Updated at 2025-06-17 with changes from the latest commit 3afd1ad |
Contributor
|
I think related is issue #8 -- is it possible to just not include the docx file link as part of the comment if there is no docx file? |
acoffman
reviewed
Jun 9, 2025
kweav
reviewed
Jun 11, 2025
avahoffman
reviewed
Jun 13, 2025
Updating the action to suppress the docx part of the comment if there is no docx file
point to branch for this stacked PR for testing
move back to branch I want to merge into since tests won't run on stacked right now
Contributor
Committing this so it doesn't get lost and to incorporate Adam's review
Don't have the comment include an NA docx link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sometimes people don't want to create a docx file -- sometimes there isn't one yet. This shouldn't be a reason to halt everything.
But this is what was happening over here: https://github.com/fhdsl/reproducibility_capstone/actions/runs/15498275456
I think this should address that? It will provide a broken link and probably more ideally it should just not print out the docx link at all -- but I don't have time to implement all that right now. But this is a start.