Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: More signatures #5511

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

okurz
Copy link
Member

@okurz okurz commented Mar 14, 2024

  • Simplify Resource::Locks with direct return of boolean calculations
  • Use signatures in Resource::Locks
  • Slightly simplify script/openqa-validate-yaml
  • Use signatures in WebAPI::ServerSideDataTable
  • Use signatures in Resource::Jobs

@okurz okurz marked this pull request as draft March 14, 2024 08:49
@okurz okurz force-pushed the feature/style_warnings_strict_base_signatures branch from 7126762 to e343040 Compare March 14, 2024 08:49
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.39%. Comparing base (1a01d2d) to head (b295d47).
Report is 771 commits behind head on master.

Files with missing lines Patch % Lines
script/openqa-validate-yaml 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5511   +/-   ##
=======================================
  Coverage   98.38%   98.39%           
=======================================
  Files         391      391           
  Lines       37883    37874    -9     
=======================================
- Hits        37271    37265    -6     
+ Misses        612      609    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@okurz okurz force-pushed the feature/style_warnings_strict_base_signatures branch from e343040 to b295d47 Compare March 14, 2024 09:13
Copy link
Contributor

mergify bot commented Apr 15, 2024

This pull request is now in conflicts. Could you fix it? 🙏

@okurz okurz changed the title WIP: More signatures - after #5510 WIP: More signatures Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant