Simplify Resource::Locks with direct return of boolean calculations

os-autoinst · Mar 14, 2024 · e343040 · e343040
1 parent 454385e
commit e343040
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/lib/OpenQA/Resource/Locks.pm b/lib/OpenQA/Resource/Locks.pm
@@ -121,16 +121,12 @@ sub barrier_wait ($name = undef, $jobid = undef, $where = undef, $check_dead_job
         }
     }
 
-    if (grep { $_ eq $jobid } @jobs) {
-        return 1 if @jobs == $barrier->count;
-        return 0;
-    }
+    return @jobs == $barrier->count if grep { $_ eq $jobid } @jobs;
 
     push @jobs, $jobid;
     $barrier->update({locked_by => join(',', @jobs)});
 
-    return 1 if @jobs == $barrier->count;
-    return 0;
+    return @jobs == $barrier->count;
 }
 
 sub barrier_destroy ($name = undef, $jobid = undef, $where = undef) {