Skip to content

refactor(web): enforce the panels feature boundary - #361

Open
luannn010 wants to merge 1 commit into
refactor/onboarding-public-apifrom
refactor/panels-public-api
Open

luannn010 wants to merge 1 commit into
refactor/onboarding-public-apifrom
refactor/panels-public-api

Conversation

@luannn010

@luannn010 luannn010 commented Nov 8, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Related #334

Risk: broader module initialization. Rollback: revert this commit.

Parity rows

none

Frames built

Frames built: none

Testing

  • Windows: 429 focused tests, two startup/title-bar App cases and full type/lint/build passed.
  • Independent source review: no findings. All three emitted CSS files are byte-identical to the predecessor.
  • Not run locally: full suite, browser/canvas rendering, Rust, packaged app, macOS or real providers.

Co-authors

none

AI usage

  • Written by hand, with no AI
  • Harness and version: Codex desktop; Codex CLI 0.160.0; native agents, PowerShell, Python, Git, GitHub CLI, Node/npm, ESLint, TypeScript, Vitest and Vite.
  • Models: gpt-6.1-sol (design, integration, local verification and delivery; separate independent source reviewer); gpt-6.1-terra (nine-file panels implementation and fixtures); gpt-6-luna (coordinator's public issue/comment/linked-PR intake metadata and this piece's mechanical importer inventory; no design, implementation or runtime verification).
  • Effort: medium for all listed roles.
  • Additional gpt-6-luna role (medium): mechanical upstream export/import compatibility inventory; no design, implementation or runtime verification.
  • Human role: selected issue and authorized small pieces, the bounded branch sequence and ready stacked PR publication; retains merge authority.
  • Sources: Luan Nguyen's PR #285, commit 45a7297da5056f6e75db30ab7cc3b1bd8458677b. Its panels public-entry-point shape supplies the still-used SurfacePane and TerminalDrawerBody exports. The other current bindings follow today's consumers; unused PaneResizer is not restored. Same-repository reference; no outside source/assets copied.

Checklist

  • Works on Windows and macOS
  • web/src/generated with any contract change; docs/architecture.md with any rule change (neither changed)
  • No copied outside source, secrets, credentials or personal data; no AI attribution in commits, title or branch

@luannn010
luannn010 requested a review from kinqsradio as a code owner November 8, 2026 08:36
@github-actions github-actions Bot added the area: web web: React UI label Nov 8, 2026
@luannn010

luannn010 commented Nov 8, 2026 •

Copy link
Copy Markdown
Collaborator Author

@kinqsradio ready for review at e16b0cb2: all current-head checks are green. Panels boundary piece for #334; stacked on the preceding piece; merge in stack order. Focused consumer tests, type/lint/build and independent source/CSS review passed. Hosted Web and all eight E2E commands executed successfully; native/platform lanes were path-gated. See the PR for local qualification limits.

Expose the preview panels and route parser through features/panels/index.ts and use that door from the app shell.
@kinqsradio
kinqsradio force-pushed the refactor/onboarding-public-api branch from 1723418 to c83ad79 Compare November 10, 2026 06:01
@kinqsradio
kinqsradio force-pushed the refactor/panels-public-api branch from e16b0cb to dd484ad Compare November 10, 2026 06:01

@kinqsradio kinqsradio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed after rebuilding this layer on current main: it now uses features/panels/index.ts and the existing arch-check boundary instead of a parallel public.ts/ESLint layer. Head dd484ad; local npm run check, npm run build, cargo fmt and the Rust workspace suite passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: web web: React UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants